Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019111 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | minor | have not tried | 2011-11-18 12:47 | 2011-12-13 16:44 | |||
| Reporter | jonalegriaesarte | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 27caa9812cd1 | |||
| Projection | none | ETA | none | Target Version | 3.0MP7 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019111: Filters in query widgets are not working. | |||||||
| Description | Filters in query widgets are not working. | |||||||
| Steps To Reproduce | - In pi instance add (for example) Invoices to collect widget. - In minimized view, try filtering "Document Number" column -> Nothing is filtered. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  QueryWidgetFilter.png [^] (35,820 bytes) 2011-11-18 12:47
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0043595) alostale (manager) 2011-11-30 16:50 |
By design http://wiki.openbravo.com/wiki/Projects/QueryList_Widget/Functional_Specs [^] only maximized view should allow to filter. Here the issue, is the filter is shown in workspace view when the widget is added. Note filtering disapears on next login. |
|
(0043631) alostale (manager) 2011-12-01 10:53 |
Test plan: -Add a new query list widget and check no filter is shown -Relogin with that user check filter is not present -Maximize, check it is possible to filter Regression risk: none, modifying a property in query list widget that shouldn't affect other pieces. |
|
(0043772) hgbot (developer) 2011-12-12 08:31 |
Repository: erp/devel/pi Changeset: 27caa9812cd15c05dd797765d7ab836cda1d0d0f Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu Dec 01 10:54:12 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/27caa9812cd15c05dd797765d7ab836cda1d0d0f [^] fixed bug 19111: Filters in query widgets shouldn't be shown in workspace --- M modules/org.openbravo.client.querylist/web/org.openbravo.client.querylist/js/ob-querylist-widget.js --- |
|
(0043794) iperdomo (reporter) 2011-12-12 12:00 |
Code review: For clarity/maintainability purposes, I would change the line: showFilter = this.viewMode === 'maximized'; to: showFilter = (this.viewMode === 'maximized'); In this way someone reading the code, will identify quickly that the is testing viewMode against a value and the result is assigned to a variable. https://code.openbravo.com/erp/devel/pi/rev [^] /27caa9812cd15c05dd797765d7ab836cda1d0d0f#l1.9 |
|
(0043805) hgbot (developer) 2011-12-12 16:36 |
Repository: erp/devel/pi Changeset: fd1af76deeeef4cffe35d9099519dd551c786779 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Mon Dec 12 16:35:19 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/fd1af76deeeef4cffe35d9099519dd551c786779 [^] related to issue 19111: Applied code review suggestion --- M modules/org.openbravo.client.querylist/web/org.openbravo.client.querylist/js/ob-querylist-widget.js --- |
|
(0043806) iperdomo (reporter) 2011-12-12 16:43 |
Tested on pi @ rev 516b2ef77059. Using finance role, i removed all querylist widgets * Added invoice to collect and checked that no filter is present in the workspace * log-out/log-in and checked again that no filter is present * maximize the widget and now the filters are present |
|
(0043839) hudsonbot (developer) 2011-12-13 16:43 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^] Maturity status: Test |
|
(0043848) hudsonbot (developer) 2011-12-13 16:44 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-11-18 12:47 | jonalegriaesarte | New Issue | |
| 2011-11-18 12:47 | jonalegriaesarte | Assigned To | => alostale |
| 2011-11-18 12:47 | jonalegriaesarte | File Added: QueryWidgetFilter.png | |
| 2011-11-18 12:47 | jonalegriaesarte | Modules | => Core |
| 2011-11-21 08:46 | alostale | Status | new => scheduled |
| 2011-11-21 08:46 | alostale | fix_in_branch | => pi |
| 2011-11-21 08:47 | alostale | Relationship added | has duplicate 0019056 |
| 2011-11-30 16:50 | alostale | Note Added: 0043595 | |
| 2011-12-01 10:53 | alostale | Note Added: 0043631 | |
| 2011-12-12 08:31 | hgbot | Checkin | |
| 2011-12-12 08:31 | hgbot | Note Added: 0043772 | |
| 2011-12-12 08:31 | hgbot | Status | scheduled => resolved |
| 2011-12-12 08:31 | hgbot | Resolution | open => fixed |
| 2011-12-12 08:31 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/27caa9812cd15c05dd797765d7ab836cda1d0d0f [^] |
| 2011-12-12 12:00 | iperdomo | Note Added: 0043794 | |
| 2011-12-12 16:36 | hgbot | Checkin | |
| 2011-12-12 16:36 | hgbot | Note Added: 0043805 | |
| 2011-12-12 16:43 | iperdomo | Note Added: 0043806 | |
| 2011-12-12 16:43 | iperdomo | Status | resolved => closed |
| 2011-12-13 16:43 | hudsonbot | Checkin | |
| 2011-12-13 16:43 | hudsonbot | Note Added: 0043839 | |
| 2011-12-13 16:44 | hudsonbot | Checkin | |
| 2011-12-13 16:44 | hudsonbot | Note Added: 0043848 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |