Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0018676 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] 09. Financial management | major | always | 2011-08-23 14:57 | 2011-11-15 13:25 | |||
| Reporter | azabaleta | View Status | public | |||||
| Assigned To | vmromanos | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | 2.50 | Fixed in SCM revision | d6ce8288ad44 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Advanced Payables and Receivables Mngmt | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0018676: Make a relationship between the credit payment (the one reconciled) and the later on created invoice payment | |||||||
| Description | make a relationship between the credit payment (the one reconciled) and the later on created invoice payment (which ends in a "payment made" status) This way, the invoice should finish "reconciled" and would be much easier to track down an accounting movement (reconciliation) to the invoiced matched to that credit. | |||||||
| Steps To Reproduce | 1. Financial Account. Create a new bank statment and bankstatementline, selecting a business partner and the amount in (1000€). Process the bank statment. 2. Create a new transaction, add payment, mark the check "leave the credit to use later", same amount and bp. The bs line should be cleared with the transaction added. 3. new sales invoice for the same bp and complete. 4. add payment from the invoice header. mark check "use available credit" and process the payment. 5. go to payment report. look for the invoice status. It's "Payment Made". | |||||||
| Proposed Solution | Here is described the way we will implement this feature request. There modules will be affected: Core, APRM and Payment report. - A new table called FIN_PAYMENT_CREDIT is created. This table stores the relationship between credit payments and payments that use credit. This table is represented as a tab called Used Credit Source inside the Payment In and Payment Out windows. When a payment has used one or more credit payments, it shows the credit payments and amounts used. The user can also use the Linked item feature to navigate from a credit payment to the payments that use it. - When completing and invoice, if the invoice's business partner has credit payments available, the system shows automatically a new popup just after completing the invoice. This popup allows the user to select the credit payments and the amount he wants to use of each one. By default, this popup tries to give the user the best configuration possible, i.e. selecting by default the oldest credit payments and the right amount to fully pay the invoice. However, the user will have the opportunity to modify this proposal. The popup will validate the user data to ensure it's OK (we don't pay more than the invoice's grand total amount, we don't use more amount than the available in the credit payment, etc.) - A new flag called Include Payments Using Credit is added to the payment report. This flag, which is checked by default, allows the user to include/exclude in the report all the payments that are using credit payments. - The description of the payment has also been added to the report: a new column has been added in the spreadsheet format, and a new context message with the payment's description is shown when the mouse is over the payment name in the report's HTML format - The invoice column shows also the invoices paid using a credit payment. An asterisk in shown before the invoice number to reflect this invoice has been paid using a credit payment. In case several invoices have been paid with the same credit payment, two asterisks are shown before the list of invoice document numbers. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0042481) hgbot (developer) 2011-11-03 15:55 |
Repository: erp/stable/2.50 Changeset: c3a22677e2103659a2d2ce004b1d8c74d6087a3d Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Mon Oct 03 17:57:26 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/c3a22677e2103659a2d2ce004b1d8c74d6087a3d [^] Issue 18676 The payments that generate credit and the ones that consume them are now linked through the FIN_PAYMENT_CREDIT table --- M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_TAB.xml M src-db/database/sourcedata/AD_TABLE.xml A src-db/database/model/tables/FIN_PAYMENT_CREDIT.xml --- |
|
(0042482) hgbot (developer) 2011-11-03 15:55 |
Repository: erp/stable/2.50 Changeset: fdaf105e8788fc180c34e9ede983787f964986ab Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Mon Oct 03 18:06:53 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/fdaf105e8788fc180c34e9ede983787f964986ab [^] Issue 18676: Tab renamed to "Used Credit Source" Removed rows from the OB3 port --- M src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_MODEL_OBJECT.xml M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml M src-db/database/sourcedata/AD_TAB.xml --- |
|
(0042483) hgbot (developer) 2011-11-03 15:55 |
Repository: erp/stable/2.50 Changeset: 63af075ac5ce252fb11e81fc09edc021020dbdbb Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Thu Oct 06 15:29:01 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/63af075ac5ce252fb11e81fc09edc021020dbdbb [^] Issue 18676 Added popup wizard for selecting credit payments. This popup will be shown when completing an invoice, only in case the invoice's business partner has credit payments available --- A src/org/openbravo/erpCommon/ad_actionButton/AddCreditPaymentGrid.srpt A src/org/openbravo/erpCommon/ad_actionButton/AddCreditPaymentGrid.xml A src/org/openbravo/erpCommon/ad_actionButton/CreditPaymentGrid.html A src/org/openbravo/erpCommon/ad_actionButton/CreditPaymentGrid.xml --- |
|
(0042484) hgbot (developer) 2011-11-03 15:55 |
Repository: erp/stable/2.50 Changeset: cbbc1bc4d1618f6a9b5972c208be5877638ae158 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Thu Oct 06 17:00:30 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/cbbc1bc4d1618f6a9b5972c208be5877638ae158 [^] Issue 18676 Refactor code. Added AD_Textinterface records --- M src-db/database/sourcedata/AD_TEXTINTERFACES.xml M src/org/openbravo/erpCommon/ad_actionButton/CreditPaymentGrid.html --- |
|
(0042485) hgbot (developer) 2011-11-03 15:55 |
Repository: erp/stable/2.50 Changeset: 665e4a2bb89c57178bfede4938fc0d78d93a12fb Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Fri Oct 07 14:46:52 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/665e4a2bb89c57178bfede4938fc0d78d93a12fb [^] Issue 18676 fixed minor issues. prepared for adding new payment date field --- M src/org/openbravo/erpCommon/ad_actionButton/CreditPaymentGrid.html M src/org/openbravo/erpCommon/ad_actionButton/CreditPaymentGrid.xml --- |
|
(0042486) hgbot (developer) 2011-11-03 15:56 |
Repository: erp/mods/org.openbravo.financial.paymentreport Changeset: 34a81e44a75de34b894e7b82a8d2e7bf5204cdc8 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Tue Oct 18 11:13:17 2011 +0200 URL: http://code.openbravo.com/erp/mods/org.openbravo.financial.paymentreport/rev/34a81e44a75de34b894e7b82a8d2e7bf5204cdc8 [^] Issue 18676 Added Include Payments Using Credit flag Included description as a context info in the HTML format Included description as a new column in the Excel file --- M src-db/database/sourcedata/AD_MODULE.xml M src-db/database/sourcedata/AD_TEXTINTERFACES.xml M src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.html M src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.java M src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.xml M src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java M src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportExcel.jrxml M src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportPDF.jrxml --- |
|
(0042487) hgbot (developer) 2011-11-03 15:56 |
Repository: erp/stable/2.50 Changeset: 3ce81d9fc6a07d02864d8b0e59c2d2805ee724bd Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Mon Oct 10 10:15:54 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/3ce81d9fc6a07d02864d8b0e59c2d2805ee724bd [^] Issue 18676 Added Payment Date field. By default we use invoice date --- M src/org/openbravo/erpCommon/ad_actionButton/CreditPaymentGrid.html M src/org/openbravo/erpCommon/ad_actionButton/CreditPaymentGrid.xml --- |
|
(0042488) hgbot (developer) 2011-11-03 15:56 |
Repository: erp/stable/2.50 Changeset: 7a338edd1948179ff12bde743e13f6d1a2f9c27c Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Mon Oct 10 14:12:08 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/7a338edd1948179ff12bde743e13f6d1a2f9c27c [^] Issue 18676 Added validation before processing --- M src/org/openbravo/erpCommon/ad_actionButton/AddCreditPaymentGrid.xml M src/org/openbravo/erpCommon/ad_actionButton/CreditPaymentGrid.html --- |
|
(0042489) hgbot (developer) 2011-11-03 15:56 |
Repository: erp/stable/2.50 Changeset: 357a1634824f2dbd554101d14333ca747d2a2e49 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Tue Oct 11 09:07:16 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/357a1634824f2dbd554101d14333ca747d2a2e49 [^] Issue 18676 Moved FIN_Payment table reference to core --- M src-db/database/sourcedata/AD_REFERENCE.xml M src-db/database/sourcedata/AD_REF_TABLE.xml --- |
|
(0042490) hgbot (developer) 2011-11-03 15:56 |
Repository: erp/stable/2.50 Changeset: 25b4bbecaac62c13e15aa2229d2483e42bc57909 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Tue Oct 11 10:33:23 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/25b4bbecaac62c13e15aa2229d2483e42bc57909 [^] Issue 18676 Created new table reference to FIN_Payment in core --- M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_REFERENCE.xml M src-db/database/sourcedata/AD_REF_TABLE.xml --- |
|
(0042491) hgbot (developer) 2011-11-03 15:56 |
Repository: erp/stable/2.50 Changeset: 0e8e68d59142e047e1605154007a14fe70632976 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Tue Oct 11 11:42:21 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/0e8e68d59142e047e1605154007a14fe70632976 [^] Fixed issue 18676 Fixed mapping name defect --- M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml --- |
|
(0042492) hgbot (developer) 2011-11-03 15:56 |
Repository: erp/stable/2.50 Changeset: c8ab4f44d668765e10745b266bde378dc9d4cee8 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Mon Oct 17 19:02:13 2011 +0200 URL: http://code.openbravo.com/erp/stable/2.50/rev/c8ab4f44d668765e10745b266bde378dc9d4cee8 [^] Issue 18676 Organization info is keep to execution process fixed submitCommandForm 5º parameter --- M src/org/openbravo/erpCommon/ad_actionButton/CreditPaymentGrid.html M src/org/openbravo/erpCommon/ad_actionButton/CreditPaymentGrid.xml --- |
|
(0042496) hgbot (developer) 2011-11-03 16:48 |
Repository: erp/pmods/org.openbravo.advpaymentmngt Changeset: 656a2d14fd1062d6f151008c2c891a8a09892abb Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Mon Oct 03 17:57:53 2011 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/656a2d14fd1062d6f151008c2c891a8a09892abb [^] Issue 18676 The payments that generate credit and the ones that consume them are now linked through the FIN_PAYMENT_CREDIT table --- M src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java --- |
|
(0042497) hgbot (developer) 2011-11-03 16:48 |
Repository: erp/pmods/org.openbravo.advpaymentmngt Changeset: a7c7b6e24bdc2d2f49f95ce7037fd7a24939dff0 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Fri Oct 07 14:47:49 2011 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/a7c7b6e24bdc2d2f49f95ce7037fd7a24939dff0 [^] Issue 18676 Implemented use credit payment and link payments when completing invoice --- M src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java M src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java M src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java --- |
|
(0042498) hgbot (developer) 2011-11-03 16:48 |
Repository: erp/pmods/org.openbravo.advpaymentmngt Changeset: 6df32b82e009230194224ff5d446c27b0760914a Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Mon Oct 10 10:16:17 2011 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/6df32b82e009230194224ff5d446c27b0760914a [^] Issue 18676 Added Payment Date field. By default we use invoice date --- M src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java --- |
|
(0042499) hgbot (developer) 2011-11-03 16:48 |
Repository: erp/pmods/org.openbravo.advpaymentmngt Changeset: bd624fb15d6b7166e0248a5a27873833cdce92e9 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Mon Oct 17 19:01:16 2011 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/bd624fb15d6b7166e0248a5a27873833cdce92e9 [^] Issue 18676 Improved descriptions control Improved reactivation process --- M src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java M src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java M src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java --- |
|
(0042500) hgbot (developer) 2011-11-03 16:48 |
Repository: erp/pmods/org.openbravo.advpaymentmngt Changeset: 5a66fd952e7d814c6531b0331412a1ec9c4c854a Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Tue Oct 18 10:59:50 2011 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/5a66fd952e7d814c6531b0331412a1ec9c4c854a [^] Issue 18676 We only remove the description in the credit payment that corresponds to the payment that pays the same invoices --- M src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java --- |
|
(0042501) hgbot (developer) 2011-11-03 16:49 |
Repository: erp/pmods/org.openbravo.advpaymentmngt Changeset: d6ce8288ad44e252358dd6187a8c85ca19e66413 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Wed Nov 02 18:08:36 2011 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/d6ce8288ad44e252358dd6187a8c85ca19e66413 [^] Fixed issue 18676: Applied code review Added module script to link credit payment in existing instances --- M src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java M src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java M src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java M src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java M src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java A build/classes/org/openbravo/advpaymentmngt/modulescript/LinkCreditPayments.class A build/classes/org/openbravo/advpaymentmngt/modulescript/LinkCreditPaymentsData.class A src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/LinkCreditPayments.java A src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/LinkCreditPayments_data.xsql A src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/LinkCreditPaymentsData.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-10-03 17:51 | vmromanos | Type | feature request => backport |
| 2011-10-03 17:51 | vmromanos | fix_in_branch | => 2.50 |
| 2011-10-14 09:24 | vmromanos | Proposed Solution updated | |
| 2011-10-20 18:25 | vmromanos | Proposed Solution updated | |
| 2011-11-03 15:55 | hgbot | Checkin | |
| 2011-11-03 15:55 | hgbot | Note Added: 0042481 | |
| 2011-11-03 15:55 | hgbot | Checkin | |
| 2011-11-03 15:55 | hgbot | Note Added: 0042482 | |
| 2011-11-03 15:55 | hgbot | Checkin | |
| 2011-11-03 15:55 | hgbot | Note Added: 0042483 | |
| 2011-11-03 15:55 | hgbot | Checkin | |
| 2011-11-03 15:55 | hgbot | Note Added: 0042484 | |
| 2011-11-03 15:55 | hgbot | Checkin | |
| 2011-11-03 15:55 | hgbot | Note Added: 0042485 | |
| 2011-11-03 15:56 | hgbot | Checkin | |
| 2011-11-03 15:56 | hgbot | Note Added: 0042486 | |
| 2011-11-03 15:56 | hgbot | Checkin | |
| 2011-11-03 15:56 | hgbot | Note Added: 0042487 | |
| 2011-11-03 15:56 | hgbot | Checkin | |
| 2011-11-03 15:56 | hgbot | Note Added: 0042488 | |
| 2011-11-03 15:56 | hgbot | Checkin | |
| 2011-11-03 15:56 | hgbot | Note Added: 0042489 | |
| 2011-11-03 15:56 | hgbot | Checkin | |
| 2011-11-03 15:56 | hgbot | Note Added: 0042490 | |
| 2011-11-03 15:56 | hgbot | Checkin | |
| 2011-11-03 15:56 | hgbot | Note Added: 0042491 | |
| 2011-11-03 15:56 | hgbot | Status | scheduled => resolved |
| 2011-11-03 15:56 | hgbot | Resolution | open => fixed |
| 2011-11-03 15:56 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/stable/2.50/rev/0e8e68d59142e047e1605154007a14fe70632976 [^] |
| 2011-11-03 15:56 | hgbot | Checkin | |
| 2011-11-03 15:56 | hgbot | Note Added: 0042492 | |
| 2011-11-03 16:48 | hgbot | Checkin | |
| 2011-11-03 16:48 | hgbot | Note Added: 0042496 | |
| 2011-11-03 16:48 | hgbot | Checkin | |
| 2011-11-03 16:48 | hgbot | Note Added: 0042497 | |
| 2011-11-03 16:48 | hgbot | Checkin | |
| 2011-11-03 16:48 | hgbot | Note Added: 0042498 | |
| 2011-11-03 16:48 | hgbot | Checkin | |
| 2011-11-03 16:48 | hgbot | Note Added: 0042499 | |
| 2011-11-03 16:48 | hgbot | Checkin | |
| 2011-11-03 16:48 | hgbot | Note Added: 0042500 | |
| 2011-11-03 16:49 | hgbot | Checkin | |
| 2011-11-03 16:49 | hgbot | Note Added: 0042501 | |
| 2011-11-03 16:49 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/stable/2.50/rev/0e8e68d59142e047e1605154007a14fe70632976 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/d6ce8288ad44e252358dd6187a8c85ca19e66413 [^] |
| 2011-11-15 13:25 | eduardo_Argal | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |