0018487: Void payment in/out with gl item lines does not work properly

Description

When you void a payment containing GL Items the payment remains in a non stable status.

Steps To Reproduce

1) Configure new payment method as follows:
- Payment In Allowed: Yes
- Execution Type: Automatic
- Execution Process: Simple Execution Process
- Deferred: Yes
2) Create new Payment In and select in the header previously created payment method.
3) Click on Add Details button
4) Select GL Item transaction type
5) Add any GL Item and click on Process button
6) Try to void the payment.
6.1) Click on Reactivate button
6.2) Select Void option
7) Check the payment status
7.1) Payment Line is removed
7.2) Generated credit is updated.

Proposed Solution

The payment line should be canceled not removed.
The generated credit should not be affected when voiding a payment with gl items.

FIN_PaymentProcess.java line 544
GL Item payment line is taken as a credit payment:
else if (paymentScheduleDetail.getOrderPaymentSchedule() == null
&& paymentScheduleDetail.getInvoicePaymentSchedule() == null)

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0018431

3.0MP5

closed

vmromanos

Void payment in/out with gl item lines does not work properly

Notes
(0040845) hgbot (developer) 2011-09-09 14:11	Repository: erp/pmods/org.openbravo.advpaymentmngt Changeset: aae7590271c7597dde81e807a0b28d32debc2386 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Fri Sep 09 14:13:06 2011 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/aae7590271c7597dde81e807a0b28d32debc2386 [^] Fixed bug 18487: Void payment in/out with gl item lines does not work properly The payment line should be canceled not removed. The generated credit should not be affected when voiding a payment with gl items. --- M src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java ---

(0041025) psanjuan (manager) 2011-09-16 15:02	fixed and working

Issue History
Date Modified	Username	Field	Change
2011-09-09 13:57	vmromanos	Type	defect => backport
2011-09-09 13:57	vmromanos	fix_in_branch	=> 2.50
2011-09-09 14:11	hgbot	Checkin
2011-09-09 14:11	hgbot	Note Added: 0040845
2011-09-09 14:11	hgbot	Status	scheduled => resolved
2011-09-09 14:11	hgbot	Resolution	open => fixed
2011-09-09 14:11	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/aae7590271c7597dde81e807a0b28d32debc2386 [^]
2011-09-16 15:02	psanjuan	Note Added: 0041025
2011-09-16 15:02	psanjuan	Status	resolved => closed