Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0017853 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2011-06-30 15:32 | 2011-07-06 02:43 | |||
| Reporter | rgoris | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | f0ea5cc1072f | ||||
| Projection | none | ETA | none | Target Version | 3.0MP1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0017853: ESC to cancel does not work for read-only rows when edited | |||||||
| Description | Somehow this is logical but still not nice for the user. Since the row is readonly, nothing is changed and the edit mode never starts. Still, ESC should be the exit for the user. | |||||||
| Steps To Reproduce | Select a booked sales order Press pen button to get into edit mode Row cant be edited (because it is booked) Now you want to press the ESC key to cancel Nothing happens | |||||||
| Proposed Solution | One of the two solutions: (1) Do not allow editing at all for readonly rows (hide pen icon, and Edit item in context menu) (2) Do allow editing (well, sort of) but make sure ESC works. (1) is much better but what I understood,much more work. So maybe implementing ESC for the time being is best. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  ESC-to-cancel.png [^] (139,272 bytes) 2011-06-30 15:32
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0038700) hgbot (developer) 2011-07-01 23:27 |
Repository: erp/devel/pi Changeset: f0ea5cc1072f10bc6e5da02c3a5e9786883a2005 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Fri Jul 01 23:25:51 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/f0ea5cc1072f10bc6e5da02c3a5e9786883a2005 [^] Fixes issue 17853: ESC to cancel does not work for read-only rows when edited --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js --- |
|
(0038702) rgoris (developer) 2011-07-02 15:05 |
Excellent fixes again Martin :-) |
|
(0038708) hgbot (developer) 2011-07-02 16:44 |
Repository: erp/devel/pi Changeset: 7c5f9bf662ac8435b0e471313590bc17822c755c Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sat Jul 02 16:42:08 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/7c5f9bf662ac8435b0e471313590bc17822c755c [^] Related to issue 17853: ESC to cancel does not work for read-only rows when edited Added check on ctrl, alt, shft keys and return false --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js --- |
|
(0038709) hgbot (developer) 2011-07-02 16:45 |
Repository: erp/devel/pi Changeset: f16df639d37d2db3c58a10d22f5b2b5847b62e9a Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sat Jul 02 16:43:45 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/f16df639d37d2db3c58a10d22f5b2b5847b62e9a [^] Related to issue 17853: ESC to cancel does not work for read-only rows when edited, Related to issue 17836: Add Jump-to-selected-row in grid Added check on ctrl, shft, alt and return false Made changes for 17836 to have style controlled through the sin --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js --- |
|
(0038719) hgbot (developer) 2011-07-02 18:20 |
Repository: erp/devel/pi Changeset: 50f8f74bf2be18346a944f758b09d58d2f07149d Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sat Jul 02 18:19:55 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/50f8f74bf2be18346a944f758b09d58d2f07149d [^] Related to issue 17853: ESC to cancel does not work for read-only rows when edited Repaired wrong key combination setting --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js --- |
|
(0038861) hudsonbot (developer) 2011-07-06 02:42 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^] Maturity status: Test |
|
(0038866) hudsonbot (developer) 2011-07-06 02:42 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^] Maturity status: Test |
|
(0038867) hudsonbot (developer) 2011-07-06 02:43 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^] Maturity status: Test |
|
(0038871) hudsonbot (developer) 2011-07-06 02:43 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-06-30 15:32 | rgoris | New Issue | |
| 2011-06-30 15:32 | rgoris | Assigned To | => mtaal |
| 2011-06-30 15:32 | rgoris | File Added: ESC-to-cancel.png | |
| 2011-06-30 15:32 | rgoris | Modules | => Core |
| 2011-07-01 23:27 | hgbot | Checkin | |
| 2011-07-01 23:27 | hgbot | Note Added: 0038700 | |
| 2011-07-01 23:27 | hgbot | Status | new => resolved |
| 2011-07-01 23:27 | hgbot | Resolution | open => fixed |
| 2011-07-01 23:27 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/f0ea5cc1072f10bc6e5da02c3a5e9786883a2005 [^] |
| 2011-07-02 15:05 | rgoris | Note Added: 0038702 | |
| 2011-07-02 15:05 | rgoris | Status | resolved => closed |
| 2011-07-02 16:44 | hgbot | Checkin | |
| 2011-07-02 16:44 | hgbot | Note Added: 0038708 | |
| 2011-07-02 16:45 | hgbot | Checkin | |
| 2011-07-02 16:45 | hgbot | Note Added: 0038709 | |
| 2011-07-02 18:20 | hgbot | Checkin | |
| 2011-07-02 18:20 | hgbot | Note Added: 0038719 | |
| 2011-07-06 02:42 | hudsonbot | Checkin | |
| 2011-07-06 02:42 | hudsonbot | Note Added: 0038861 | |
| 2011-07-06 02:42 | hudsonbot | Checkin | |
| 2011-07-06 02:42 | hudsonbot | Note Added: 0038866 | |
| 2011-07-06 02:43 | hudsonbot | Checkin | |
| 2011-07-06 02:43 | hudsonbot | Note Added: 0038867 | |
| 2011-07-06 02:43 | hudsonbot | Checkin | |
| 2011-07-06 02:43 | hudsonbot | Note Added: 0038871 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |