Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0017397 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2011-05-27 11:24 | 2011-06-01 12:06 | |||
| Reporter | rgoris | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 696fc38dd3e9 | |||
| Projection | none | ETA | none | Target Version | 3.0MP0 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0017397: Grid Editing: cannot cancel editing of rows | |||||||
| Description | Edit mode in rows cannot be canceled. See video. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  GridEditIssue.mp4 [^] (1,292,972 bytes) 2011-05-27 11:24 Capture.PNG [^] (55,804 bytes) 2011-06-01 09:47
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0037692) rgoris (developer) 2011-05-30 11:15 |
Still persists as of today. |
|
(0037704) dmitry_mezentsev (developer) 2011-05-30 11:45 |
I also saw it (in Purchase Invoice, Sales Invoice). The thing is that pressing Edit on next row does not actually puts it into the edit mode (no fields are selected to be edited). At the same time for example in the Sales Order window I cannot reproduce it, it works correctly. Interesting thing here is that, for example, for Purchase Order from the videos Edit Button should not appear at all because it is already processed and all the fields are read-only (if you switch to the Form view - you cannot edit document). |
|
(0037721) mtaal (manager) 2011-05-30 13:10 |
I think that's also what goes 'wrong' here. The row is in edit mode but you can't edit any of the fields. So therefore it gives this impression. Maybe the solution is to give a warning if none of the form fields are editable and then go back to non-edit state. The 'problem' is that we don't know if the fields are editable until we actually open/start the form. So therefore the edit button is shown. It is a feature request for MP1 to support non-editable taking into account the state of the object. The video shows also a real error (that's what the issue is for), that you can have multiple rows in edit mode and cancel does not work. |
|
(0037762) hgbot (developer) 2011-05-31 08:45 |
Repository: erp/devel/pi Changeset: 696fc38dd3e9471df130c956f18b820433062741 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue May 31 08:44:52 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/696fc38dd3e9471df130c956f18b820433062741 [^] Fixes issue 17397: Grid Editing: cannot cancel editing of rows --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js --- |
|
(0037851) hudsonbot (developer) 2011-05-31 21:36 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b7e7d64488f5 [^] Maturity status: Test |
|
(0037866) rgoris (developer) 2011-06-01 09:49 |
Problem persists in today´s live build. It was pushed last night so it should have been visible by now. Please check, i also added another screenshot. |
|
(0037868) mtaal (manager) 2011-06-01 10:08 |
live build is from 30th of may so does not contain the solution: http://builds.openbravo.com/job/int-full-pgsql/2074/ [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-05-27 11:24 | rgoris | New Issue | |
| 2011-05-27 11:24 | rgoris | Assigned To | => alostale |
| 2011-05-27 11:24 | rgoris | File Added: GridEditIssue.mp4 | |
| 2011-05-27 11:24 | rgoris | Modules | => Core |
| 2011-05-27 11:25 | rgoris | Assigned To | alostale => mtaal |
| 2011-05-27 11:25 | rgoris | Target Version | => 3.0MP0 |
| 2011-05-30 11:15 | rgoris | Status | new => scheduled |
| 2011-05-30 11:15 | rgoris | Note Added: 0037692 | |
| 2011-05-30 11:15 | rgoris | fix_in_branch | => pi |
| 2011-05-30 11:45 | dmitry_mezentsev | Note Added: 0037704 | |
| 2011-05-30 13:10 | mtaal | Note Added: 0037721 | |
| 2011-05-31 08:45 | hgbot | Checkin | |
| 2011-05-31 08:45 | hgbot | Note Added: 0037762 | |
| 2011-05-31 08:45 | hgbot | Status | scheduled => resolved |
| 2011-05-31 08:45 | hgbot | Resolution | open => fixed |
| 2011-05-31 08:45 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/696fc38dd3e9471df130c956f18b820433062741 [^] |
| 2011-05-31 21:36 | hudsonbot | Checkin | |
| 2011-05-31 21:36 | hudsonbot | Note Added: 0037851 | |
| 2011-06-01 09:47 | rgoris | File Added: Capture.PNG | |
| 2011-06-01 09:49 | rgoris | Note Added: 0037866 | |
| 2011-06-01 09:49 | rgoris | Status | resolved => new |
| 2011-06-01 09:49 | rgoris | Resolution | fixed => open |
| 2011-06-01 09:49 | rgoris | Status | new => scheduled |
| 2011-06-01 10:08 | mtaal | Note Added: 0037868 | |
| 2011-06-01 10:08 | mtaal | Status | scheduled => resolved |
| 2011-06-01 10:08 | mtaal | Resolution | open => fixed |
| 2011-06-01 12:06 | rgoris | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |