Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0017378
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2011-05-26 14:142011-06-02 10:27
ReporterpsarobeView Statuspublic 
Assigned Toiperdomo 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisione99d7f19209a
ProjectionnoneETAnoneTarget Version3.0MP0
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0017378: Refresh button must be disabled when editing a record either in the grid or in the form

DescriptionRight now when you are editing (or new) the grid or the form the button Refresh button is enabled and when pressing it the behaviour is not correct. It tries to save the record, etc

We have decided to disable when editing a record since it makes no sense to refresh the data
Steps To Reproduce1. Go to Product window
2. Edit a product in grid view. Button Refresh should be disabled
3. Edit a product in form view. Button Refresh should be disabled
4. Click new in form view. Button Refresh should be disabled
5. Click new in grid view. Button Refresh should be disabled
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0037680)
hgbot (developer)
2011-05-27 18:46

Repository: erp/devel/pi
Changeset: e99d7f19209a184a080bfa516d6c3dc46420241e
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri May 27 18:45:40 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e99d7f19209a184a080bfa516d6c3dc46420241e [^]

Fixes issue 17378: Disable reload button when editing and in new state

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0037790)
hudsonbot (developer)
2011-05-31 09:44

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ea275e03a164 [^]

Maturity status: Test
(0037905)
marvintm (developer)
2011-06-02 10:27

The fix is correct, although it's not exactly done as what the issue proposed. The important thing is that the refresh button will not be active if its action would trigger autosave. Therefore:

- When creating a new record (in form or grid view) the button is disabled.
- When editing an existing record (in form or grid view), the button is enabled if the user hasn't done any change (because refreshing would be harmless in this case). If the user does any change, the button is disabled (because clicking it in this case would trigger autosave).

- Issue History
Date Modified Username Field Change
2011-05-26 14:14 psarobe New Issue
2011-05-26 14:14 psarobe Assigned To => iperdomo
2011-05-26 14:14 psarobe Modules => Core
2011-05-26 18:16 iperdomo Status new => scheduled
2011-05-26 18:16 iperdomo fix_in_branch => pi
2011-05-27 18:46 hgbot Checkin
2011-05-27 18:46 hgbot Note Added: 0037680
2011-05-27 18:46 hgbot Status scheduled => resolved
2011-05-27 18:46 hgbot Resolution open => fixed
2011-05-27 18:46 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e99d7f19209a184a080bfa516d6c3dc46420241e [^]
2011-05-31 09:44 hudsonbot Checkin
2011-05-31 09:44 hudsonbot Note Added: 0037790
2011-06-02 10:27 marvintm Note Added: 0037905
2011-06-02 10:27 marvintm Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker