0017353: synchronize terminology is not translating some purchase window's field without specific translation for purchase

Description

synchronize terminology is not translating some purchase window's field without specific translation for purchase

Steps To Reproduce

0. install Spanish language translation
1. Modify element translation of "Account_ID" columnname.
2. Set core as in development
3. Run Synchronize terminology procedure and realize field translation is not properly updated

Proposed Solution

* Function ad_synchronize is filtering by

AND (e.PO_Name IS NOT NULL AND e.PO_Name <> '')

when po_name field is empty is not properly updating AD_FIELD_TRL table with name field. This clause needs to be removed in lines 671 and 715

* Also AD_FIELD_TRL update of line 629 and 635 needs to be corrected to properly set value of Name, Description and Help fields.

It is necessary to replace blocks like:
SET NAME=
      (SELECT e.PO_Name
      FROM AD_ELEMENT_TRL e, AD_COLUMN c, AD_FIELD f
      WHERE e.AD_LANGUAGE=AD_FIELD_TRL.AD_LANGUAGE AND e.AD_Element_ID=c.AD_Element_ID
      AND c.AD_Column_ID=f.AD_Column_ID AND f.AD_Field_ID=AD_FIELD_TRL.AD_Field_ID
      )

by this other code:

SET NAME=
      (SELECT (CASE WHEN e.PO_Name='' THEN e.Name
           ELSE COALESCE(e.PO_Name, e.Name)
       END)
      FROM AD_ELEMENT_TRL e, AD_COLUMN c, AD_FIELD f
      WHERE e.AD_LANGUAGE=AD_FIELD_TRL.AD_LANGUAGE AND e.AD_Element_ID=c.AD_Element_ID
      AND c.AD_Column_ID=f.AD_Column_ID AND f.AD_Field_ID=AD_FIELD_TRL.AD_Field_ID
      )

[same for description and help fields]

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

0017755

2.50MP32

closed

egoitz

synchronize terminology is not translating some purchase window's field without specific translation for purchase

Notes
(0038418) hgbot (developer) 2011-06-21 17:40	Repository: erp/devel/pi Changeset: 6018a448018ba443b6364cf672e6f1a3032a9a4b Author: Egoitz Castillo <egoitz.castillo <at> openbravo.com> Date: Tue Jun 21 17:38:21 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/6018a448018ba443b6364cf672e6f1a3032a9a4b [^] Fixed Issue 17353. Syncronize terminology on purchase elements --- M src-db/database/model/functions/AD_SYNCHRONIZE.xml ---

(0038475) hudsonbot (viewer) 2011-06-22 11:44	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/abb438586c0e [^] Maturity status: Test

(0039025) maite (viewer) 2011-07-13 09:49	verified

Issue History
Date Modified	Username	Field	Change
2011-05-25 13:27	maite	New Issue
2011-05-25 13:27	maite	Assigned To	=> alostale
2011-05-25 13:27	maite	Modules	=> Core
2011-05-25 13:27	maite	OBNetwork customer	=> Yes
2011-05-25 13:27	maite	Assigned To	alostale => egoitz
2011-05-25 13:28	maite	Issue Monitored: networkb
2011-06-21 10:59	egoitz	Status	new => scheduled
2011-06-21 10:59	egoitz	fix_in_branch	=> pi
2011-06-21 17:40	hgbot	Checkin
2011-06-21 17:40	hgbot	Note Added: 0038418
2011-06-21 17:40	hgbot	Status	scheduled => resolved
2011-06-21 17:40	hgbot	Resolution	open => fixed
2011-06-21 17:40	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/6018a448018ba443b6364cf672e6f1a3032a9a4b [^]
2011-06-22 11:44	hudsonbot	Checkin
2011-06-22 11:44	hudsonbot	Note Added: 0038475
2011-07-13 09:49	maite	Note Added: 0039025
2011-07-13 09:49	maite	Status	resolved => closed