Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0016775
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2011-04-12 17:272011-05-31 09:44
ReportershuehnerView Statuspublic 
Assigned Toiperdomo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision3bf5295a7f03
ProjectionnoneETAnoneTarget Version3.0MP0
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0016775: index.jsp code related to Authentication manager not having same behavior then copy in HSAS

DescriptionWhen code in index.jsp does throw an exception if the configured authentication manager cannot be found.

The central code in HSAS, does log an error to the log and transparently (for the user) uses the DefaultAuthenticationManager instead of breaking the login.

Attached patch add the same error handling and also improves the error message in HSAS to more specifically point to the problem.
TagsNo tags attached.
Attached Filesdiff file icon 16775.diff [^] (1,912 bytes) 2011-04-12 17:28 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0035871)
shuehner (administrator)
2011-04-12 18:35

Note: even with that patch behavior is not optimal. HSAS code does log an error is auth-manager cannot be loaded. But that happen only after login using builtin classic login page.

We should check if we can log similar error directly from index.jsp or centralize both code-copies.
(0036418)
dmitry_mezentsev (developer)
2011-05-05 17:46

Does not fit RC7.
(0037677)
hgbot (developer)
2011-05-27 17:45

Repository: erp/devel/pi
Changeset: 3bf5295a7f03f8de258c51e9e636e85d203a0a97
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri May 27 17:45:12 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3bf5295a7f03f8de258c51e9e636e85d203a0a97 [^]

Fixed 16775: Improve error handling if defined authentication.manager is missing
In case the defined authentication.manager can't be loaded log an error message
and use the default one instead of crashing with ClassNotFoundException.
Also improve error message in that case pointing to config option in config file

---
M src/index.jsp
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---
(0037708)
iperdomo (reporter)
2011-05-30 11:50

Changes made by Stefan.
Tested in pi @ rev b1c830dd5ee0
(0037787)
hudsonbot (developer)
2011-05-31 09:44

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ea275e03a164 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-04-12 17:27 shuehner New Issue
2011-04-12 17:27 shuehner Assigned To => alostale
2011-04-12 17:27 shuehner Modules => Core
2011-04-12 17:28 shuehner File Added: 16775.diff
2011-04-12 17:28 shuehner Assigned To alostale => iperdomo
2011-04-12 18:35 shuehner Note Added: 0035871
2011-05-02 10:47 alostale Status new => scheduled
2011-05-05 17:46 dmitry_mezentsev Note Added: 0036418
2011-05-05 17:46 dmitry_mezentsev Target Version 3.0RC7 => 3.0MP0
2011-05-27 17:45 hgbot Checkin
2011-05-27 17:45 hgbot Note Added: 0037677
2011-05-27 17:45 hgbot Status scheduled => resolved
2011-05-27 17:45 hgbot Resolution open => fixed
2011-05-27 17:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3bf5295a7f03f8de258c51e9e636e85d203a0a97 [^]
2011-05-30 11:50 iperdomo Note Added: 0037708
2011-05-30 11:50 iperdomo Status resolved => closed
2011-05-31 09:44 hudsonbot Checkin
2011-05-31 09:44 hudsonbot Note Added: 0037787


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker