Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0015958 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Y. DBSourceManager | major | always | 2011-02-11 18:32 | 2011-02-23 00:00 | |||
| Reporter | egoitz | View Status | public | |||||
| Assigned To | marvintm | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 811e1c898389 | ||||
| Projection | none | ETA | none | Target Version | 2.50MP28 | |||
| OS | Any | Database | PostgreSQL | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | 2.50MP25 | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0015958: If you add an exeception for a trigger of a module different that core, this is not correctly managed | |||||||
| Description | If you add an exeception for a trigger of a module different that core, this is not correctly managed. The trigger is correctly exported to your module, but when executing update.database, the trigger is replaced with the trigger of the original module. | |||||||
| Steps To Reproduce | -Install APRM -Modify a trigger from this module -Add a new module, check it as indevelopment. -Add an exception for the trigger modified -Export the module. -See that the module is correctly exported to your module -Execute: update.database *see that the module on the database is the original from ARPM instead of the trigger exported as exception. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0034303) marvintm (developer) 2011-02-22 12:08 |
The exception in this case was going to be used to overwrite a trigger which is contained in a module. The change which is going to be done consists in allowing configuration scripts to disable triggers. This way, the user will then be able to overwrite the functionality of the trigger by disabling it and then creating a new trigger in his own module, which can then be normally named using modularity rules, and exported normally. |
|
(0034313) hgbot (developer) 2011-02-22 15:06 |
Repository: erp/devel/dbsm-main Changeset: 7ea6b9f3a4f72a7c66e03d6d9ff854fc206f90d7 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Feb 22 15:06:32 2011 +0100 URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/7ea6b9f3a4f72a7c66e03d6d9ff854fc206f90d7 [^] Fixed issue 15958. Now RemoveTriggerChanges will be exported to the configuration scripts. --- M src/mapping.xml M src/org/apache/ddlutils/alteration/DataComparator.java M src/org/apache/ddlutils/alteration/RemoveTriggerChange.java --- |
|
(0034314) hgbot (developer) 2011-02-22 15:18 |
Repository: erp/devel/pi Changeset: 811e1c898389285ce7343588645100609e53aee2 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Feb 22 15:17:15 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/811e1c898389285ce7343588645100609e53aee2 [^] Fixed issue 15958. Now RemoveTriggerChanges will be exported to the configuration scripts. --- M src-db/database/lib/dbsourcemanager.jar --- |
|
(0034319) hgbot (developer) 2011-02-22 18:11 |
Repository: erp/devel/dbsm-main Changeset: 324c95b80e9cbd656658077a1daf5485e9e9b45a Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Feb 22 18:11:18 2011 +0100 URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/324c95b80e9cbd656658077a1daf5485e9e9b45a [^] Related to issue 15958. Do not remove triggers which are changed in the database, but not removed --- M src/org/apache/ddlutils/alteration/DataComparator.java M src/org/apache/ddlutils/alteration/RemoveTriggerChange.java --- |
|
(0034320) hgbot (developer) 2011-02-22 18:13 |
Repository: erp/devel/pi Changeset: 4222233f95c738419d7ce0d805e9215164e15d73 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Feb 22 18:12:05 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/4222233f95c738419d7ce0d805e9215164e15d73 [^] Related to issue 15958. Do not remove triggers which are changed in the database, but not removed --- M src-db/database/lib/dbsourcemanager.jar --- |
|
(0034321) hgbot (developer) 2011-02-22 18:14 |
Repository: erp/stable/2.50 Changeset: ac312f1987debebade289181391e027a3cf7677c Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Tue Feb 22 18:13:08 2011 +0100 URL: http://code.openbravo.com/erp/stable/2.50/rev/ac312f1987debebade289181391e027a3cf7677c [^] Related to issue 15958. Do not remove triggers which are changed in the database, but not removed --- M src-db/database/lib/dbsourcemanager.jar --- |
|
(0034326) shuehner (administrator) 2011-02-22 20:20 |
Tested on pi/pgsql (rev: 811e1c898389) and stable/2.50/oracle (rev: 2938f20924f4). A removed triggers is added to the config.script on export, but a changed trigger (technically a removal/add is not). On a subsequent update.database that trigger is not re-created and if the trigger is really removed from its containing module the planned deletion declared in the config.script is a no-op. -> Closing |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-02-11 18:32 | egoitz | New Issue | |
| 2011-02-11 18:32 | egoitz | Assigned To | => marvintm |
| 2011-02-11 18:32 | egoitz | Modules | => Core |
| 2011-02-11 18:32 | egoitz | Issue Monitored: networkb | |
| 2011-02-14 08:18 | alostale | Status | new => scheduled |
| 2011-02-14 08:18 | alostale | fix_in_branch | => pi |
| 2011-02-14 12:36 | marvintm | Target Version | 2.50MP27 => 2.50MP28 |
| 2011-02-14 12:36 | marvintm | fix_in_branch | pi => |
| 2011-02-22 12:08 | marvintm | Note Added: 0034303 | |
| 2011-02-22 15:06 | hgbot | Checkin | |
| 2011-02-22 15:06 | hgbot | Note Added: 0034313 | |
| 2011-02-22 15:06 | hgbot | Status | scheduled => resolved |
| 2011-02-22 15:06 | hgbot | Resolution | open => fixed |
| 2011-02-22 15:06 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/dbsm-main/rev/7ea6b9f3a4f72a7c66e03d6d9ff854fc206f90d7 [^] |
| 2011-02-22 15:18 | hgbot | Checkin | |
| 2011-02-22 15:18 | hgbot | Note Added: 0034314 | |
| 2011-02-22 15:18 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/dbsm-main/rev/7ea6b9f3a4f72a7c66e03d6d9ff854fc206f90d7 [^] => http://code.openbravo.com/erp/devel/pi/rev/811e1c898389285ce7343588645100609e53aee2 [^] |
| 2011-02-22 18:11 | hgbot | Checkin | |
| 2011-02-22 18:11 | hgbot | Note Added: 0034319 | |
| 2011-02-22 18:13 | hgbot | Checkin | |
| 2011-02-22 18:13 | hgbot | Note Added: 0034320 | |
| 2011-02-22 18:14 | hgbot | Checkin | |
| 2011-02-22 18:14 | hgbot | Note Added: 0034321 | |
| 2011-02-22 20:20 | shuehner | Note Added: 0034326 | |
| 2011-02-22 20:20 | shuehner | Status | resolved => closed |
| 2011-02-23 00:00 | anonymous | sf_bug_id | 0 => 3189587 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |