Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0015542
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2010-12-29 11:172011-03-15 00:00
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiond08bdcb628d6
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0015542: API Change: the script tags in manual windows using the selector have changed

DescriptionIn 3.0 RC4 the way static resources are included in a page have changed: instead of many individual requests, all resources are concatenated (both javascript and stylesheets).
In addition resources only needed for classic windows are not read/included in new user interface pages.

This means that the way resources are read for the selector in classic windows has changed. This is documented here:
http://wiki.openbravo.com/wiki/Projects/Selector/Developers_Manual#Add_script_statements_in_head [^]

This change can be seen as an API change, explicit approval is needed therefore.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0033424)
iciordia (manager)
2010-12-29 12:35

This API change is too risky (would affect several 2.50 modules) so it is rejected. The code should be adapted to support the previous behaviour.

Ismael
(0033426)
hgbot (developer)
2010-12-29 17:01

Repository: erp/devel/pi
Changeset: 322d25f6d91499d893043855a196d27a3a410903
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Dec 29 17:00:56 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/322d25f6d91499d893043855a196d27a3a410903 [^]

Fixes issue 15542: API Change: the script tags in manual windows using the selector have changed

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/index.html
---
(0033427)
hgbot (developer)
2010-12-29 17:06

Repository: erp/devel/pi
Changeset: 340f54dec87ea07a8fd31e5ee70700498e9b224f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Dec 29 17:05:37 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/340f54dec87ea07a8fd31e5ee70700498e9b224f [^]

Fixes issue 15542: API Change: the script tags in manual windows using the selector have changed

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseComponentProvider.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ComponentProvider.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelComponentProvider.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelConstants.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelServlet.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/StaticResourceComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/StyleSheetResourceComponent.java
---
(0033428)
hgbot (developer)
2010-12-29 17:07

Repository: erp/devel/pi
Changeset: d08bdcb628d6fdf188d199d50b293072991aed7c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Dec 29 17:06:52 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d08bdcb628d6fdf188d199d50b293072991aed7c [^]

Fixes issue 15542: API Change: the script tags in manual windows using the selector have changed

---
M modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOpenbravoComponentProvider.java
M modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListComponentProvider.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceComponentProvider.java
M modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorComponentProvider.java
M modules/org.openbravo.userinterface.smartclient/src/org/openbravo/userinterface/smartclient/SmartClientComponentProvider.java
A modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/classic-skin-variable.js
R modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-default-settings.js
---
(0033502)
hudsonbot (developer)
2010-12-31 15:19

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/322d25f6d914 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f27092744645 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
(0033503)
hudsonbot (developer)
2010-12-31 15:19

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/340f54dec87e [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f27092744645 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
(0033504)
hudsonbot (developer)
2010-12-31 15:20

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/d08bdcb628d6 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f27092744645 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
(0034811)
mtaal (manager)
2011-03-14 16:16

Closed

- Issue History
Date Modified Username Field Change
2010-12-29 11:17 mtaal New Issue
2010-12-29 11:17 mtaal Assigned To => iciordia
2010-12-29 11:17 mtaal Modules => Core
2010-12-29 12:35 iciordia Note Added: 0033424
2010-12-29 12:35 iciordia Assigned To iciordia => mtaal
2010-12-29 17:01 hgbot Checkin
2010-12-29 17:01 hgbot Note Added: 0033426
2010-12-29 17:01 hgbot Status new => resolved
2010-12-29 17:01 hgbot Resolution open => fixed
2010-12-29 17:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/322d25f6d91499d893043855a196d27a3a410903 [^]
2010-12-29 17:06 hgbot Checkin
2010-12-29 17:06 hgbot Note Added: 0033427
2010-12-29 17:06 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/322d25f6d91499d893043855a196d27a3a410903 [^] => http://code.openbravo.com/erp/devel/pi/rev/340f54dec87ea07a8fd31e5ee70700498e9b224f [^]
2010-12-29 17:07 hgbot Checkin
2010-12-29 17:07 hgbot Note Added: 0033428
2010-12-29 17:07 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/340f54dec87ea07a8fd31e5ee70700498e9b224f [^] => http://code.openbravo.com/erp/devel/pi/rev/d08bdcb628d6fdf188d199d50b293072991aed7c [^]
2010-12-31 15:19 hudsonbot Checkin
2010-12-31 15:19 hudsonbot Note Added: 0033502
2010-12-31 15:19 hudsonbot Checkin
2010-12-31 15:19 hudsonbot Note Added: 0033503
2010-12-31 15:20 hudsonbot Checkin
2010-12-31 15:20 hudsonbot Note Added: 0033504
2011-03-14 16:16 mtaal Note Added: 0034811
2011-03-14 16:16 mtaal Status resolved => closed
2011-03-15 00:00 anonymous sf_bug_id 0 => 3212137


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker