Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0015321 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2010-11-27 18:12 | 2010-12-16 22:16 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 33fec3e331ef | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0015321: Remove code generated in /* comment */ blocks in all generated servlets | |||||||
| Description | Wad does currently generate a few blocks of unsued (as comment code) into all generated servlets: - commented commandIn("DELETE_RELATION") block -> not used since DataGrid exists - commented function deleteRelation only references in above block - unused SqlMethod deleteTransactional only referenced in above function | |||||||
| Proposed Solution | - remove the unused code While at it: - remove unused constant SUBTABS_COL_SIZE - make to package-local utility functions also private as rest of utility functions per servlet (fine for api as already package local and also erpWindows is excluded from api-check) | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0032897) hgbot (developer) 2010-11-27 18:15 |
Repository: erp/devel/pi Changeset: 33fec3e331ef22cd5781f9d0b1e7429d32ca9d92 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Sat Nov 27 18:14:49 2010 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/33fec3e331ef22cd5781f9d0b1e7429d32ca9d92 [^] Fixed 15321: remove some unused code in all generated servlets Saves around 1mb 132280l srcAD.orig 131092l srcAD --- M src-wad/src/org/openbravo/wad/datasource.xsqlxml M src-wad/src/org/openbravo/wad/javasource.javaxml --- |
|
(0032960) hudsonbot (developer) 2010-11-30 17:52 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/33fec3e331ef [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7c27b4b566df [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19017.obx [^] |
|
(0033128) marvintm (developer) 2010-12-13 15:15 |
Works fine |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-11-27 18:12 | shuehner | New Issue | |
| 2010-11-27 18:12 | shuehner | Assigned To | => shuehner |
| 2010-11-27 18:15 | hgbot | Checkin | |
| 2010-11-27 18:15 | hgbot | Note Added: 0032897 | |
| 2010-11-27 18:15 | hgbot | Status | new => resolved |
| 2010-11-27 18:15 | hgbot | Resolution | open => fixed |
| 2010-11-27 18:15 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/33fec3e331ef22cd5781f9d0b1e7429d32ca9d92 [^] |
| 2010-11-30 17:52 | hudsonbot | Checkin | |
| 2010-11-30 17:52 | hudsonbot | Note Added: 0032960 | |
| 2010-12-13 15:15 | marvintm | Note Added: 0033128 | |
| 2010-12-13 15:15 | marvintm | Status | resolved => closed |
| 2010-12-16 22:16 | anonymous | sf_bug_id | 0 => 3138800 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |