Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0014238

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] 01. General setup

trivial

have not tried

2010-08-18 16:09

2010-09-17 00:00

Reporter

shuehner

View Status

public

Assigned To

dalsasua

Priority

none

Resolution

fixed

Fixed in Version

2.50MP22

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

Merge Request Status

Review Assigned To

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0014238: Trivial cleanup of unneeded code in InitialClientSetup servlet

Description

some mini cleanup of some unnecessary code

Tags

No tags attached.

14238.diff [^] (1,980 bytes) 2010-08-18 16:10 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java b/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java
--- a/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java
+++ b/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java
@@ -40,7 +40,6 @@
 
   private static final Logger log4j = Logger.getLogger(InitialClientSetup.class);
   private static final long serialVersionUID = 1L;
-  private static final String STRMESSAGEOK = "Success";
 
   public void doPost(HttpServletRequest request, HttpServletResponse response)
       throws ServletException, IOException {
@@ -158,8 +157,6 @@
       VariablesSecureApp vars, String strModules, StringBuffer strLog) throws IOException {
 
     log4j.debug("process() - Initial Client Setup Process Start - strModules - " + strModules);
-    OBError obeResult = new OBError();
-    obeResult.setType(STRMESSAGEOK);
 
     String strClientName = vars.getStringParameter("inpClient");
     String strClientUser = vars.getStringParameter("inpClientUser");
@@ -176,10 +173,10 @@
         + strClientUser);
 
     org.openbravo.erpCommon.businessUtility.InitialClientSetup ics = new org.openbravo.erpCommon.businessUtility.InitialClientSetup();
-    obeResult = ics.createClient(vars, strCurrency, strClientName, strClientUser, strPassword,
-        strModules, Utility.messageBD(this, "Account_ID", vars.getLanguage()), Utility.messageBD(
-            this, "C_Calendar_ID", vars.getLanguage()), bCreateAccounting, fileCoAFilePath,
-        bBPartner, bProduct, bProject, bCampaign, bSalesRegion);
+    OBError obeResult = ics.createClient(vars, strCurrency, strClientName, strClientUser,
+        strPassword, strModules, Utility.messageBD(this, "Account_ID", vars.getLanguage()), Utility
+            .messageBD(this, "C_Calendar_ID", vars.getLanguage()), bCreateAccounting,
+        fileCoAFilePath, bBPartner, bProduct, bProject, bCampaign, bSalesRegion);
 
     strLog.append(ics.getLog());

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0030126) shuehner (administrator) 2010-08-18 16:10	The variable obeResult will be overwritten always by the createClient call so no need to set anything to it before.

(0030153) hgbot (developer) 2010-08-19 13:50	Repository: erp/devel/pi Changeset: ca3a6260cdc1760190ec8d0b5393663351f8fdff Author: David Alsasua <david.alsasua <at> openbravo.com> Date: Thu Aug 19 09:47:11 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/ca3a6260cdc1760190ec8d0b5393663351f8fdff [^] Fixes issue 14238 --- M src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java ---

(0030200) hudsonbot (viewer) 2010-08-21 00:06	A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/ca3a6260cdc1 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/eedf97667060 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18194.obx [^]

Issue History
Date Modified	Username	Field	Change
2010-08-18 16:09	shuehner	New Issue
2010-08-18 16:09	shuehner	Assigned To	=> dalsasua
2010-08-18 16:09	shuehner	OBNetwork customer	=> No
2010-08-18 16:10	shuehner	Note Added: 0030126
2010-08-18 16:10	shuehner	File Added: 14238.diff
2010-08-19 13:50	hgbot	Checkin
2010-08-19 13:50	hgbot	Note Added: 0030153
2010-08-19 13:50	hgbot	Status	new => resolved
2010-08-19 13:50	hgbot	Resolution	open => fixed
2010-08-19 13:50	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/ca3a6260cdc1760190ec8d0b5393663351f8fdff [^]
2010-08-21 00:06	hudsonbot	Checkin
2010-08-21 00:06	hudsonbot	Note Added: 0030200
2010-09-16 12:00	psarobe	Status	resolved => closed
2010-09-16 12:00	psarobe	Fixed in Version	=> 2.50MP22
2010-09-17 00:00	anonymous	sf_bug_id	0 => 3068048

Copyright © 2000 - 2009 MantisBT Group