Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0014120 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 00. Application dictionary | major | always | 2010-08-03 17:34 | 2010-09-15 00:00 | |||
| Reporter | iciordia | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | ff4ecf3d8676 | ||||
| Projection | none | ETA | none | Target Version | 2.50MP22 | |||
| OS | Any | Database | Any | Java version | any | |||
| OS Version | any | Database version | any | Ant version | any | |||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0014120: Removed entries from AD_Model_Object make the system to fail | |||||||
| Description | This issue was generated by the fix to issue 12426 in which entries in AD_Model_Object linked to disabled tabs were removied from the system (eg. Product customer tab within Product window). After this fix it is not possible to enable those tabs through a configuration script because the entries in the AD_Model_Object are not regenerated after enabling the tab | |||||||
| Proposed Solution | Best solution is to remove from Openbravo code the AD_Model_Object and AD_Model_Object_Mapping entries automatically generated (so the ones linked to tabs) and read directly from ad_tab instead when generating the web.xml file It would also solve current redundancy in code: all the info in ad_model_object linked to ad_tab is automatically generated so redundant and should not be persisted in openbravo source code | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0029772) iciordia (manager) 2010-08-03 17:45 |
When fixing the issue be aware that there will be Openbravo modules including entries in ad_model_object linked to tabs in the module. It means that there might be for a while useless entries in ad_model_object. So when generating the web.xml file the system will use to subsets: -AD_Model_Object EXCLUDING those linked to tabs (there might be some) -Enabled AD_Tabs There will be a gradual and not mandatory clean-up process in all openbravo modules to remove useless entries in ad_model_object. Module owners should know that this clean-up can not be done in modules that are compatible with MP's previous to MP22 |
|
(0030123) alostale (manager) 2010-08-18 15:29 |
This issue is not going to be fixed by removing ad_model_object entries for generated tabs as this would suppose a api change making modules using that information not compatible with next mp. It will be fixed in this way by 0014236. Current issue will be fixed by reverting the fix for 0012426 related to generated tabs and making WAD not to generate web.xml entries in case the tab or windows is not active. |
|
(0030552) hgbot (developer) 2010-09-01 08:40 |
Repository: erp/devel/pi Changeset: ff4ecf3d867637c0fe39680981bc50ac12f5060c Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Tue Aug 31 11:27:47 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/ff4ecf3d867637c0fe39680981bc50ac12f5060c [^] fixed bug 14120: Roll back model object deletion for wad tabs Rolled back model object deletion for wad tabs performed by fix of issue 12426. Now web.xml file for wad tabs does not take into account active value of model object, but it uses this value from tab and window. So if a tab is inactive its entry is not added in web.xml regardless it is active in model object table. --- M src-db/database/model/triggers/AD_TAB_TRG2.xml M src-db/database/sourcedata/AD_MODEL_OBJECT.xml M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml M src-wad/src/org/openbravo/wad/Wad_data.xsql --- |
|
(0030553) hgbot (developer) 2010-09-01 08:40 |
Repository: erp/devel/pi Changeset: 1d662363a99c25d7af6f5273c96ef38572834285 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Tue Aug 31 13:11:30 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/1d662363a99c25d7af6f5273c96ef38572834285 [^] related to issue 14120: Deleted unneded mapping --- M src-db/database/sourcedata/AD_MODEL_OBJECT.xml M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml --- |
|
(0030710) hudsonbot (developer) 2010-09-07 09:18 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/ff4ecf3d8676 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^] |
|
(0030712) hudsonbot (developer) 2010-09-07 09:18 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/1d662363a99c [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^] |
|
(0031028) marvintm (developer) 2010-09-14 11:29 |
Verified that indeed if a tab is not active, an entry for its class is not added to the web.xml file. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-08-03 17:34 | iciordia | New Issue | |
| 2010-08-03 17:34 | iciordia | Assigned To | => alostale |
| 2010-08-03 17:38 | iciordia | Relationship added | related to 0012426 |
| 2010-08-03 17:45 | alostale | Relationship added | blocks 0014087 |
| 2010-08-03 17:45 | iciordia | Note Added: 0029772 | |
| 2010-08-09 08:03 | alostale | Status | new => scheduled |
| 2010-08-18 15:26 | alostale | Relationship added | depends on 0014236 |
| 2010-08-18 15:29 | alostale | Note Added: 0030123 | |
| 2010-09-01 08:40 | hgbot | Checkin | |
| 2010-09-01 08:40 | hgbot | Note Added: 0030552 | |
| 2010-09-01 08:40 | hgbot | Status | scheduled => resolved |
| 2010-09-01 08:40 | hgbot | Resolution | open => fixed |
| 2010-09-01 08:40 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ff4ecf3d867637c0fe39680981bc50ac12f5060c [^] |
| 2010-09-01 08:40 | hgbot | Checkin | |
| 2010-09-01 08:40 | hgbot | Note Added: 0030553 | |
| 2010-09-07 09:18 | hudsonbot | Checkin | |
| 2010-09-07 09:18 | hudsonbot | Note Added: 0030710 | |
| 2010-09-07 09:18 | hudsonbot | Checkin | |
| 2010-09-07 09:18 | hudsonbot | Note Added: 0030712 | |
| 2010-09-14 11:29 | marvintm | Note Added: 0031028 | |
| 2010-09-14 11:29 | marvintm | Status | resolved => closed |
| 2010-09-15 00:00 | anonymous | sf_bug_id | 0 => 3066284 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |