Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0013924
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2010-07-08 14:052010-07-10 11:23
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision2fbed15478c0
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013924: Problem with preferences having empty value -> Can'T login

DescriptionFollowing situation:

A module ship a row for ad_preferences for setting a startpage with some non-empty value and without any filter on user or role etc...

Now i wanted to create a more specific preference for a specified user 'classic' with an empty value which should have higher priority.

After doing this change i could not change role or login anymore because of some NPE happening.

Error as logged during login process:
930160 [http-8080-6] ERROR org.openbravo.erpCommon.security.Menu - HTTPSecureAppServlet.service() - exception caught:
java.lang.NullPointerException
    at org.openbravo.erpCommon.businessUtility.Preferences.isHigherPriority(Preferences.java:444)
    at org.openbravo.erpCommon.businessUtility.Preferences.getAllPreferences(Preferences.java:74)
    at org.openbravo.base.secureApp.LoginUtils.fillSessionArguments(LoginUtils.java:201)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:311)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
Steps To Reproducei.e. Install new layout modules (navigationbar)
Create a new user called 'classic' assign it i.e. System Administrator role
Create a new preference for entry startpage with no value
which is restricted to Username: 'classic'
Logout
Try to login -> does not work, NPE in the log
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0029164)
hgbot (developer)
2010-07-08 14:43

 Repository: erp/devel/pi
Changeset: 2fbed15478c0439b5b8065e23accfc20c5e2921f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jul 08 14:43:34 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2fbed15478c0439b5b8065e23accfc20c5e2921f [^]

fixed issue 13924: Problem with preferences having empty value

  Prevent NPE when comparing preferences with null value

---
M src/org/openbravo/erpCommon/businessUtility/Preferences.java
---
(0029186)
shuehner (administrator)
2010-07-09 13:32

 Tested working fine now, no NPE anymore and the correct, more strict preference is used.
(0029206)
hudsonbot (viewer)
2010-07-10 11:23

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/2fbed15478c0 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/8cb9c6ccb2e4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17829.obx [^]

- Issue History
Date Modified Username Field Change
2010-07-08 14:05 shuehner New Issue
2010-07-08 14:05 shuehner Assigned To => alostale
2010-07-08 14:05 shuehner OBNetwork customer => No
2010-07-08 14:43 hgbot Checkin
2010-07-08 14:43 hgbot Note Added: 0029164
2010-07-08 14:43 hgbot Status new => resolved
2010-07-08 14:43 hgbot Resolution open => fixed
2010-07-08 14:43 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2fbed15478c0439b5b8065e23accfc20c5e2921f [^]
2010-07-09 13:32 shuehner Note Added: 0029186
2010-07-09 13:32 shuehner Status resolved => closed
2010-07-10 00:00 anonymous sf_bug_id 0 => 3027597
2010-07-10 11:23 hudsonbot Checkin
2010-07-10 11:23 hudsonbot Note Added: 0029206

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker