Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0013849
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] Z. Othersmajorhave not tried2010-06-30 17:302022-02-01 08:09
ReportermtaalView Statuspublic 
Assigned ToTriage Platform Base 
PrioritynormalResolutionout of dateFixed in Version
StatusnewFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50SCM revision 
Review Assigned To
Web browser
ModulesUser Interface Application
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013849: Code in some modules is copied from core, needs to be refactored in core to prevent duplicate code

DescriptionSome modules have code duplicated from core. To prevent this code duplication the code in core needs to be refactored to separate methods which can be called from the modules.

Specifically the following code has to be checked/refactored:
- KernelServlet.logout method and its uses
- AlertActionHandler.execute method
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0028931)
shuehner (administrator)
2010-06-30 17:47

More places to be checked:

UserInfoWidgetAction (.. UserSessionResetter (for i.e. RoleChange))
KernelServlet integration with core HSAS servlet
(0028963)
shuehner (administrator)
2010-07-01 18:50

Also code for getRoles in UserInfoWidgetActionHandler
(0029124)
shuehner (administrator)
2010-07-07 13:31

new code of hearbeat/registration popup is also copied from core file
(0030509)
hgbot (developer)
2010-08-31 09:41

Repository: erp/mods/org.openbravo.client.kernel
Changeset: 55365a0b4d68c9e97f8e7daeb5fd72e371c3d27a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Aug 31 09:40:12 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.kernel/rev/55365a0b4d68c9e97f8e7daeb5fd72e371c3d27a [^]

Renamed AuthenticatingServlet, fixes issue 14376: Move wrapping in contextual seem request from KernelServlet & DatasourceServlet to super class. Related to issue 13849: Code in some modules is copied from core, needs to be refactored in core to prevent duplicate code

---
M src/org/openbravo/client/kernel/KernelServlet.java
A src/org/openbravo/client/kernel/BaseKernelServlet.java
R src/org/openbravo/client/kernel/AuthenticatingServlet.java
---
(0030516)
hgbot (developer)
2010-08-31 10:00

Repository: erp/mods/org.openbravo.client.application
Changeset: 5a2040c640cc40d4715d93898c0e40f581c0b4f9
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Aug 31 10:00:22 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/5a2040c640cc40d4715d93898c0e40f581c0b4f9 [^]

Related to issue 13849: Code in some modules is copied from core, needs to be refactored in core to prevent duplicate code

---
M src/org/openbravo/client/application/LogOutActionHandler.java
---
(0030604)
hgbot (developer)
2010-09-03 14:37

Repository: erp/mods/org.openbravo.client.application-new-activation
Changeset: 5a2040c640cc40d4715d93898c0e40f581c0b4f9
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Aug 31 10:00:22 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application-new-activation/rev/5a2040c640cc40d4715d93898c0e40f581c0b4f9 [^]

Related to issue 13849: Code in some modules is copied from core, needs to be refactored in core to prevent duplicate code

---
M src/org/openbravo/client/application/LogOutActionHandler.java
---

- Issue History
Date Modified Username Field Change
2010-06-30 17:30 mtaal New Issue
2010-06-30 17:30 mtaal Assigned To => mtaal
2010-06-30 17:37 shuehner Issue Monitored: shuehner
2010-06-30 17:47 shuehner Note Added: 0028931
2010-07-01 18:48 shuehner Severity minor => major
2010-07-01 18:50 shuehner Note Added: 0028963
2010-07-07 13:31 shuehner Note Added: 0029124
2010-08-31 09:41 hgbot Checkin
2010-08-31 09:41 hgbot Note Added: 0030509
2010-08-31 10:00 hgbot Checkin
2010-08-31 10:00 hgbot Note Added: 0030516
2010-09-03 14:37 hgbot Checkin
2010-09-03 14:37 hgbot Note Added: 0030604
2010-12-06 07:48 alostale Status new => scheduled
2012-06-15 17:12 alostale Type defect => design defect
2016-10-21 11:00 mtaal Status scheduled => closed
2016-10-21 11:00 mtaal Resolution open => out of date
2016-10-21 13:17 mtaal Tag Attached: MT_closed_out_of_date
2016-10-21 14:08 mtaal Assigned To mtaal => platform
2016-10-21 14:09 mtaal Status closed => new
2016-10-21 14:12 mtaal Tag Detached: MT_closed_out_of_date
2022-02-01 08:09 alostale Assigned To platform => Triage Platform Base


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker