Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0013667
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2010-06-15 19:422010-07-06 00:00
ReportershuehnerView Statuspublic 
Assigned Toiperdomo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision6f09e1d5b161
ProjectionnoneETAnoneTarget Version2.50MP20
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013667: Minor cleanup in /modulescript/HBFix_data.xsql

DescriptionThis xsql file of the HBFix modulescript does define a few xsql-methods which are not used at all by the corresponding java file.

At least:
- updateNotActive
- selectUserId

Please check all those and remove the unused ones.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00136252.50MP19 closediperdomo [HB] When Heartbeat is enabled a process request in Scheduled state must exist 

-  Notes
(0028473)
shuehner (administrator)
2010-06-15 19:44

 When doing this change, please add a small comment to the modulescript java-code explaining what it does (perhaps mention link to corresponding mantis issue).
(0029055)
hgbot (developer)
2010-07-05 13:16

 Repository: erp/devel/pi
Changeset: 6f09e1d5b1617646eda1b30aba3cadf368df112a
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Jul 05 13:15:25 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6f09e1d5b1617646eda1b30aba3cadf368df112a [^]

Fixes issue 13667: Code cleanup. Removed unused methods, class commented

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/HBFix.class
M src-util/modulescript/build/classes/org/openbravo/modulescript/HBFixData.class
M src-util/modulescript/src/org/openbravo/modulescript/HBFix.java
M src-util/modulescript/src/org/openbravo/modulescript/HBFix_data.xsql
---
(0029061)
shuehner (administrator)
2010-07-05 13:54

 Verified, change is only removing unneeded methods (checked via compilation), and adds an explanatory comment to the ModuleScript.
(0029072)
hudsonbot (developer)
2010-07-05 20:41

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/6f09e1d5b161 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/a11139370c90 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17805.obx [^]

- Issue History
Date Modified Username Field Change
2010-06-15 19:42 shuehner New Issue
2010-06-15 19:42 shuehner Assigned To => iperdomo
2010-06-15 19:44 shuehner Note Added: 0028473
2010-06-16 09:42 iperdomo Status new => acknowledged
2010-06-16 09:42 iperdomo Target Version => 2.50MP20
2010-06-16 09:42 iperdomo Status acknowledged => scheduled
2010-06-16 09:42 iperdomo fix_in_branch => pi
2010-06-16 09:59 iperdomo Relationship added related to 0013625
2010-07-05 13:16 hgbot Checkin
2010-07-05 13:16 hgbot Note Added: 0029055
2010-07-05 13:16 hgbot Status scheduled => resolved
2010-07-05 13:16 hgbot Resolution open => fixed
2010-07-05 13:16 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6f09e1d5b1617646eda1b30aba3cadf368df112a [^]
2010-07-05 13:54 shuehner Note Added: 0029061
2010-07-05 13:54 shuehner Status resolved => closed
2010-07-05 20:41 hudsonbot Checkin
2010-07-05 20:41 hudsonbot Note Added: 0029072
2010-07-06 00:00 anonymous sf_bug_id 0 => 3025608

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker