0013653: Multiple issues in selectors introduced by PagedDatagrid project

Description

This issue collects multiple problem most likely introduced by copy'n'paste in the Paged-Datagrid project.

Some or style issues only (no functional impact), other are defects

All are about naming of the session variable used to store the 'currentPage' (backendPage) variable which is used to track the current backend page (a page is 10k records by default).

List created with:
src/org/openbravo/erpCommon/info$ grep -Ir currentPage . | less

Style issues means:
'Wrong' name if session-variable (not matching selector name) but not functional impact

Defect means:
Multiple uses of different names in the same selector -> must use same name (when fixing also check for style issue together with those)

Style issues:
./ProductComplete.java: page = TableSQLData.calcAndGetBackendPage(vars, "ProjectData.currentPage");
./Account.java: page = TableSQLData.calcAndGetBackendPage(vars, "DebtPaymentInfo.currentPage");
./AccountElementValue.java: page = TableSQLData.calcAndGetBackendPage(vars, "ShipmentReceiptLine.currentPage");
./BusinessPartner.java: page = TableSQLData.calcAndGetBackendPage(vars, "DebtPaymentInfo.currentPage");

Defects:
./ProductMultiple.java: page = TableSQLData.calcAndGetBackendPage(vars, "ProjectData.currentPage");
./ProductMultiple.java: String strPage = vars.getSessionValue("ProductMultiple|currentPage", "0");
./ProjectMultiple.java: page = TableSQLData.calcAndGetBackendPage(vars, "BusinessPartnerData.currentPage");
./ProjectMultiple.java: String strPage = vars.getSessionValue("ProductMultiple|currentPage", "0");
./BusinessPartnerMultiple.java: page = TableSQLData.calcAndGetBackendPage(vars, "BusinessPartnerData.currentPage");
./BusinessPartnerMultiple.java: String strPage = vars.getSessionValue("ProductMultiple|currentPage", "0");

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0042307) dmitry_mezentsev (developer) 2011-10-28 20:17	Openbravo provides community support only for the latest Openbravo version, which is Openbravo 3. This version has significantly improved UI and this issue is not present there. Upgrade path from Openbravo 2.50 to latest Openbravo version is available so we recommend to upgrade your instance to get this issue fixed. Life cycle guarantee (backporting bug fixes to the previos to latest releases (Openbravo 2.40, 2.50)) is available for Professional Edition subscribers only. Please register your ticket through Openbravo Support Portal (http://support.openbravo.com/ [^]) if you have valid Professional subscription. You can find more details about our Support policy in the following blog post http://paolojuvara.blogspot.com/2009/12/maintenance-policy-for-openbravo-250.html [^]

Issue History
Date Modified	Username	Field	Change
2010-06-14 19:03	shuehner	New Issue
2010-06-14 19:03	shuehner	Assigned To	=> adrianromero
2011-06-03 10:59	dalsasua	Assigned To	adrianromero => dalsasua
2011-07-20 18:12	dalsasua	Assigned To	dalsasua => jonalegriaesarte
2011-10-28 20:17	dmitry_mezentsev	Note Added: 0042307
2011-10-28 20:17	dmitry_mezentsev	Status	new => closed
2011-10-28 20:17	dmitry_mezentsev	Resolution	open => out of date
2011-10-28 20:17	dmitry_mezentsev	Fixed in Version	=> pi