Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0013136 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2010-04-27 15:01 | 2010-05-15 00:00 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | pi | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d61ce2cd2892 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0013136: OBContext.getLanguage does only use users' default language, and does not honor language change in the role change popup | |||||||
| Description | the OBContext code for getLanguage does only read the language from the users default language setting. However imo it should use the currently active ui language used by the user (which can be changed for this session in the role switch popup). | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0026723) shuehner (administrator) 2010-04-27 15:16 |
When doing this change, please add javadoc to getLanguage method, explaining what value the method returns (i.e. currently selected ui language) |
|
(0026735) hgbot (developer) 2010-04-27 22:32 |
Repository: erp/devel/pi Changeset: d61ce2cd289253212f817a70cc3eb57e103efbce Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue Apr 27 22:32:28 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/d61ce2cd289253212f817a70cc3eb57e103efbce [^] fixes issue 13135: OBContext.getLanguage() returns 'wrong' language, if user does not have a default language set fixes issue 13136: OBContext.getLanguage does only use users' default language, and does not honor language change in the role change popup --- M src-test/org/openbravo/test/dal/IssuesTest.java M src/org/openbravo/base/secureApp/LoginUtils.java M src/org/openbravo/dal/core/OBContext.java --- |
|
(0027237) shuehner (administrator) 2010-05-14 12:20 |
Tested in pi/pgsql, rev: da4cfb0dabc7. Code-change reviewed, now using language from Sesson set on login & role-switches first, then falls back to user default-language or system-client-default language. Tested using 'Audit Trail' popup as its translation of labels inside the grid is using the ObContext.getLanguage to retrieve the language to use. -> Working fine as the labels in the rows of that popup now change their translation properly if the ui language is changed by using the 'role switch popup' |
|
(0027305) hudsonbot (developer) 2010-05-14 15:28 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/d61ce2cd2892 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/36f76c8d7193 [^] Tests: http://builds.openbravo.com/view/devel-int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17198.obx [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-04-27 15:01 | shuehner | New Issue | |
| 2010-04-27 15:01 | shuehner | Assigned To | => mtaal |
| 2010-04-27 15:16 | shuehner | Note Added: 0026723 | |
| 2010-04-27 22:32 | hgbot | Checkin | |
| 2010-04-27 22:32 | hgbot | Note Added: 0026735 | |
| 2010-04-27 22:32 | hgbot | Status | new => resolved |
| 2010-04-27 22:32 | hgbot | Resolution | open => fixed |
| 2010-04-27 22:32 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d61ce2cd289253212f817a70cc3eb57e103efbce [^] |
| 2010-05-14 12:20 | shuehner | Note Added: 0027237 | |
| 2010-05-14 12:20 | shuehner | Status | resolved => closed |
| 2010-05-14 12:20 | shuehner | Fixed in Version | => pi |
| 2010-05-14 15:28 | hudsonbot | Checkin | |
| 2010-05-14 15:28 | hudsonbot | Note Added: 0027305 | |
| 2010-05-15 00:00 | anonymous | sf_bug_id | 0 => 3001857 |
| 2012-04-03 08:57 | VictorVillar | Relationship added | related to 0020191 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |