Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0013135
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2010-04-27 14:592010-05-15 00:00
ReportershuehnerView Statuspublic 
Assigned Tomtaal 
PriorityurgentResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revisiond61ce2cd2892
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013135: OBContext.getLanguage() returns 'wrong' language, if user does not have a default language set

DescriptionWith two system languages active (en_US + es_ES) the getLanguage() call did return es_ES as a language, even if no user had set his language to es_ES.

Caused by getLanguage fallback code not using the system-client language in case no user-default language is set.
Steps To Reproducesee steps to reproduce in issue 12768
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0012768 closedshuehner Data audit window shows record changes in the wrong language 

-  Notes
(0026734)
hgbot (developer)
2010-04-27 22:32

Repository: erp/devel/pi
Changeset: d61ce2cd289253212f817a70cc3eb57e103efbce
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Apr 27 22:32:28 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d61ce2cd289253212f817a70cc3eb57e103efbce [^]

fixes issue 13135: OBContext.getLanguage() returns 'wrong' language, if user does not have a default language set
fixes issue 13136: OBContext.getLanguage does only use users' default language, and does not honor language change in the role change popup

---
M src-test/org/openbravo/test/dal/IssuesTest.java
M src/org/openbravo/base/secureApp/LoginUtils.java
M src/org/openbravo/dal/core/OBContext.java
---
(0027236)
shuehner (administrator)
2010-05-14 12:16

Tested in pi/pgsql, rev: da4cfb0dabc7. Code-change reviewed, now using the system client language instead of the old fallback code. Tested using 'Audit Trail' popup as its translation of labels inside the grid is using the ObContext.getLanguage to retrieve the language to use. -> Working fine.
(0027304)
hudsonbot (developer)
2010-05-14 15:28

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/d61ce2cd2892 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/36f76c8d7193 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17198.obx [^]

- Issue History
Date Modified Username Field Change
2010-04-27 14:59 shuehner New Issue
2010-04-27 14:59 shuehner Assigned To => mtaal
2010-04-27 14:59 shuehner Relationship added blocks 0012768
2010-04-27 22:32 hgbot Checkin
2010-04-27 22:32 hgbot Note Added: 0026734
2010-04-27 22:32 hgbot Status new => resolved
2010-04-27 22:32 hgbot Resolution open => fixed
2010-04-27 22:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d61ce2cd289253212f817a70cc3eb57e103efbce [^]
2010-05-14 12:16 shuehner Note Added: 0027236
2010-05-14 12:16 shuehner Status resolved => closed
2010-05-14 12:16 shuehner Fixed in Version => pi
2010-05-14 15:28 hudsonbot Checkin
2010-05-14 15:28 hudsonbot Note Added: 0027304
2010-05-15 00:00 anonymous sf_bug_id 0 => 3001856


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker