Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0012788
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajorhave not tried2010-03-24 11:152010-05-18 12:12
ReporterarunkumarView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision91ef4d9b3994
ProjectionnoneETAnoneTarget Version2.50MP17
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP9SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0012788: Precision error in simple sales order

DescriptionPrecision error in simple sales order.Configure the Format.xml to 4 decimal places and configure the Price precision as 4 in general setup -> Application -> currency.If the product price has four decimal places for example 5.6748 then while selecting the product in simple sales order and changing the quantity to 2 then the price is rounded off to 5.6750.
Steps To ReproducePrerequisite:

Format.xml -> priceRelation and priceEdition are set as 0.0000

General Setup -> Application -> currency. For Euro Standard precision=2,
Price precision=4, Costing precision=2

Create a business partner CUSTOMER A.

Pricelist -> Create a pricelist CUSTOMER A - product : A Final Goods

List price = Standard Price = Price Limit = 6.7849 for the product.

Steps to reproduce the issue:

** Go to Sales Management || Transactions || Simple Sales Order || Header
** Create a new record and select the business partner CUSTOMER A which has
the Price List "CUSTOMER A"
** Go to lines and select the product A Final Goods. If the ordered quantity
is 1 then the net unit price is set as 6.7849. But if I change the
quantity to 2 then the net unit price changes to 6.7850.

Proposed SolutionSince the Format.xml and Price precision are configured to hold 4 decimal places rounding off should not be done here.
TagsRegression
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
duplicate of defect 00128322.50MP17 closedalostale Precision error in sales invoice 
has duplicate defect 0012844 closedalostale Price precision error in purchase invoice 

-  Notes
(0025700)
arunkumar (reporter)
2010-03-24 13:07

The same type of issue happens in sales invoice also
(0025720)
hgbot (developer)
2010-03-25 09:57

Repository: erp/devel/pi
Changeset: 91ef4d9b399418face9ad7ac66c275c5e9e26692
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Mar 25 10:05:44 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/91ef4d9b399418face9ad7ac66c275c5e9e26692 [^]

Fixes issue 0012788: Precision error in simple sales order & sales invoice

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java
---
(0025721)
adrianromero (manager)
2010-03-25 09:59

To test the issue, just follow the reproduction steps and notice that when you assign select the product and when you change the quantity, the price remains 6.7849 and does not change to 6.7850
(0025768)
arunkumar (reporter)
2010-03-29 11:24

I have tested the fix in simple sales order. The net unit price is not rounded off to three decimal places.It was working fine.

But still while testing the sales invoice I can see when the invoiced quantity changes, the net unit price is changed from 6.7849 to 6.7850
(0025799)
hgbot (developer)
2010-03-30 10:52

Repository: erp/devel/pi
Changeset: ac0d4f5ea8309dac1bcea2d3ddc769522f1c6367
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Mar 30 11:01:49 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ac0d4f5ea8309dac1bcea2d3ddc769522f1c6367 [^]

Reverting changes in issue 0012788: Precision error in simple sales order sales invoice

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java
---
(0026231)
iperdomo (reporter)
2010-04-15 10:30

Tested on PI @ rev 7076c219cdd9

Unquoted amounts when returning values in callout response.
(0026387)
hudsonbot (developer)
2010-04-19 21:11

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/91ef4d9b3994 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]
(0026398)
hudsonbot (developer)
2010-04-19 21:11

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/ac0d4f5ea830 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]

- Issue History
Date Modified Username Field Change
2010-03-24 11:15 arunkumar New Issue
2010-03-24 11:15 arunkumar Assigned To => adrianromero
2010-03-24 11:15 arunkumar Status new => scheduled
2010-03-24 11:15 arunkumar fix_in_branch => pi
2010-03-24 13:07 arunkumar Note Added: 0025700
2010-03-24 13:07 arunkumar fix_in_branch pi =>
2010-03-24 13:07 arunkumar Summary Precision error in simple sales order => Precision error in simple sales order & sales invoice
2010-03-25 09:57 hgbot Checkin
2010-03-25 09:57 hgbot Note Added: 0025720
2010-03-25 09:57 hgbot Status scheduled => resolved
2010-03-25 09:57 hgbot Resolution open => fixed
2010-03-25 09:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/91ef4d9b399418face9ad7ac66c275c5e9e26692 [^]
2010-03-25 09:59 adrianromero Note Added: 0025721
2010-03-29 11:24 arunkumar Note Added: 0025768
2010-03-29 11:24 arunkumar Status resolved => new
2010-03-29 11:24 arunkumar Resolution fixed => open
2010-03-29 11:24 arunkumar Status new => scheduled
2010-03-29 11:24 arunkumar fix_in_branch => pi
2010-03-29 11:40 arunkumar Status scheduled => closed
2010-03-29 11:40 arunkumar Resolution open => fixed
2010-03-29 13:19 adrianromero Relationship added related to 0012832
2010-03-29 18:57 sureshbabu Relationship added blocks 0012844
2010-03-30 00:00 anonymous sf_bug_id 0 => 2978875
2010-03-30 10:52 hgbot Checkin
2010-03-30 10:52 hgbot Note Added: 0025799
2010-03-30 10:59 adrianromero Assigned To adrianromero => alostale
2010-03-30 10:59 adrianromero Priority immediate => urgent
2010-03-30 10:59 adrianromero Status closed => new
2010-03-30 10:59 adrianromero Target Version => 2.50MP15
2010-03-30 10:59 adrianromero fix_in_branch pi =>
2010-03-30 11:11 adrianromero Relationship replaced has duplicate 0012832
2010-03-30 11:13 adrianromero Relationship replaced has duplicate 0012844
2010-03-31 11:40 psarobe Status new => scheduled
2010-03-31 11:40 psarobe fix_in_branch => pi
2010-04-06 12:41 psarobe fix_in_branch pi =>
2010-04-06 12:41 psarobe Summary Precision error in simple sales order & sales invoice => Precision error in simple sales order
2010-04-06 15:29 psarobe version main => 2.50MP1
2010-04-06 15:30 psarobe Tag Attached: Regression
2010-04-06 17:26 alostale Relationship replaced duplicate of 0012832
2010-04-06 17:26 alostale Status scheduled => closed
2010-04-06 17:26 alostale Resolution fixed => duplicate
2010-04-07 12:30 psarobe Status closed => new
2010-04-07 12:30 psarobe Resolution duplicate => open
2010-04-07 12:31 psarobe Status new => scheduled
2010-04-07 12:31 psarobe fix_in_branch => pi
2010-04-07 12:31 psarobe Status scheduled => resolved
2010-04-07 12:31 psarobe Resolution open => fixed
2010-04-07 12:31 psarobe version 2.50MP1 => 2.50MP9
2010-04-07 12:31 psarobe fix_in_branch pi =>
2010-04-15 10:30 iperdomo Note Added: 0026231
2010-04-15 10:30 iperdomo Status resolved => closed
2010-04-19 21:11 hudsonbot Checkin
2010-04-19 21:11 hudsonbot Note Added: 0026387
2010-04-19 21:11 hudsonbot Checkin
2010-04-19 21:11 hudsonbot Note Added: 0026398
2010-05-18 12:12 gorka_gil Target Version 2.50MP15 => 2.50MP17


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker