Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0012223
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Otherscriticalhave not tried2010-02-11 10:102010-03-10 18:29
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision4115163d25d6
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0012223: api check build 287 fails - part1

Descriptionhttp://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/287/console [^]

problem is:
 [checkAPI] +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] Errors in API model validation
 [checkAPI] +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] Check Constraint addition: table: M_ATTRIBUTESET - Constraint: M_ATTRIBUTESET_ISATSETVAL_CHK
 [checkAPI] Check Constraint addition: table: M_PRODUCT - Constraint: M_PRODUCT_ATSETVALTYPE_CHK
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0012224 closedmarvintm api check build 287 fails - part2 

-  Notes
(0024150)
shuehner (administrator)
2010-02-11 10:10

first one looks like constraint is for a new column so should not be an issues for upgrades, second one is a changed constraint definition.
(0024152)
rafaroda (developer)
2010-02-11 10:28

Both are related to the Attribute Set Instance Review project http://wiki.openbravo.com/wiki/Projects/Attribute_set_instance_review [^]

Both are check constraints added to new created columns http://wiki.openbravo.com/wiki/Projects/Attribute_set_instance_review#Technical_Documentation [^]

1) New column ISONEATTRSETVALREQUIRED for table M_ATTRIBUTESET with new check constraint M_ATTRIBUTESET_ISATSETVAL_CHK

2) New column ATTRSETVALUETYPE for table M_PRODUCT with new check constraint M_PRODUCT_ATSETVALTYPE_CHK
(0024164)
pjuvara (reporter)
2010-02-11 13:19

Rafa,

can you please add your assessment on the risk of this change and your recommendation?

Thanks,

Paolo
(0024173)
rafaroda (developer)
2010-02-11 15:20

1) ISONEATTRSETVALREQUIRED is a new column in M_ATTRIBUTESET table and M_ATTRIBUTESET_ISATSETVAL_CHK is a new check constraint that only affects this column: risk zero.

2) ATTRSETVALUETYPE is a new column in M_PRODUCT table and M_PRODUCT_ATSETVALTYPE_CHK is a new check constraint that affects both this column and an existing one (M_ATTRIBUTESETINSTANCE_ID): risk low. The risk is low since an onCreateDefault value has been added in order that the check constraint is complied https://code.openbravo.com/erp/devel/pi/file/tip/src-db/database/model/tables/M_PRODUCT.xml#l280 [^]
(0024196)
pjuvara (reporter)
2010-02-12 10:28

Accepted. Please send notifications with risk level low.
(0024223)
hgbot (developer)
2010-02-14 14:37

Repository: erp/devel/api-checks
Changeset: 4115163d25d6018ed95b5d5610651cc5728e7687
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Feb 14 14:37:56 2010 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/4115163d25d6018ed95b5d5610651cc5728e7687 [^]

Fixed 12223: accept change

---
M model/model/tables/M_ATTRIBUTESET.xml
M model/model/tables/M_PRODUCT.xml
---

- Issue History
Date Modified Username Field Change
2010-02-11 10:10 shuehner New Issue
2010-02-11 10:10 shuehner Assigned To => rafaroda
2010-02-11 10:10 shuehner Note Added: 0024150
2010-02-11 10:28 rafaroda Note Added: 0024152
2010-02-11 10:28 rafaroda Assigned To rafaroda => pjuvara
2010-02-11 10:28 rafaroda Status new => scheduled
2010-02-11 11:17 rafaroda Issue Monitored: rafaroda
2010-02-11 12:01 rafaroda Relationship added related to 0012224
2010-02-11 13:19 pjuvara Note Added: 0024164
2010-02-11 15:20 rafaroda Note Added: 0024173
2010-02-12 10:28 pjuvara Assigned To pjuvara => rafaroda
2010-02-12 10:28 pjuvara Note Added: 0024196
2010-02-13 13:48 iciordia Assigned To rafaroda => shuehner
2010-02-14 14:37 hgbot Checkin
2010-02-14 14:37 hgbot Note Added: 0024223
2010-02-14 14:37 hgbot Status scheduled => resolved
2010-02-14 14:37 hgbot Resolution open => fixed
2010-02-14 14:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/4115163d25d6018ed95b5d5610651cc5728e7687 [^]
2010-02-14 15:53 shuehner Status resolved => closed
2010-02-15 00:00 anonymous sf_bug_id 0 =>
2010-03-10 18:29 anonymous sf_bug_id => 2968048


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker