Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0010797
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 00. Application dictionaryminoralways2009-09-28 21:252012-04-28 02:31
ReportericiordiaView Statuspublic 
Assigned Tonaiaramartinez 
PrioritynormalResolutionfixedFixed in Version3.0MP12
StatusclosedFix in branchpiFixed in SCM revisionabbf0e7f2325
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_11
OS VersionrPath LinuxDatabase version8.3.5Ant version1.7.1
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0010797: Product window is not checked as "Sales transaction" in AD

DescriptionProduct window is not checked as "Sales transaction" in AD. As a result, fields in that window are not synchronized from element.name but from element.PO name

A window should be defined as "Sales transaction" by default. Only in case that window uses tables that are shared between sales and purchase transactions (c_order, m_inout, c_invoice) then it should be declared as not "Sales transaction", this way those fields will get its name, help and description from po name, po help and po description in ad_element.

Review all windows declared as not "Sales transaction" (eg. Price List has the same problem) and change to 'Y' when appropiate.

Additionally, "Sales transaction" is a poor/misleading label. Rename it as "Common/sales transaction" (it would be better to change the semantic of that column so it is called "Purchase transaction", but it can not be done within 2.50 release because of API stability).
Proposed SolutionAD_Window.isSoTRX is also used by business partner selector so by default it filters by vendors. It should be refactored in 3.0. In 2.50 the proposed solution is to use PO name, PO description and PO help instead
TagsOB3-Reviewed, VMA-Reviewed
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00206423.0MP12 closednaiaramartinez Business partner selector in Purchasing tab of Product window shows Customers by default 

-  Notes
(0047908)
naiaramartinez (developer)
2012-04-24 13:10

 Test Plan:
  Go to the database and execute the following SQL query:
    SELECT * FROM AD_WINDOW WHERE ISSOTRX='N'

  Notice that result is showing windows that they need to be issotrx='n'.
(0048016)
hgbot (developer)
2012-04-26 12:45

 Repository: erp/devel/pi
Changeset: abbf0e7f2325440d3e3d391f3ca1e82ef3a0fe2c
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Thu Apr 26 11:24:42 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/abbf0e7f2325440d3e3d391f3ca1e82ef3a0fe2c [^]

fixed bug 10797 Set sales transaction ='Y' in windows when appropiate

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_WINDOW.xml
M modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_WINDOW.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_WINDOW.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_WINDOW.xml
---
(0048023)
mirurita (developer)
2012-04-26 12:53

 code review + testing OK

The following windows has been set as Sales Transaction = 'Y'
- Organization Type
- Product
- Price List
- Bank
- Datasource
- Data File Type
- Work Center
- Template
- Open/Close Period Control
- Window Personalization

Elements are synchronized using 'Sales' element information.
(0048157)
hudsonbot (developer)
2012-04-28 02:31

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cd923b317af4 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2009-09-28 21:25 iciordia New Issue
2009-09-28 21:25 iciordia Assigned To => rafaroda
2009-09-29 22:41 psarobe Status new => scheduled
2009-09-29 22:41 psarobe fix_in_branch => pi
2010-02-11 18:05 rafaroda Assigned To rafaroda => adrianromero
2011-06-03 11:00 dalsasua Assigned To adrianromero => dalsasua
2011-07-20 18:11 dalsasua Assigned To dalsasua => jonalegriaesarte
2011-11-24 15:52 jonalegriaesarte Tag Attached: OB3-Reviewed
2012-02-15 19:03 iciordia Assigned To jonalegriaesarte => vmromanos
2012-02-16 18:14 vmromanos Tag Attached: VMA-Reviewed
2012-04-24 09:48 naiaramartinez Assigned To vmromanos => naiaramartinez
2012-04-24 13:10 naiaramartinez Note Added: 0047908
2012-04-26 12:45 hgbot Checkin
2012-04-26 12:45 hgbot Note Added: 0048016
2012-04-26 12:45 hgbot Status scheduled => resolved
2012-04-26 12:45 hgbot Resolution open => fixed
2012-04-26 12:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/abbf0e7f2325440d3e3d391f3ca1e82ef3a0fe2c [^]
2012-04-26 12:53 mirurita Note Added: 0048023
2012-04-26 12:53 mirurita Status resolved => closed
2012-04-26 12:53 mirurita Fixed in Version => 3.0MP12
2012-04-28 02:31 hudsonbot Checkin
2012-04-28 02:31 hudsonbot Note Added: 0048157
2012-05-30 14:07 ngarcia Relationship added related to 0020642

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker