0010685: Create File in Remittance, does not check if BP bank account has 20 numbers.

(0020250)
rafaroda (developer)
2009-09-22 06:56

David,

Can you please comment on this issue and the proposed solution?

Thanks.

(0020345)
dalsasua (reporter)
2009-09-24 16:50

Converting to feature request.

Bank Account Number length is not standard (20 digits) along all different bank systems, so this check cannot be added nor in the bank window, nor in the servlet that creates the remittances.

This functionality will be implemented in the module bank id validation, that will be part of the Spanish Localization Pack. Expected release date October 2009.

Regards.

(0020350)
rafaroda (developer)
2009-09-25 07:05

Target Version removed since it will be addressed in the Spanish Localization Pack.

(0020653)
networkb (developer)
2009-10-02 09:49

I do not agree with the proposed solution.

If 20 digits is not a standard, I agree to not include a restriction in the tab. However, the .dat generated by the Application is not correct because is only valid for Spain (its generation uses Spanish rules) because it is not checked business partner bank account.

(0020831)
networkb (developer)
2009-10-07 12:26

Any update on this?

(0021198)
dalsasua (reporter)
2009-10-20 10:25

I think you didn't understand the discussion: in 2.40 is going to be added a check when generating the file, and a backport has been created by QA in order to track this. In 2.50 no action will be taken, as Spanish Localization Pack includes a callout that checks the correct length and digit control of the Spanish bank accounts. No more action is planned for 2.50, so this issue will be closed as soon as bank account validation module is published.

(0021200)
networkb (developer)
2009-10-20 10:33

Thanks for the explanation. However, for each issue that OBPS report, target version must be set in the defect, not in the backport. We know that this is something that is going to be implemented in 2.40, but we have to fill in the defect (like product version) in which version must be fixed.

Thanks

(0021503)
vmromanos (manager)
2009-11-02 13:49

The Spanish Bank Account Validation is already available at the Central Repository and at the forge's project http://forge.openbravo.com/projects/spanishbankacctvalidation [^]

(0021714)
sureshbabu (reporter)
2009-11-11 11:16

As per victor comments i am closing this issue, since no action is need for PI(250) and fix is applied only in Backport(240)

Issue History
Date Modified	Username	Field	Change
2009-09-21 16:09	networkb	New Issue
2009-09-21 16:09	networkb	Assigned To	=> rafaroda
2009-09-22 06:56	rafaroda	Note Added: 0020250
2009-09-22 06:56	rafaroda	Assigned To	rafaroda => dalsasua
2009-09-24 16:50	dalsasua	Note Added: 0020345
2009-09-24 16:50	dalsasua	Status	new => scheduled
2009-09-24 16:50	dalsasua	Type	defect => feature request
2009-09-25 07:05	rafaroda	Note Added: 0020350
2009-09-25 07:05	rafaroda	Priority	immediate => high
2009-09-25 07:05	rafaroda	Target Version	2.40MP10 =>
2009-10-02 09:49	networkb	Note Added: 0020653
2009-10-07 12:26	networkb	Note Added: 0020831
2009-10-20 09:16	psarobe	Type	feature request => defect
2009-10-20 09:18	psarobe	Status	scheduled => feedback
2009-10-20 09:19	psarobe	Status	feedback => scheduled
2009-10-20 09:19	psarobe	fix_in_branch	=> pi
2009-10-20 09:56	networkb	Target Version	=> 2.40MP11
2009-10-20 09:56	networkb	fix_in_branch	pi =>
2009-10-20 10:25	dalsasua	Note Added: 0021198
2009-10-20 10:33	networkb	Note Added: 0021200
2009-11-02 11:35	vmromanos	Assigned To	dalsasua => vmromanos
2009-11-02 13:49	vmromanos	Status	scheduled => resolved
2009-11-02 13:49	vmromanos	Fixed in SCM revision	=> NA
2009-11-02 13:49	vmromanos	Resolution	open => fixed
2009-11-02 13:49	vmromanos	Note Added: 0021503
2009-11-11 11:16	sureshbabu	Status	resolved => closed
2009-11-11 11:16	sureshbabu	Note Added: 0021714
2009-11-11 11:16	sureshbabu	Fixed in Version	=> 2.50MP9
2009-11-12 00:00	anonymous	sf_bug_id	0 => 2896286

Notes
(0020250) rafaroda (developer) 2009-09-22 06:56	David, Can you please comment on this issue and the proposed solution? Thanks.

(0020345) dalsasua (reporter) 2009-09-24 16:50	Converting to feature request. Bank Account Number length is not standard (20 digits) along all different bank systems, so this check cannot be added nor in the bank window, nor in the servlet that creates the remittances. This functionality will be implemented in the module bank id validation, that will be part of the Spanish Localization Pack. Expected release date October 2009. Regards.

(0020350) rafaroda (developer) 2009-09-25 07:05	Target Version removed since it will be addressed in the Spanish Localization Pack.

(0020653) networkb (developer) 2009-10-02 09:49	I do not agree with the proposed solution. If 20 digits is not a standard, I agree to not include a restriction in the tab. However, the .dat generated by the Application is not correct because is only valid for Spain (its generation uses Spanish rules) because it is not checked business partner bank account.

(0020831) networkb (developer) 2009-10-07 12:26	Any update on this?

(0021198) dalsasua (reporter) 2009-10-20 10:25	I think you didn't understand the discussion: in 2.40 is going to be added a check when generating the file, and a backport has been created by QA in order to track this. In 2.50 no action will be taken, as Spanish Localization Pack includes a callout that checks the correct length and digit control of the Spanish bank accounts. No more action is planned for 2.50, so this issue will be closed as soon as bank account validation module is published.

(0021200) networkb (developer) 2009-10-20 10:33	Thanks for the explanation. However, for each issue that OBPS report, target version must be set in the defect, not in the backport. We know that this is something that is going to be implemented in 2.40, but we have to fill in the defect (like product version) in which version must be fixed. Thanks

(0021503) vmromanos (manager) 2009-11-02 13:49	The Spanish Bank Account Validation is already available at the Central Repository and at the forge's project http://forge.openbravo.com/projects/spanishbankacctvalidation [^]

(0021714) sureshbabu (reporter) 2009-11-11 11:16	As per victor comments i am closing this issue, since no action is need for PI(250) and fix is applied only in Backport(240)