Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0010428
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2009-08-28 17:482009-10-16 00:00
ReporteriperdomoView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Versionpi
StatusclosedFix in branchpiFixed in SCM revisionf2c6cb563ee0
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_13
OS Version2.6.28-gentoo-r5Database version8.3.7Ant version1.7.1
Product Version2.50MP3SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0010428: Create columns from DB process should check that the common columns are present

DescriptionIf you read the DB concepts chapter [1] you'll see that there are commons columns required on each table in Openbravo.

You can create a table without those columns in the database and register it in the Application Dictionary. When you try to use that table you'll get strange compilation behavior.

[1] http://wiki.openbravo.com/wiki/ERP/2.50/Developers_Guide/Concepts/DB/Tables#Common_Columns [^]
Steps To Reproduce* Create a table with just 2 fields. e.g.
- Table name: test
 - Column name: test_id
 - Column name: field 1
* Go to register the table in the Application Dictionary using the 'Create columns from DB' process
* You get the 2 colums
* Try to create a Window and Tab with this table
* Compile the newly created window
Proposed SolutionThe 'Create columns from DB' must fail if the common columns are not present in the newly created table.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0009779 closedalostale Create columns from DB bugs 

-  Notes
(0020880)
iperdomo (reporter)
2009-10-08 16:01

The fix of the related issue does not fix this defect.

The process must fail if one of the *required common columns* are not present. The changeset associated with the other issue is just about DATE and TIMESTAMP support.

Iván
(0020881)
psarobe (manager)
2009-10-08 16:22

QA will pass this defect as resolved if the message is good enough for the person who is going to read it.
The message should say not only that the process has failed but why and what to do
(0020884)
hgbot (developer)
2009-10-08 17:34

Repository: erp/devel/pi
Changeset: f2c6cb563ee0fff4bfaefb2f19417d629222388e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Oct 08 17:34:22 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f2c6cb563ee0fff4bfaefb2f19417d629222388e [^]

fixed bug 0010428: Create columns from DB process should check that the common columns are present

---
M src-db/database/model/functions/AD_TABLE_IMPORT.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0021089)
iperdomo (reporter)
2009-10-15 19:13

@psarobe:
The message says why. I think this message is clear enough to know 'what' to do.
eg.
      
Error:
The following mandatory columns are missing for this table:
-primary key column named: obcheck_issue_ID
-common column: UpdatedBy
-common column: Updated
-common column: CreatedBy
-common column: Created
-common column: IsActive
-common column: AD_Org_ID
-common column: AD_Client_ID
Created = 2
(0021091)
iperdomo (reporter)
2009-10-15 19:14

Checked @ rev 419cc2bd51fa

- Issue History
Date Modified Username Field Change
2009-08-28 17:48 iperdomo New Issue
2009-08-28 17:48 iperdomo Assigned To => rafaroda
2009-08-31 08:15 rafaroda Assigned To rafaroda => alostale
2009-08-31 08:15 rafaroda Priority normal => urgent
2009-08-31 08:15 rafaroda Status new => scheduled
2009-10-06 09:37 alostale Relationship added related to 0009779
2009-10-07 08:19 alostale Status scheduled => resolved
2009-10-07 08:19 alostale Fixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/b68a7df30dce [^]
2009-10-07 08:19 alostale Resolution open => fixed
2009-10-08 16:01 iperdomo Status resolved => new
2009-10-08 16:01 iperdomo Resolution fixed => open
2009-10-08 16:01 iperdomo Note Added: 0020880
2009-10-08 16:22 psarobe Note Added: 0020881
2009-10-08 16:23 psarobe Status new => scheduled
2009-10-08 16:23 psarobe fix_in_branch => pi
2009-10-08 17:34 hgbot Checkin
2009-10-08 17:34 hgbot Note Added: 0020884
2009-10-08 17:34 hgbot Status scheduled => resolved
2009-10-08 17:34 hgbot Resolution open => fixed
2009-10-08 17:34 hgbot Fixed in SCM revision https://code.openbravo.com/erp/devel/pi/rev/b68a7df30dce [^] => http://code.openbravo.com/erp/devel/pi/rev/f2c6cb563ee0fff4bfaefb2f19417d629222388e [^]
2009-10-15 19:13 iperdomo Note Added: 0021089
2009-10-15 19:14 iperdomo Status resolved => closed
2009-10-15 19:14 iperdomo Note Added: 0021091
2009-10-15 19:14 iperdomo Fixed in Version => pi
2009-10-16 00:00 anonymous sf_bug_id 0 => 2880174


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker