Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033267
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminoralways2016-06-15 09:542016-06-28 11:41
ReportermigueldejuanaView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision78f44c4885a3
ProjectionnoneETAnoneTarget Version3.0PR16Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033267: Add JSBeautifier script

DescriptionAdd scripts to check js files with JSBeautifier. Script to check:
- All js files in openbravo
- All js files in a module
- Hooks to check files when doing a commit
Steps To ReproduceSee description
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0087286)
migueldejuana (developer)
2016-06-15 09:57

 Resolved with these commits:

https://code.openbravo.com/erp/devel/pi/rev/098506f49242 [^]
https://code.openbravo.com/erp/devel/pi/rev/25cda173d4d8 [^]
https://code.openbravo.com/erp/devel/pi/rev/84003e2e052d [^]
https://code.openbravo.com/erp/devel/pi/rev/e441b7bacc5f [^]
https://code.openbravo.com/erp/devel/pi/rev/1cfa227f1b1e [^]
https://code.openbravo.com/erp/devel/pi/rev/35da6d3b9abc [^]
(0087287)
migueldejuana (developer)
2016-06-15 09:58

 Show a more clear error message. Add empty lines after or something like that.
(0087321)
hgbot (developer)
2016-06-16 07:26

 Repository: erp/devel/pi
Changeset: 7e172d861766253ac2dfa001d226b064cab5f58c
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 16 07:25:32 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7e172d861766253ac2dfa001d226b064cab5f58c [^]

Related to issue Related to issue 0033267: Add JSBeautifier script

- Show a more clear error message

---
M modules/org.openbravo.client.kernel/jsbeautify/jsbeautify
M modules/org.openbravo.client.kernel/jsbeautify/jsbeautify-module
M modules/org.openbravo.client.kernel/jsbeautify/jscheck-btfy
M modules/org.openbravo.client.kernel/jsbeautify/jscheck-btfy-module
---
(0087322)
migueldejuana (developer)
2016-06-16 07:28

 - Try to show the cause of the error.
- A empty comment line with one space is not beautified in Eclipse plugin but it is in the script:

/*
* Comment example
*
*/
(0087623)
hudsonbot (developer)
2016-06-17 19:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087839)
hgbot (developer)
2016-06-23 07:38

 Repository: erp/devel/pi
Changeset: aff0703918852f20f3a5e628d8dfba99210b3485
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jun 22 15:50:58 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/aff0703918852f20f3a5e628d8dfba99210b3485 [^]

Related to issue 0033267: Add JSBeautifier script

- Show a description of JSBeautifier

---
M modules/org.openbravo.client.kernel/jsbeautify/jsbeautify
M modules/org.openbravo.client.kernel/jsbeautify/jsbeautify-module
---
(0087840)
hgbot (developer)
2016-06-23 07:38

 Repository: erp/devel/pi
Changeset: 1f60535ebd42000961648fa5ffd195f302c465a9
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jun 22 17:39:21 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1f60535ebd42000961648fa5ffd195f302c465a9 [^]

Fixed issue 0033267: Add JSBeautifier script

- Add in description "JS Beautifier Eclipse plugin doesn't remove white spaces at the end of the line in block comments. You have to do it manually"

---
M modules/org.openbravo.client.kernel/jsbeautify/jsbeautify
M modules/org.openbravo.client.kernel/jsbeautify/jsbeautify-module
---
(0087842)
hgbot (developer)
2016-06-23 07:47

 Repository: erp/devel/pi
Changeset: 6a6ba4787b0797727b1b2697f6f996d65604b60a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 23 07:46:49 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6a6ba4787b0797727b1b2697f6f996d65604b60a [^]

Fixed issue 0033267: Add JSBeautifier script

- Show a more clear description.

---
M modules/org.openbravo.client.kernel/jsbeautify/jsbeautify
M modules/org.openbravo.client.kernel/jsbeautify/jsbeautify-module
---
(0087856)
hudsonbot (developer)
2016-06-23 13:53

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b7338bc2498 [^]
Maturity status: Test
(0087857)
hudsonbot (developer)
2016-06-23 13:53

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b7338bc2498 [^]
Maturity status: Test
(0087858)
hudsonbot (developer)
2016-06-23 13:53

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b7338bc2498 [^]
Maturity status: Test
(0087869)
hgbot (developer)
2016-06-24 08:40

 Repository: erp/devel/pi
Changeset: 78f44c4885a3dad042bd06d44f562fee419a8c71
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Jun 24 08:40:02 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/78f44c4885a3dad042bd06d44f562fee419a8c71 [^]

Fixed issue 0033267: Add JSBeautifier script

- Replacing we were doing perl -pe 'chop if eof' 2 times. Use cat instead to do not remove last character

---
M modules/org.openbravo.client.kernel/jsbeautify/jsbeautify
M modules/org.openbravo.client.kernel/jsbeautify/jsbeautify-module
---
(0087905)
hudsonbot (developer)
2016-06-24 14:28

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9a8baa389751 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-06-15 09:54 migueldejuana New Issue
2016-06-15 09:54 migueldejuana Assigned To => migueldejuana
2016-06-15 09:54 migueldejuana Modules => Core
2016-06-15 09:54 migueldejuana Triggers an Emergency Pack => No
2016-06-15 09:54 migueldejuana Status new => scheduled
2016-06-15 09:57 migueldejuana Note Added: 0087286
2016-06-15 09:57 migueldejuana Status scheduled => resolved
2016-06-15 09:57 migueldejuana Fixed in SCM revision => c3e4d0384dc0
2016-06-15 09:57 migueldejuana Resolution open => fixed
2016-06-15 09:58 migueldejuana Note Added: 0087287
2016-06-15 09:58 migueldejuana Status resolved => new
2016-06-15 09:58 migueldejuana Resolution fixed => open
2016-06-16 07:26 hgbot Checkin
2016-06-16 07:26 hgbot Note Added: 0087321
2016-06-16 07:28 migueldejuana Note Added: 0087322
2016-06-17 19:38 hudsonbot Checkin
2016-06-17 19:38 hudsonbot Note Added: 0087623
2016-06-23 07:38 hgbot Checkin
2016-06-23 07:38 hgbot Note Added: 0087839
2016-06-23 07:38 hgbot Checkin
2016-06-23 07:38 hgbot Note Added: 0087840
2016-06-23 07:38 hgbot Status new => resolved
2016-06-23 07:38 hgbot Resolution open => fixed
2016-06-23 07:38 hgbot Fixed in SCM revision c3e4d0384dc0 => http://code.openbravo.com/erp/devel/pi/rev/1f60535ebd42000961648fa5ffd195f302c465a9 [^]
2016-06-23 07:47 hgbot Checkin
2016-06-23 07:47 hgbot Note Added: 0087842
2016-06-23 07:47 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/1f60535ebd42000961648fa5ffd195f302c465a9 [^] => http://code.openbravo.com/erp/devel/pi/rev/6a6ba4787b0797727b1b2697f6f996d65604b60a [^]
2016-06-23 13:53 hudsonbot Checkin
2016-06-23 13:53 hudsonbot Note Added: 0087856
2016-06-23 13:53 hudsonbot Checkin
2016-06-23 13:53 hudsonbot Note Added: 0087857
2016-06-23 13:53 hudsonbot Checkin
2016-06-23 13:53 hudsonbot Note Added: 0087858
2016-06-24 08:40 hgbot Checkin
2016-06-24 08:40 hgbot Note Added: 0087869
2016-06-24 08:40 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/6a6ba4787b0797727b1b2697f6f996d65604b60a [^] => http://code.openbravo.com/erp/devel/pi/rev/78f44c4885a3dad042bd06d44f562fee419a8c71 [^]
2016-06-24 14:28 hudsonbot Checkin
2016-06-24 14:28 hudsonbot Note Added: 0087905
2016-06-27 12:28 migueldejuana Assigned To migueldejuana => Retail
2016-06-27 12:28 migueldejuana Assigned To Retail => migueldejuana
2016-06-28 11:41 marvintm Review Assigned To => marvintm
2016-06-28 11:41 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker