Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0025557
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajorhave not tried2014-01-24 14:222014-03-14 19:45
ReporterjonalegriaesarteView Statuspublic 
Assigned Toshankarb 
PriorityurgentResolutionfixedFixed in Version3.0PR14Q2
StatusclosedFix in branchpiFixed in SCM revision15a48f5b6cfe
ProjectionnoneETAnoneTarget Version3.0PR14Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0025557: Is not possible to enter more than one datasource table in ORACLE

DescriptionIs not possible to enter more than one datasource table in ORACLE. There is a unique constraint called AD_TABLE_CLASSNAME_PACKAGE_UN in AD_TABLE that has the fields: CLASSNAME and AD_PACKAGE_ID

When you introduce a "datasource table" you don't need the classname so you leave it to blank / null and then when you insert the second record with the
classname = null the constraint is violated in ORACLE.

For example:

Record 1
CLASSNAME: NULL
AD_PACKAGE_ID: 123

Record 2
CLASSNAME: NULL
AD_PACKAGE_ID: 123

Will violate the constraint in Oracle but not in PostgreSQL: https://www.pgrs.net/2008/01/11/postgresql-allows-duplicate-nulls-in-unique-columns/ [^]
Steps To Reproduce- See Description of the issue
TagsNo tags attached.
Attached Filesdiff file icon FixIssue25557.diff [^] (1,316 bytes) 2014-01-28 10:07 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00259123.0PR14Q2 closedshankarb API Change Request : Drop constraint AD_TABLE_CLASSNAME_PACKAGE_UN from AD_Table 
has duplicate defect 0024989 closedAugustoMauch Cannot add more than one datasource based table on a package 

-  Notes
(0063739)
shankarb (reporter)
2014-01-28 10:08

 Pushed to try
(0063805)
hgbot (developer)
2014-01-30 11:54

 Repository: erp/devel/pi
Changeset: 018b8e666e7db3f22cf14cd4de566eea3da2d2d3
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Jan 30 16:20:10 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/018b8e666e7db3f22cf14cd4de566eea3da2d2d3 [^]

Fixes Issue 025557: Is not possible to enter more than one datasource table in ORACLE

Is not possible to enter more than one datasource table in ORACLE.
There is a unique constraint called AD_TABLE_CLASSNAME_PACKAGE_UN in AD_TABLE that has the fields: CLASSNAME and AD_PACKAGE_ID.
Changed the constraint to unique index to solve this issue.

---
M src-db/database/model/tables/AD_TABLE.xml
---
(0064138)
hudsonbot (developer)
2014-02-12 18:29

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d1a5bb862230 [^]
Maturity status: Test
(0064221)
AugustoMauch (manager)
2014-02-13 12:04

 Code reviewed and verified in pi@9d50bf45a6c9
(0064899)
shankarb (reporter)
2014-03-06 11:17

 Issue still reproducible. The issue will be fixed by adding an event handler instead of index.
(0064913)
hgbot (developer)
2014-03-06 13:27

 Repository: erp/devel/pi
Changeset: ea70861b5474946bd4bc13469e90cabef444568e
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Mar 06 17:53:50 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/ea70861b5474946bd4bc13469e90cabef444568e [^]

Fixes Issue 0025557: Is not possible to enter more than one datasource table in ORACLE

Dropped constraint AD_TABLE_CLASSNAME_PACKAGE_UN as it is not accepting null values in Oracle.
Added event handler to handle the same logic.

---
M src-db/database/model/tables/AD_TABLE.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
A src/org/openbravo/event/ADTableEventHandler.java
---
(0064945)
hudsonbot (developer)
2014-03-07 05:25

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9364dd72aca6 [^]
Maturity status: Test
(0064977)
AugustoMauch (manager)
2014-03-10 10:20

 Code reviewed and verified in pi@8c76a7a6bf32
(0064980)
AugustoMauch (manager)
2014-03-10 12:30

 Reopened, because it is not possible to save a change made on an existing table.

The problem is that when looking for tables with the same java classname and datapackage of the table being saved, the table being saved should not be taken into account.
(0064983)
hgbot (developer)
2014-03-10 12:46

 Repository: erp/devel/pi
Changeset: 15a48f5b6cfe17887c83acf790369cb98f1a3234
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Mar 10 17:14:30 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/15a48f5b6cfe17887c83acf790369cb98f1a3234 [^]

Fixes Issue 0025557: Is not possible to enter more than one datasource table in ORACLE

Duplication error is not raised when the same record is being updated.

---
M src/org/openbravo/event/ADTableEventHandler.java
---
(0065006)
hudsonbot (developer)
2014-03-10 22:58

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b362f74ef31a [^]
Maturity status: Test
(0065170)
AugustoMauch (manager)
2014-03-14 19:45

 Code reviewed and verified in pi@d7843bd87a36

- Issue History
Date Modified Username Field Change
2014-01-24 14:22 jonalegriaesarte New Issue
2014-01-24 14:22 jonalegriaesarte Assigned To => AugustoMauch
2014-01-24 14:22 jonalegriaesarte Modules => Core
2014-01-24 14:22 jonalegriaesarte Triggers an Emergency Pack => No
2014-01-27 13:36 alostale Relationship added has duplicate 0024989
2014-01-28 07:16 shankarb Assigned To AugustoMauch => shankarb
2014-01-28 10:07 shankarb File Added: FixIssue25557.diff
2014-01-28 10:08 shankarb Status new => scheduled
2014-01-28 10:08 shankarb Note Added: 0063739
2014-01-28 10:08 shankarb fix_in_branch => pi
2014-01-30 10:58 dmitry_mezentsev Note Added: 0063799
2014-01-30 10:59 dmitry_mezentsev Note Deleted: 0063799
2014-01-30 11:51 shankarb Review Assigned To => AugustoMauch
2014-01-30 11:51 shankarb fix_in_branch pi =>
2014-01-30 11:52 shankarb Issue Monitored: AugustoMauch
2014-01-30 11:54 hgbot Checkin
2014-01-30 11:54 hgbot Note Added: 0063805
2014-01-30 11:54 hgbot Status scheduled => resolved
2014-01-30 11:54 hgbot Resolution open => fixed
2014-01-30 11:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/018b8e666e7db3f22cf14cd4de566eea3da2d2d3 [^]
2014-02-12 18:29 hudsonbot Checkin
2014-02-12 18:29 hudsonbot Note Added: 0064138
2014-02-13 12:04 AugustoMauch Note Added: 0064221
2014-02-13 12:04 AugustoMauch Status resolved => closed
2014-02-13 12:04 AugustoMauch Fixed in Version => 3.0MP32
2014-03-06 11:17 shankarb Note Added: 0064899
2014-03-06 11:17 shankarb Status closed => new
2014-03-06 11:17 shankarb Resolution fixed => open
2014-03-06 11:17 shankarb Fixed in Version PR14Q2 =>
2014-03-06 11:18 shankarb Status new => scheduled
2014-03-06 11:18 shankarb fix_in_branch => pi
2014-03-06 11:18 shankarb Relationship added related to 0025912
2014-03-06 13:27 hgbot Checkin
2014-03-06 13:27 hgbot Note Added: 0064913
2014-03-06 13:27 hgbot Status scheduled => resolved
2014-03-06 13:27 hgbot Resolution open => fixed
2014-03-06 13:27 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/018b8e666e7db3f22cf14cd4de566eea3da2d2d3 [^] => http://code.openbravo.com/erp/devel/pi/rev/ea70861b5474946bd4bc13469e90cabef444568e [^]
2014-03-07 05:25 hudsonbot Checkin
2014-03-07 05:25 hudsonbot Note Added: 0064945
2014-03-10 10:20 AugustoMauch Note Added: 0064977
2014-03-10 10:20 AugustoMauch Status resolved => closed
2014-03-10 10:20 AugustoMauch Fixed in Version => PR14Q2
2014-03-10 12:30 AugustoMauch Note Added: 0064980
2014-03-10 12:30 AugustoMauch Status closed => new
2014-03-10 12:30 AugustoMauch Resolution fixed => open
2014-03-10 12:30 AugustoMauch Fixed in Version PR14Q2 =>
2014-03-10 12:46 hgbot Checkin
2014-03-10 12:46 hgbot Note Added: 0064983
2014-03-10 12:46 hgbot Status new => resolved
2014-03-10 12:46 hgbot Resolution open => fixed
2014-03-10 12:46 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/ea70861b5474946bd4bc13469e90cabef444568e [^] => http://code.openbravo.com/erp/devel/pi/rev/15a48f5b6cfe17887c83acf790369cb98f1a3234 [^]
2014-03-10 22:58 hudsonbot Checkin
2014-03-10 22:58 hudsonbot Note Added: 0065006
2014-03-14 19:45 AugustoMauch Note Added: 0065170
2014-03-14 19:45 AugustoMauch Status resolved => closed
2014-03-14 19:45 AugustoMauch Fixed in Version => PR14Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker