Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024229
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2013-06-29 15:022013-07-29 09:41
ReportershuehnerView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version3.0MP26
StatusclosedFix in branchpiFixed in SCM revision295e879c0198
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toshankarb
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024229: When in 'New in Form' directly leaving that mode with the X without saving causes datasource for children to be loaded

DescriptionRelated to issue 24228.

Grid for Sales Order open, no rows selected.
Click new in form.
Directly close the new in form overlay with the X icon
Then grid is shown again with no row selected
A datasource request is fired for OrderLine.
That does not make sense without a header selected as there cannot be any children.
Steps To ReproduceFollow steps to reproduce for issue 24228.
Click X to close the new in form
Observe that no row in SalesOrder grid is selected
Observe that still a Datasource fetch request for OrderLine is fired.
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0024228 closedAugustoMauch When clicking new in Sales Order Grid request is fired to OrderLine data 
related to defect 0024358 closedshankarb Create periods button is not showing 

-  Notes
(0060061)
shankarb (reporter)
2013-07-17 07:57

 0024229: When closing new records in form, request is done to child tabs

When creating a new record in form and closing the form instead of saving, if the record is getting saved, the child views were refreshed.
But in grid no records were selected. So refreshing the child views only if there is any selected record.
(0060062)
shankarb (reporter)
2013-07-17 07:58

 Fixed in pi commit https://code.openbravo.com/erp/devel/pi/rev/7774d6f61619. [^] Not added automatically because of the incorrect commit message format.
(0060063)
hgbot (developer)
2013-07-17 08:35

 Repository: erp/devel/pi
Changeset: 7f41ff531586ed015981e732021cdf337d52088e
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Jul 17 12:04:54 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/7f41ff531586ed015981e732021cdf337d52088e [^]

Related to Issue 0024229 : code refactoring based on jslint tests

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0060086)
hgbot (developer)
2013-07-18 06:02

 Repository: erp/devel/pi
Changeset: 78ca177ad70d734f4510db53cdc14a0a104a6f12
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Thu Jul 18 09:31:04 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/78ca177ad70d734f4510db53cdc14a0a104a6f12 [^]

Fixes Issue 24358, backout issue 24229 : backedout changeset 7774d6f61619

The fix block refreshing child views when saving parent on all cases.
But it should be done only when closing the record and switching to grid view.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0060088)
shankarb (reporter)
2013-07-18 06:03

 Fix backed out.
(0060109)
hudsonbot (developer)
2013-07-19 01:27

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/331a689d4f6c [^]

Maturity status: Test
(0060114)
hudsonbot (developer)
2013-07-19 01:27

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/331a689d4f6c [^]

Maturity status: Test
(0060264)
hgbot (developer)
2013-07-24 16:54

 Repository: erp/devel/pi
Changeset: 295e879c019810985e4eb7290aa94209fe96566b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jul 24 16:52:37 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/295e879c019810985e4eb7290aa94209fe96566b [^]

Fixes issue 24228, issue 24229: Avoids not needed datasource

Some not needed datasource calls were being made when a record was created in grid or form view. It made no sense to ask the datasource for the data of the child tabs of the new record, we can be sure there are none. To fix this, instead of calling the datasource the data of the child grid is emptied manually, and then the emptyMessage of the grid is updated.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0060313)
hudsonbot (developer)
2013-07-26 20:32

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b9e43ea5aa1b [^]

Maturity status: Test
(0060342)
shankarb (reporter)
2013-07-29 09:41

 Code reviewed and tested in pi changeset 2128830a28ff.

- Issue History
Date Modified Username Field Change
2013-06-29 15:02 shuehner New Issue
2013-06-29 15:02 shuehner Assigned To => AugustoMauch
2013-06-29 15:02 shuehner Modules => Core
2013-06-29 15:02 shuehner Triggers an Emergency Pack => No
2013-06-29 15:02 shuehner Relationship added related to 0024228
2013-06-29 15:02 shuehner Tag Attached: Performance
2013-07-16 07:20 shankarb Assigned To AugustoMauch => shankarb
2013-07-17 07:53 shankarb Review Assigned To => mtaal
2013-07-17 07:55 shankarb Issue Monitored: mtaal
2013-07-17 07:57 shankarb Status new => scheduled
2013-07-17 07:57 shankarb fix_in_branch => pi
2013-07-17 07:57 shankarb Note Added: 0060061
2013-07-17 07:57 shankarb Status scheduled => resolved
2013-07-17 07:57 shankarb Fixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/7774d6f61619 [^]
2013-07-17 07:57 shankarb Resolution open => fixed
2013-07-17 07:58 shankarb Note Added: 0060062
2013-07-17 08:35 hgbot Checkin
2013-07-17 08:35 hgbot Note Added: 0060063
2013-07-18 06:02 hgbot Checkin
2013-07-18 06:02 hgbot Note Added: 0060086
2013-07-18 06:03 shankarb Note Added: 0060088
2013-07-18 06:03 shankarb Status resolved => new
2013-07-18 06:03 shankarb Resolution fixed => open
2013-07-19 01:27 hudsonbot Checkin
2013-07-19 01:27 hudsonbot Note Added: 0060109
2013-07-19 01:27 hudsonbot Checkin
2013-07-19 01:27 hudsonbot Note Added: 0060114
2013-07-24 12:15 AugustoMauch Assigned To shankarb => AugustoMauch
2013-07-24 12:30 AugustoMauch Relationship added related to 0024358
2013-07-24 16:53 AugustoMauch Issue End Monitor: mtaal
2013-07-24 16:53 AugustoMauch Issue Monitored: shankarb
2013-07-24 16:53 AugustoMauch Review Assigned To mtaal => shankarb
2013-07-24 16:53 AugustoMauch fix_in_branch pi =>
2013-07-24 16:54 hgbot Checkin
2013-07-24 16:54 hgbot Note Added: 0060264
2013-07-24 16:55 AugustoMauch Status new => scheduled
2013-07-24 16:55 AugustoMauch fix_in_branch => pi
2013-07-24 16:55 AugustoMauch Note Added: 0060266
2013-07-24 16:55 AugustoMauch Note Deleted: 0060266
2013-07-24 16:56 AugustoMauch Status scheduled => resolved
2013-07-24 16:56 AugustoMauch Fixed in SCM revision https://code.openbravo.com/erp/devel/pi/rev/7774d6f61619 [^] => https://code.openbravo.com/erp/devel/pi/rev/295e879c019810985e4eb7290aa94209fe96566b [^]
2013-07-24 16:56 AugustoMauch Resolution open => fixed
2013-07-26 20:32 hudsonbot Checkin
2013-07-26 20:32 hudsonbot Note Added: 0060313
2013-07-29 09:41 shankarb Note Added: 0060342
2013-07-29 09:41 shankarb Status resolved => closed
2013-07-29 09:41 shankarb Fixed in Version => 3.0MP26

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker