0021888: Editable Payment Plan: The column 'Payment Method' does not work properly

(0053189)
dmiguelez (developer)
2012-10-10 10:17

There is an underlying problem when creating the drop down list.

In the existing line, click on the arrow to show the list and realize that there are rows, but there is not text shown. Check the number of rows shown.

Now create a new line and click on the arrow again, realize that the number of rows has incremented in one unit.

This process can be repeated, and each time the list will have one more unit. Which is also wrong.

(0053909)
jonalegriaesarte (reporter)
2012-10-31 10:26

This change needs to be tested very carefully. Moving it to next MP

(0054279)
hgbot (developer)
2012-11-16 09:38

Repository: erp/devel/pi
Changeset: 2c39d6a6c5466901d7afc98358e2cf83c325fa36
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Fri Nov 16 09:36:31 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2c39d6a6c5466901d7afc98358e2cf83c325fa36 [^]

Fixes Issue 0021888: Issues in Payment Plan P&E Windows.

In Modify Payment plan P&E window, the payment method field's dropdown did not show any records.
Added logic to cache drop down values (rowEditorEnter method) if not a modify payment plan P&E window.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---

(0054280)
shankarb (reporter)
2012-11-16 09:39

Reopened to add Review Assigned to

(0054393)
hudsonbot (developer)
2012-11-21 06:07

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c3c5e61b0164 [^]

Maturity status: Test

(0054422)
maite (developer)
2012-11-21 12:34

verified

(0054423)
xabiermerino (reporter)
2012-11-21 12:37

Test case:
-You have to display the button first
-As Admin create and complete a Sales Invoice
-Click the button
-try to modify the first line
-realize that the Payment Method dissapear

(0054426)
maite (developer)
2012-11-21 12:42

functional testing done

(0054427)
xabiermerino (reporter)
2012-11-21 12:50

Test case updated:
- As system go to the Windows, Tabs and Fields
- select Sales Invoice
- go to the tab and select Payment Plan
- Select the field Modify Payment Plan and set as displayed
- Compile (ant smartbuild)
- As Admin create and complete a Sales Invoice
- Go to the tab Payment Plan
- Click the button 'Modify Payment Plan'
- try to modify the first line
- realize that the Payment Method dissapear

(0054429)
dbaz (developer)
2012-11-21 13:10

Reviewed @ changeset: 18585 - c0bf245121ad

Issue History
Date Modified	Username	Field	Change
2012-10-09 12:33	xabiermerino	New Issue
2012-10-09 12:33	xabiermerino	Assigned To	=> dmiguelez
2012-10-09 12:33	xabiermerino	Modules	=> Core
2012-10-09 12:33	xabiermerino	Resolution time	=> 1352674800
2012-10-09 12:53	dmiguelez	Assigned To	dmiguelez => jonalegriaesarte
2012-10-10 10:17	dmiguelez	Note Added: 0053189
2012-10-23 18:41	jonalegriaesarte	Assigned To	jonalegriaesarte => jecharri
2012-10-30 10:08	jecharri	Assigned To	jecharri => shankarb
2012-10-30 10:08	jecharri	Category	07. Sales management => A. Platform
2012-10-31 10:26	jonalegriaesarte	Note Added: 0053909
2012-10-31 10:26	jonalegriaesarte	Target Version	3.0MP17 => 3.0MP18
2012-11-16 09:38	hgbot	Checkin
2012-11-16 09:38	hgbot	Note Added: 0054279
2012-11-16 09:38	hgbot	Status	new => resolved
2012-11-16 09:38	hgbot	Resolution	open => fixed
2012-11-16 09:38	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/2c39d6a6c5466901d7afc98358e2cf83c325fa36 [^]
2012-11-16 09:39	shankarb	Note Added: 0054280
2012-11-16 09:39	shankarb	Status	resolved => new
2012-11-16 09:39	shankarb	Resolution	fixed => open
2012-11-16 09:39	shankarb	Review Assigned To	=> dbaz
2012-11-16 09:39	shankarb	Status	new => scheduled
2012-11-16 09:39	shankarb	fix_in_branch	=> pi
2012-11-16 09:40	shankarb	Status	scheduled => resolved
2012-11-16 09:40	shankarb	Resolution	open => fixed
2012-11-16 09:40	shankarb	Issue Monitored: dbaz
2012-11-21 06:07	hudsonbot	Checkin
2012-11-21 06:07	hudsonbot	Note Added: 0054393
2012-11-21 12:34	maite	Note Added: 0054422
2012-11-21 12:34	maite	Status	resolved => closed
2012-11-21 12:37	xabiermerino	Note Added: 0054423
2012-11-21 12:42	maite	Status	closed => new
2012-11-21 12:42	maite	Resolution	fixed => open
2012-11-21 12:42	maite	Note Added: 0054426
2012-11-21 12:43	maite	Status	new => acknowledged
2012-11-21 12:43	maite	Status	acknowledged => scheduled
2012-11-21 12:43	maite	Status	scheduled => resolved
2012-11-21 12:43	maite	Resolution	open => fixed
2012-11-21 12:50	xabiermerino	Note Added: 0054427
2012-11-21 13:10	dbaz	Note Added: 0054429
2012-11-21 13:10	dbaz	Status	resolved => closed
2012-11-21 13:10	dbaz	Fixed in Version	=> 3.0MP18

Notes
(0053189) dmiguelez (developer) 2012-10-10 10:17	There is an underlying problem when creating the drop down list. In the existing line, click on the arrow to show the list and realize that there are rows, but there is not text shown. Check the number of rows shown. Now create a new line and click on the arrow again, realize that the number of rows has incremented in one unit. This process can be repeated, and each time the list will have one more unit. Which is also wrong.

(0053909) jonalegriaesarte (reporter) 2012-10-31 10:26	This change needs to be tested very carefully. Moving it to next MP

(0054279) hgbot (developer) 2012-11-16 09:38	Repository: erp/devel/pi Changeset: 2c39d6a6c5466901d7afc98358e2cf83c325fa36 Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Fri Nov 16 09:36:31 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/2c39d6a6c5466901d7afc98358e2cf83c325fa36 [^] Fixes Issue 0021888: Issues in Payment Plan P&E Windows. In Modify Payment plan P&E window, the payment method field's dropdown did not show any records. Added logic to cache drop down values (rowEditorEnter method) if not a modify payment plan P&E window. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js ---

(0054280) shankarb (reporter) 2012-11-16 09:39	Reopened to add Review Assigned to

(0054393) hudsonbot (developer) 2012-11-21 06:07	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c3c5e61b0164 [^] Maturity status: Test

(0054422) maite (developer) 2012-11-21 12:34	verified

(0054423) xabiermerino (reporter) 2012-11-21 12:37	Test case: -You have to display the button first -As Admin create and complete a Sales Invoice -Click the button -try to modify the first line -realize that the Payment Method dissapear

(0054426) maite (developer) 2012-11-21 12:42	functional testing done

(0054427) xabiermerino (reporter) 2012-11-21 12:50	Test case updated: - As system go to the Windows, Tabs and Fields - select Sales Invoice - go to the tab and select Payment Plan - Select the field Modify Payment Plan and set as displayed - Compile (ant smartbuild) - As Admin create and complete a Sales Invoice - Go to the tab Payment Plan - Click the button 'Modify Payment Plan' - try to modify the first line - realize that the Payment Method dissapear

(0054429) dbaz (developer) 2012-11-21 13:10	Reviewed @ changeset: 18585 - c0bf245121ad

Relationships [ Relation Graph ] [ Dependency Graph ]