Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0013156
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 02. Master data managementmajoralways2010-04-29 10:202010-05-26 00:00
ReporternetworkbView Statuspublic 
Assigned Toadrianromero 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiondf3237be3b3f
ProjectionnoneETAnoneTarget Version2.50MP17
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP14SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013156: C_ValidCombination_Get does not work properly

DescriptionThis function is not working properly, when inserting new Journal Entries (using IDL module).

If more than two records are imported, with same account but diferent products, or BP, only the first validcombination is inserted.

When C_ValidCombination_Get is called, with an account, its valid combination is created. However, if same function is called with same account, and a product, function returns the first valid combination.

And that is not correct. It should create a new one for account + product.
Steps To Reproduce(Note: IDL module must be installed)

Import csv attached.

Then, test in database that only one accounting combination is created:

select * from c_validcombination order by created desc
TagsNo tags attached.
Attached Filescsv file icon Nat3.csv [^] (836 bytes) 2010-04-29 10:20

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0026963)
hgbot (developer)
2010-05-05 17:54

Repository: erp/devel/pi
Changeset: df3237be3b3fbcec2ad414de3922b28046b15be4
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed May 05 17:53:12 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/df3237be3b3fbcec2ad414de3922b28046b15be4 [^]

Fixes issue 0013156: C_ValidCombination_Get does not work properly

---
M src-db/database/model/functions/C_VALIDCOMBINATION_GET.xml
---
(0026964)
adrianromero (manager)
2010-05-05 18:00

# Testing of the issue:
To test the issue just follow the steps to test and verify that an accounting combination is created for each product
# Explanation of the changeset that fixes the issue:
It has been modified the SQL filter in the C_VALIDCOMBINATION_GET procedure that verifies it already exists a valid combination for the required accounting dimensions. This filter was wrong because it the accounting dimension to verify was null and already existed a valid combination with that accounting dimension not null it returned it and this is wrong.
# Other areas affected by the changeset:
All other procedures that invoked the C_VALIDCOMBINATION_GET are affected by this change. But the logic modified is only related to this procedure so the fix is correct for all.
(0027484)
hudsonbot (developer)
2010-05-18 21:43

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/df3237be3b3f [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]
(0027733)
eduardo_Argal (developer)
2010-05-25 18:52

ok

- Issue History
Date Modified Username Field Change
2010-04-29 10:20 networkb New Issue
2010-04-29 10:20 networkb Assigned To => adrianromero
2010-04-29 10:20 networkb File Added: Nat3.csv
2010-04-29 10:27 networkb Summary C_GetValidCombination does not work properly => C_ValidCombination_Get does not work properly
2010-04-29 10:27 networkb Description Updated View Revisions
2010-05-04 13:30 adrianromero Status new => scheduled
2010-05-05 17:54 hgbot Checkin
2010-05-05 17:54 hgbot Note Added: 0026963
2010-05-05 17:54 hgbot Status scheduled => resolved
2010-05-05 17:54 hgbot Resolution open => fixed
2010-05-05 17:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/df3237be3b3fbcec2ad414de3922b28046b15be4 [^]
2010-05-05 18:00 adrianromero Note Added: 0026964
2010-05-11 18:19 jpabloae Target Version 2.50MP16 => 2.50MP17
2010-05-18 21:43 hudsonbot Checkin
2010-05-18 21:43 hudsonbot Note Added: 0027484
2010-05-25 18:52 eduardo_Argal Note Added: 0027733
2010-05-25 18:52 eduardo_Argal Status resolved => closed
2010-05-26 00:00 anonymous sf_bug_id 0 => 3007108


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker