Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Java Client POS] (No Category)minoralways2009-06-10 01:362010-07-23 00:00
ReporterfalconView Statuspublic 
Assigned Toadrianromero 
PrioritynormalResolutionfixedFixed in Version2.30.1
StatusclosedFix in branchFixed in SCM revisionf62e4ef02806
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version1.6
OS VersionDatabase versionAnt version
Product Version2.30SCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release

0009412: "Regular Expression" filter is a partial string filter and does not work in product filter.

DescriptionThe product filter supplies a dropdown item labeled "Regular expression". This filter, however, provides only partial string matching, not regular expressions.

As a consequence, the name cannot be filtered by a partial string match.
Steps To ReproduceStock | Products | search by "Regular expression"
Proposed SolutionChange to "Partial", append % on the search string.

The attached patch modifies the name of the RE filter to PARTIAL, to better indicate what it does, and changes the locale to indicate that it's a partial match. Also, the ProductFilter class surrounds the match text with %%, as is done elsewhere (customer search).
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
falcon (reporter)
2009-06-10 01:38

I didn't even notice, but the patch contains an extra function to remove filters from the list of them. For the name, it makes no sense to have an is null/is not null, as the database requires it be defined. For the prices, it makes no sense to have the above two, nor the partial match on a float number (does that even work?).

This should've probably been another patch, but.. I didn't notice it on submit.
hgbot (developer)
2009-06-15 15:41

Repository: pos/devel/main
Changeset: f62e4ef02806900c6fe208593537c752bcc0bad0
Author: Adrián Romero <adrianromero <at>>
Date: Mon Jun 15 15:40:02 2009 +0200
URL: [^]

Fixes issue 0009412: "Regular Expression" filter is a partial string filter and does not work in product filter.

M locales/
M src-data/com/openbravo/data/gui/
M src-pos/com/openbravo/pos/panels/
M src-pos/com/openbravo/pos/ticket/
M src-pos/com/openbravo/pos/ticket/ProductFilterSales.form
M src-pos/com/openbravo/pos/ticket/
adrianromero (manager)
2009-06-15 15:47

The literal "Regular expression" has been replaced by "Wildcards". That IMO reflects better how LIKE works.

It also has been changed in order to show only the correct items in string or numeric fields and in mandatory or non mandatory fields

What has not been added is a "%" at the end, because the user is supposed to add it if he wants to filter comparing only the begining of the value and let him the possibility to compare only the end of the value.

- Issue History
Date Modified Username Field Change
2009-06-10 01:36 falcon New Issue
2009-06-10 01:36 falcon Assigned To => adrianromero
2009-06-10 01:38 falcon Note Added: 0017154
2009-06-15 15:41 hgbot Checkin
2009-06-15 15:41 hgbot Note Added: 0017312
2009-06-15 15:41 hgbot Status new => resolved
2009-06-15 15:41 hgbot Resolution open => fixed
2009-06-15 15:41 hgbot Fixed in SCM revision => [^]
2009-06-15 15:47 adrianromero Note Added: 0017313
2010-07-22 13:56 adrianromero Status resolved => closed
2010-07-22 14:02 adrianromero Fixed in Version => 2.30.1
2010-07-23 00:00 anonymous sf_bug_id 0 => 3033255
2012-11-07 09:40 priyam Category 01 - General => (No Category)

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker