Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0009104
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2009-05-20 12:182009-06-03 00:00
ReporternetworkbView Statuspublic 
Assigned Torafaroda 
PriorityimmediateResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revision7eecddf0cf81
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version
OS VersionDatabase versionAnt version
Product Version2.40MP3SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0009104: In the generate invoices window, review which sales orders should appear

DescriptionIn the generate invoices window, review which sales orders should appear in the combobox
Steps To Reproduce1) Create a Sales Order with Transaction Document = Standard Order and Invoice Terms = "Immediate". Create some lines but do NOT Complete it. Invoicerule = 'I'
2) Create a Sales Order with Transaction Document = Standard Order and Invoice Terms = "Customer Schedule After Delivery". Create some lines and Complete it. Invoicerule = 'S'
3) Create a Sales Order with Transaction Document = Standard Order and InvoiNe Terms = "Do not invoice". Create some lines and Complete it. Invoicerule = 'N'
4) Create a Sales Order with Transaction Document = Standard Order and Invoice Terms = "After order delivered". Create some lines (more than one) and Complete it. Invoicerule = 'O'
5) Create a Sales Order with Transaction Document = Standard Order and Invoice Terms = "After delivery". Create some lines (more than one) and Complete it. Invoicerule = 'D'
6) Create a Sales Order with Transaction Document = Standard Order and Invoice Terms = "Immediate". Create some lines and Complete it. Invoicerule = 'I'
7) Go to "Sales Management || Transactions || Generate Invoices" process.
Check that ONLY Sale Order 6 appears in Sales Order drop-down.
8) Select it and click on OK: an invoice is created for Sale Order 6.
9) Go to "Sales Management || Transactions || Goods Shipment" and create a good shipment for the business partner of sales order 5.
10) Click on "Create Lines From" and select Sale Order 5.
11) Select ONLY one line of the sale order and click on OK.
12) Click on "Create Lines From" and select Sale Order 4.
13) Select ONLY one line of the sale order and click on OK.
14) Complete this good shipment.
15) Go to "Sales Management || Transactions || Generate Invoices" process.
Check that ONLY Sales Order 5 appears in Sales Order drop-down.
16) Select it and click on OK: an invoice is created for lines of Sale Order 5 which has been previously delivered.
Click again on "Generate Invoices" process and check that no sales orders appear in the drop-down.
17) Go to "Sales Management || Transactions || Create Shipments from Orders", select Sales Orders 4 and 5 (some lines are pending to be delivered for both orders) and click on Process button: 2 goods shipments are created and completed.
18) Go to "Sales Management || Transactions || Generate Invoices" process.
Check that Sales Order 4 and 5 appear in Sales Order drop-down.
19) Do not select any and click on OK: 2 invoices are created for Sale Order 4 and 5 respectively.
Proposed SolutionThe functional requirements for orders to be displayed in Sales Order combo-box inside Generate Invoices process window are the following:
1) Orders have to be Sales Orders
2) Orders Document Status has to be in Completed or Closed.
3) Orders which ALL lines have already been invoiced have to be excluded.
4) Orders with Invoice Terms "Customer Schedule After Delivery" and "Do not invoice" have to be excluded: http://wiki.openbravo.com/wiki/Functional_Documentation/Sales_Management#Invoice_Terms [^]
5) Orders which Invoice Terms are "After order delivered" do not have to appear unless all their lines have been completely delivered.
6) Orders which Invoice Terms are "After delivery" do not have to appear unless any of their lines has been partially or totally delivered.
7) Orders which Invoice Terms are "Immediate" have to be displayed always.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0009187 closedrafaroda In the generate invoices window, review which sales orders should appear 

-  Notes
(0016701)
hgbot (developer)
2009-05-28 09:56

 Repository: erp/devel/pi
Changeset: e33e56290d764073853ddadfc63ffc15bf99be6c
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Thu May 28 09:56:01 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e33e56290d764073853ddadfc63ffc15bf99be6c [^]

Fixes issue 0009104 Changed \"C_Order SO to be invoiced\" and \"C_BPartner w SO to invoice\" validation rules to properly display sales orders and business partners to be shown in \"Generate Invoices\" process.

---
M src-db/database/sourcedata/AD_VAL_RULE.xml
---
(0016763)
TDS_Nik (reporter)
2009-05-29 13:26

 There is an issue with the Proposed Solution. For item 2 on the list it should be only Completed order. If an order is Closed, no further action should be taken on it. So if the order has partial quantity shippd the user might need to mark the order Closed so no more shipment are generated.
(0016777)
psarobe (manager)
2009-05-29 17:06

 Hi TDS,

Thanks for your feedback but the rational behavior behind "Closed" status is not what you think.

Closed status does not mean that no further action should be taken. What the action of closing does is to update the Ordered quantity to the same quantity that you have delivered. Let me give you two examples:
1. Purchase order: Imagine you ordered 10000 kg of coffee. It's obvious that you are not going to receive 10000kg. Let's say you receive 9923 kg. for the company this is ok but because both quantities are different the PO is still pending to be received and you don't want that. So what the Closed action let us to do is to closed the PO and at the same time it updates the Qty ordered to the received quantity so the PO is not pending anymore. But of course it's pending to be invoiced
2. The same happens to a sales order. Imagine a customer order 15 units of a product. You send to him 12 and when he receives the 12 unit he realizes that it is enough and calls the company saying that he doesn't want the rest. So closing the SO allows you to update the quantity ordered (15) to qty delivered (12) so the SO is not pending to delivery anymore but pending to be invoiced (12 units)
(0016845)
hgbot (developer)
2009-06-02 10:59

 Repository: erp/devel/pi
Changeset: 7eecddf0cf81731511fc08b875ae4bb0cdccd3c5
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Tue Jun 02 10:56:32 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7eecddf0cf81731511fc08b875ae4bb0cdccd3c5 [^]

Fixes issue 0009104 Removed ^M at the end of the lines.

---
M src-db/database/sourcedata/AD_VAL_RULE.xml
---
(0016847)
sureshbabu (reporter)
2009-06-02 11:18

 Tested working fine

- Issue History
Date Modified Username Field Change
2009-05-20 12:18 networkb New Issue
2009-05-20 12:18 networkb Assigned To => rafaroda
2009-05-20 12:18 networkb Regression testing => No
2009-05-20 12:22 rafaroda Assigned To rafaroda => gorkaion
2009-05-22 09:24 rafaroda Assigned To gorkaion => rafaroda
2009-05-26 16:38 rafaroda Summary In the generate invoices window a sales order with invoicerule = D (after delivery) should no appear => In the generate invoices window, review which sales orders should appear
2009-05-26 16:38 rafaroda Description Updated
2009-05-26 16:38 rafaroda Proposed Solution updated
2009-05-26 16:38 rafaroda Steps to Reproduce Updated
2009-05-26 16:48 rafaroda Steps to Reproduce Updated
2009-05-26 16:49 rafaroda Status new => scheduled
2009-05-26 16:49 rafaroda fix_in_branch => pi
2009-05-27 10:38 rafaroda fix_in_branch pi =>
2009-05-27 10:38 rafaroda Proposed Solution updated
2009-05-28 09:56 hgbot Checkin
2009-05-28 09:56 hgbot Note Added: 0016701
2009-05-28 09:56 hgbot Status scheduled => resolved
2009-05-28 09:56 hgbot Resolution open => fixed
2009-05-28 09:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e33e56290d764073853ddadfc63ffc15bf99be6c [^]
2009-05-29 13:26 TDS_Nik Note Added: 0016763
2009-05-29 17:06 psarobe Note Added: 0016777
2009-06-02 10:59 hgbot Checkin
2009-06-02 10:59 hgbot Note Added: 0016845
2009-06-02 10:59 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/e33e56290d764073853ddadfc63ffc15bf99be6c [^] => http://code.openbravo.com/erp/devel/pi/rev/7eecddf0cf81731511fc08b875ae4bb0cdccd3c5 [^]
2009-06-02 11:18 sureshbabu Status resolved => closed
2009-06-02 11:18 sureshbabu Note Added: 0016847
2009-06-02 11:18 sureshbabu Fixed in Version => pi
2009-06-03 00:00 anonymous sf_bug_id 0 => 2800236

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker