Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0055932 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Retail Modules] Discounts and Promotions | major | have not tried | 2024-07-05 16:39 | 2024-08-23 09:21 | |||
| Reporter | rqueralta | View Status | public | |||||
| Assigned To | rqueralta | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0055932: Improvements for Scaled Price type of discount | |||||||
| Description | Several customers, among all of Intersport, have asked several times to extend the functionality of one of the Discounts Openbravo has in the standard. This type of discount can be defined discounts just in percentage but it needed to also defined by: Fixed Price Amount discount This other way to define the discount is in other types of discounts such as Price Adjustment. | |||||||
| Steps To Reproduce | User Story 1: Define the discount as Fixed Price. As a manager I want to define a fixed price in the condition instead of a percentage in order to apply a specific discount/price on the product when it is selling. User Story 2: Approval to allow the discount to apply As a manager I want to define a fixed amount discount in the condition instead of a percentage in order to apply a specific amount discount on the product when it is selling. The current logic of this type of discount does not change in the sense of applying or selecting the products defined. What it only changes is the discount to be applied. Right now it is only calculating the discount based on a percentage. And after this development needs to apply the discount based on three possible different scenarios/discounts. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0167071) hgbot (developer) 2024-07-17 15:40 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/merge_requests/10 [^] |
|
(0168356) hgbot (developer) 2024-08-22 11:48 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/merge_requests/10 [^] |
|
(0168357) hgbot (developer) 2024-08-22 11:48 |
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^] Changeset: 82c46fdf998e05ce025bffc62ab554f6aed8d8db Author: Inigo Fernandez <inigo.fernandez@openbravo.com> Date: 22-08-2024 11:40:50 URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/82c46fdf998e05ce025bffc62ab554f6aed8d8db [^] Related to ISSUE-55932: added price adjustment type field to price scale discounts --- M referencedata/sampledata/The_White_Valley_Group/OBDSCAL_SCALE.xml --- |
|
(0168358) hgbot (developer) 2024-08-22 11:48 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^] Changeset: edd83e2b765077d350b5cd57636d480e2c353ab5 Author: Rafael <rafaelcuba81@gmail.com> Date: 07-07-2024 08:43:49 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/edd83e2b765077d350b5cd57636d480e2c353ab5 [^] Fixed ISSUE-55932: Improvements for Scaled Price type of discount --- M src-db/database/model/tables/OBDSCAL_SCALE.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_FIELD.xml M src/org/openbravo/retail/discounts/scaledprice/ScaledPriceProperties.java M web/org.openbravo.retail.discounts.scaledprice/app/model/business-logic/discounts-engine/engine/rules/scaled-price-discount.js --- |
|
(0168359) hgbot (developer) 2024-08-22 11:48 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^] Changeset: 6a24463f09c62730fa8a07658427dc802c3b2cf3 Author: Rafael <rafaelcuba81@gmail.com> Date: 10-07-2024 19:35:06 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/6a24463f09c62730fa8a07658427dc802c3b2cf3 [^] Related to ISSUE-55932: Set priceAdjustmentType by percentage as default flow --- M web/org.openbravo.retail.discounts.scaledprice/app/model/business-logic/discounts-engine/engine/rules/scaled-price-discount.js --- |
|
(0168360) hgbot (developer) 2024-08-22 11:48 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^] Changeset: cdc7670c76b00aa83ba88574bc7d0e6b2980a918 Author: Rafael <rafaelcuba81@gmail.com> Date: 22-07-2024 12:55:55 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/cdc7670c76b00aa83ba88574bc7d0e6b2980a918 [^] Related to ISSUE-55932: Checking if the scale object has any declaration for the current item number --- M web/org.openbravo.retail.discounts.scaledprice/app/model/business-logic/discounts-engine/engine/rules/scaled-price-discount.js --- |
|
(0168361) hgbot (developer) 2024-08-22 11:48 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^] Changeset: d01933893427d7f0343e32775256c623ef3e768c Author: Rafael <rafaelcuba81@gmail.com> Date: 29-07-2024 13:32:32 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/d01933893427d7f0343e32775256c623ef3e768c [^] Related to ISSUE-55932: Added automated test --- A src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceByAmountTest.java A src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceByFixedPriceTest.java A src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceByPercentTest.java M src-test/org/openbravo/discounts/scaledprice/test/base/model/PriceScale.java M src-test/org/openbravo/discounts/scaledprice/test/base/model/definition/ScaledPrice.java M src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountsUnitTestSuite.java --- |
|
(0168362) hgbot (developer) 2024-08-22 11:48 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^] Changeset: af37bfca685c38e3ea5275b2055083e5e473f622 Author: Rafael <rafaelcuba81@gmail.com> Date: 30-07-2024 22:21:48 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/af37bfca685c38e3ea5275b2055083e5e473f622 [^] Related to ISSUE-55932: Code review automated test --- M src-test/org/openbravo/discounts/scaledprice/test/base/model/PriceScale.java M src-test/org/openbravo/discounts/scaledprice/test/base/model/definition/ScaledPrice.java M src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceByAmountTest.java M src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceByFixedPriceTest.java --- |
|
(0168363) hgbot (developer) 2024-08-22 11:48 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^] Changeset: 4b5129108a90ba10d3f3e32755ec99b16c594264 Author: Rafael <rafaelcuba81@gmail.com> Date: 31-07-2024 13:29:34 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/4b5129108a90ba10d3f3e32755ec99b16c594264 [^] Related to ISSUE-55932: Fixed automated test --- M src-test/org/openbravo/discounts/scaledprice/test/base/model/PriceScale.java M src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceByAmountTest.java M src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceByFixedPriceTest.java --- |
|
(0168364) hgbot (developer) 2024-08-22 11:48 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^] Changeset: c319832ec31249e33847e645e30b1b51b00baa10 Author: Rafael <rafaelcuba81@gmail.com> Date: 02-08-2024 07:30:46 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/c319832ec31249e33847e645e30b1b51b00baa10 [^] Related to ISSUE-55932: Allow null value in percentage column --- M src-db/database/model/tables/OBDSCAL_SCALE.xml M src-db/database/sourcedata/AD_COLUMN.xml --- |
|
(0168365) hgbot (developer) 2024-08-22 11:48 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^] Changeset: 79b2e05b422ca18c243d5de1925066985fda770c Author: Rafael <rafaelcuba81@gmail.com> Date: 21-08-2024 13:25:32 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/79b2e05b422ca18c243d5de1925066985fda770c [^] Related to ISSUE-55932: Set Price Adjustment Type property --- M src-test/org/openbravo/discounts/scaledprice/test/base/model/PriceScale.java M src-test/org/openbravo/discounts/scaledprice/test/base/model/definition/ScaledPrice.java M src/org/openbravo/retail/discounts/scaledprice/ScaledPriceProperties.java M web/org.openbravo.retail.discounts.scaledprice/app/model/business-logic/discounts-engine/engine/rules/scaled-price-discount.js --- |
|
(0168366) hgbot (developer) 2024-08-22 11:48 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^] Changeset: fa89bd1ac8b301136db4a224c7d13087cb66c0ec Author: Inigo Fernandez <inigo.fernandez@openbravo.com> Date: 22-08-2024 10:55:32 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/fa89bd1ac8b301136db4a224c7d13087cb66c0ec [^] Related to ISSUE-55932: Changed column descriptions --- M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_FIELD.xml --- |
|
(0168367) hgbot (developer) 2024-08-22 11:48 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^] Changeset: e68d27c251c58e2ee91227bb172f4b067af1756b Author: Inigo Fernandez <inigo.fernandez@openbravo.com> Date: 22-08-2024 11:46:53 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/e68d27c251c58e2ee91227bb172f4b067af1756b [^] Fixes ISSUE-55932: Improvements for Scaled Price type of discount --- A src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceByAmountTest.java A src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceByFixedPriceTest.java A src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceByPercentTest.java M src-db/database/model/tables/OBDSCAL_SCALE.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_FIELD.xml M src-test/org/openbravo/discounts/scaledprice/test/base/model/PriceScale.java M src-test/org/openbravo/discounts/scaledprice/test/base/model/definition/ScaledPrice.java M src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountsUnitTestSuite.java M src/org/openbravo/retail/discounts/scaledprice/ScaledPriceProperties.java M web/org.openbravo.retail.discounts.scaledprice/app/model/business-logic/discounts-engine/engine/rules/scaled-price-discount.js --- |
|
(0168389) hgbot (developer) 2024-08-23 09:21 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^] Changeset: 5fad9d1beb5dd2c24ed0f3d008e4f91fb5cfd304 Author: Inigo Fernandez <inigo.fernandez@openbravo.com> Date: 23-08-2024 09:18:58 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/5fad9d1beb5dd2c24ed0f3d008e4f91fb5cfd304 [^] Related to ISSUE-55932: Synchronized terminology --- M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_FIELD.xml --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-07-05 16:39 | rqueralta | New Issue | |
| 2024-07-05 16:39 | rqueralta | Assigned To | => Retail |
| 2024-07-05 16:39 | rqueralta | Triggers an Emergency Pack | => No |
| 2024-07-05 16:39 | rqueralta | Assigned To | Retail => rqueralta |
| 2024-07-05 16:40 | rqueralta | Status | new => scheduled |
| 2024-07-17 15:40 | hgbot | Note Added: 0167071 | |
| 2024-08-22 11:48 | hgbot | Note Added: 0168356 | |
| 2024-08-22 11:48 | hgbot | Note Added: 0168357 | |
| 2024-08-22 11:48 | hgbot | Resolution | open => fixed |
| 2024-08-22 11:48 | hgbot | Status | scheduled => closed |
| 2024-08-22 11:48 | hgbot | Note Added: 0168358 | |
| 2024-08-22 11:48 | hgbot | Note Added: 0168359 | |
| 2024-08-22 11:48 | hgbot | Note Added: 0168360 | |
| 2024-08-22 11:48 | hgbot | Note Added: 0168361 | |
| 2024-08-22 11:48 | hgbot | Note Added: 0168362 | |
| 2024-08-22 11:48 | hgbot | Note Added: 0168363 | |
| 2024-08-22 11:48 | hgbot | Note Added: 0168364 | |
| 2024-08-22 11:48 | hgbot | Note Added: 0168365 | |
| 2024-08-22 11:48 | hgbot | Note Added: 0168366 | |
| 2024-08-22 11:48 | hgbot | Note Added: 0168367 | |
| 2024-08-23 09:21 | hgbot | Note Added: 0168389 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |