0055273: It is not possible to purposely set null values on the onPropertyValueChange function

Description

For customer and customer addresses objects, setting a null value is currently not possible.
There is a function called 'onPropertyValueChange' in which you can tell which field and with what value to be set. The problem is that if a null value wants to be set in the object, the code executed by the 'setValueFormFields' will prevent it from happening due to a condition in which it is stated that if the property does not have a value, the field's value will be chosen. This causes the impossibility of setting a null value on the properties on purpose.

Steps To Reproduce

Proposed Solution

It should be discussed a better way of fixing the problem that this condition fixes:

" if (field?.value && !property.value) {
valueToBeUsed = field?.value;
}"

This is the condition that is the one that makes it not possible to set null values in the property values.
It was implemented to fix other issue and works fine for it, but we should discuss a better way of handling it so both functionalities work without stepping in the way of the other.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0163526) NaroaIriarte (developer) 2024-04-22 13:12	This is the issue that introduced the if condition that is causing the impossibility of setting null values on the property values: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f2bca7ffe5dffdd1f210092ba72c2a755a52281a [^]

Issue History
Date Modified	Username	Field	Change
2024-04-22 11:34	NaroaIriarte	New Issue
2024-04-22 11:34	NaroaIriarte	Assigned To	=> NaroaIriarte
2024-04-22 11:34	NaroaIriarte	Triggers an Emergency Pack	=> No
2024-04-22 13:12	NaroaIriarte	Note Added: 0163526