Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0055120
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Retail APImajoralways2024-04-08 11:142024-04-19 08:13
ReportergorkaionView Statuspublic 
Assigned ToRajesh_18 
PriorityhighResolutionfixedFixed in VersionRR24Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0055120: Consume Coupons API returns a 500 error when the coupon is consumed

DescriptionWhen the Coupons API is called with a coupon that it is already consumed the response has 500 status. The expected result is a 2XX status with an error message since the call has not fail technically.
Steps To Reproduce1. Create a coupon in backend for a single use.
2. Check using the API that the coupon code is available using /org.openbravo.api.ExportService/Coupon/byCouponCode
3. Consume the coupon using /ws/org.openbravo.retail.discounts.coupons.api.ConsumeCoupon the response is 2XX
4. Check again the coupon and notice the coupon is already used.
5. Try to consume again the coupon using the ConsumeCoupon api, notice that the response is a 500 error. This is wrong, status should be 2XX with a message indicating that the coupon is already expired/consumed/...
Proposed Solutionchange the response status to 2XX
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0055258RR24Q2 closedRajesh_18 Consume Coupons API returns a 500 error when the coupon is consumed 
related to defect 0055121 closedRajesh_18 Consume GiftCards API returns a 500 error when the coupon is consumed 

-  Notes
(0163259)
hgbot (developer)
2024-04-16 11:23

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/257 [^]
(0163273)
hgbot (developer)
2024-04-16 12:19

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api/-/merge_requests/15 [^]
(0163274)
hgbot (developer)
2024-04-16 12:20

 Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/257 [^]
(0163373)
hgbot (developer)
2024-04-18 13:23

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api [^]
Changeset: 8e1f335fd6b7944916c5b056fad4f6f8e6d55ef3
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 16-04-2024 15:36:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api/-/commit/8e1f335fd6b7944916c5b056fad4f6f8e6d55ef3 [^]

Fixed ISSUE-55120: Catched OBException and returned the response status as 200

---
M src/org/openbravo/retail/discounts/coupons/api/service/ConsumeCoupon.java
---
(0163374)
hgbot (developer)
2024-04-18 13:23

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.api/-/merge_requests/15 [^]

- Issue History
Date Modified Username Field Change
2024-04-08 11:14 gorkaion New Issue
2024-04-08 11:14 gorkaion Assigned To => Triage Platform Conn
2024-04-08 11:14 gorkaion Triggers an Emergency Pack => No
2024-04-08 11:19 gorkaion Issue cloned 0055121
2024-04-08 11:19 gorkaion Relationship added related to 0055121
2024-04-08 11:20 gorkaion Assigned To Triage Platform Conn => Retail
2024-04-08 11:23 marvintm Status new => acknowledged
2024-04-11 08:21 Rajesh_18 Assigned To Retail => Rajesh_18
2024-04-11 08:21 Rajesh_18 Status acknowledged => scheduled
2024-04-16 11:23 hgbot Note Added: 0163259
2024-04-16 12:19 hgbot Note Added: 0163273
2024-04-16 12:20 hgbot Note Added: 0163274
2024-04-18 13:23 hgbot Resolution open => fixed
2024-04-18 13:23 hgbot Status scheduled => closed
2024-04-18 13:23 hgbot Note Added: 0163373
2024-04-18 13:23 hgbot Note Added: 0163374
2024-04-19 08:12 marvintm Status closed => new
2024-04-19 08:12 marvintm Resolution fixed => open
2024-04-19 08:12 marvintm Status new => scheduled
2024-04-19 08:12 marvintm Status scheduled => resolved
2024-04-19 08:12 marvintm Fixed in Version => RR24Q3
2024-04-19 08:12 marvintm Resolution open => fixed
2024-04-19 08:13 marvintm Review Assigned To => marvintm
2024-04-19 08:13 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker