Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0053494 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] Core | major | have not tried | 2023-09-19 15:01 | 2023-09-21 17:53 | |||
| Reporter | jarmendariz | View Status | public | |||||
| Assigned To | jarmendariz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0053494: Styling constants are missing in Popovers in Storybook | |||||||
| Description | As Popovers are rendered outside of the scope of the <div class="obc2ThemeProvider"> where the stories are wrapped, styling constants like obc2-color-* are missing and break the intended styling of those componentes. See attached screenshot as an example | |||||||
| Steps To Reproduce | In Storybook, open any ComboBox story and click to open its options. Notice that no style are applied at all. | |||||||
| Proposed Solution | Add style "obc2ThemeProvider darkTheme" to the <body> element instead of a <div> | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Screenshot from 2023-09-19 12-12-17.png [^] (95,018 bytes) 2023-09-19 15:01
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0154998) hgbot (developer) 2023-09-19 15:21 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1249 [^] |
|
(0155111) hgbot (developer) 2023-09-21 17:53 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1249 [^] |
|
(0155112) hgbot (developer) 2023-09-21 17:53 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 413f9737ce4e8e02c7f1537d3ace07b684f84b87 Author: Javier Armendáriz <javier.armendariz@openbravo.com> Date: 21-09-2023 16:25:52 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/413f9737ce4e8e02c7f1537d3ace07b684f84b87 [^] Fixed ISSUE-53494: Theme style in Storybook is placed in <body> element instead of a <div> --- M web-jspack/org.openbravo.core2/.storybook/preview.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-09-19 15:01 | jarmendariz | New Issue | |
| 2023-09-19 15:01 | jarmendariz | Assigned To | => Triage Platform Base |
| 2023-09-19 15:01 | jarmendariz | File Added: Screenshot from 2023-09-19 12-12-17.png | |
| 2023-09-19 15:01 | jarmendariz | OBNetwork customer | => No |
| 2023-09-19 15:01 | jarmendariz | Triggers an Emergency Pack | => No |
| 2023-09-19 15:02 | jarmendariz | Assigned To | Triage Platform Base => jarmendariz |
| 2023-09-19 15:02 | jarmendariz | Status | new => scheduled |
| 2023-09-19 15:21 | hgbot | Merge Request Status | => open |
| 2023-09-19 15:21 | hgbot | Note Added: 0154998 | |
| 2023-09-21 17:52 | hgbot | Merge Request Status | open => approved |
| 2023-09-21 17:53 | hgbot | Resolution | open => fixed |
| 2023-09-21 17:53 | hgbot | Status | scheduled => closed |
| 2023-09-21 17:53 | hgbot | Note Added: 0155111 | |
| 2023-09-21 17:53 | hgbot | Fixed in Version | => 23Q4 |
| 2023-09-21 17:53 | hgbot | Note Added: 0155112 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |