Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0052923

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[POS2] POS

major

always

2023-07-05 07:00

2023-08-18 08:35

Reporter

sreehari

View Status

public

Assigned To

Rajesh_18

Priority

normal

Resolution

fixed

Fixed in Version

23Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

No

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0052923: No Validation for line Discounts when modifying discount percentage

Description

When applying a discount for a line product, and trying to modify the discount % or the discount amount, it gets applied whatever the value is.

Attaching a video link FYR : https://drive.google.com/file/d/1xHhmvjSjomlDUT2WS69rLebaa3BTXuN7/view?usp=sharing [^]

Steps To Reproduce

1. Add some products to the ticket
2. Click on the product line to apply the discount
3. Select any available variable discount & try to modify the discount % or the discount amount
4. The maximum discount gets applied even if its greater than 100%, also in case of amount it gets applied even if the discounted amount is more than the value of the product.

Proposed Solution

There should be validation to check for discount percentage greater than 0% and less than or equal to 100%.

Also, in case of variable amount, there should be validation to check for the product price & discount price

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of	defect	0050739		scheduled	Rajesh_18	Discount is not properly applied when user defined discount is applied
related to	defect	0053027		closed	Rajesh_18	[23Q3] Receipt Properties button is not shown in a Return order

Notes
(0153439) hgbot (developer) 2023-08-11 08:29	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2009 [^]

(0153644) hgbot (developer) 2023-08-18 08:35	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 161b0c9c2317e23dd7833750759d6187e9ca7463 Author: Rajesh Senthilkumar <rajesh@qualiantech.com> Date: 18-08-2023 06:35:17 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/161b0c9c2317e23dd7833750759d6187e9ca7463 [^] Fixes ISSUE-52923: Validation for line Discounts when modifying discount. Discounts greater than 100% will not be possible to be applied. --- M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/ButtonBar1-DraftReturn.config.json M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/ApplyDiscountButton/ApplyDiscountButton.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountInputAmountCell/DiscountInputAmountCell.jsx ---

(0153645) hgbot (developer) 2023-08-18 08:35	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2009 [^]

Issue History
Date Modified	Username	Field	Change
2023-07-05 07:00	sreehari	New Issue
2023-07-05 07:00	sreehari	Assigned To	=> Retail
2023-07-05 07:00	sreehari	OBNetwork customer	=> No
2023-07-05 07:00	sreehari	Triggers an Emergency Pack	=> No
2023-08-10 08:21	Rajesh_18	Assigned To	Retail => Rajesh_18
2023-08-10 08:22	Rajesh_18	Status	new => scheduled
2023-08-11 08:29	hgbot	Merge Request Status	=> open
2023-08-11 08:29	hgbot	Note Added: 0153439
2023-08-18 08:33	hgbot	Merge Request Status	open => approved
2023-08-18 08:34	hgbot	Merge Request Status	approved => open
2023-08-18 08:34	hgbot	Merge Request Status	open => approved
2023-08-18 08:35	hgbot	Resolution	open => fixed
2023-08-18 08:35	hgbot	Status	scheduled => closed
2023-08-18 08:35	hgbot	Fixed in Version	=> 23Q4
2023-08-18 08:35	hgbot	Note Added: 0153644
2023-08-18 08:35	hgbot	Note Added: 0153645
2023-08-31 14:37	Rajesh_18	Relationship added	duplicate of 0050739
2023-09-05 13:10	sreehari	Relationship added	related to 0053027

Copyright © 2000 - 2009 MantisBT Group