Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||||||
| ID | ||||||||||||
| 0051095 | ||||||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||||||
| defect | [POS2] Core | minor | have not tried | 2022-12-12 10:20 | 2022-12-12 10:20 | |||||||
| Reporter | alostale | View Status | public | |||||||||
| Assigned To | Triage Platform Base | |||||||||||
| Priority | normal | Resolution | open | Fixed in Version | ||||||||
| Status | new | Fix in branch | Fixed in SCM revision | |||||||||
| Projection | none | ETA | none | Target Version | ||||||||
| OS | Any | Database | Any | Java version | ||||||||
| OS Version | Database version | Ant version | ||||||||||
| Product Version | SCM revision | |||||||||||
| Merge Request Status | ||||||||||||
| Review Assigned To | ||||||||||||
| OBNetwork customer | No | |||||||||||
| Support ticket | ||||||||||||
| Regression level | ||||||||||||
| Regression date | ||||||||||||
| Regression introduced in release | ||||||||||||
| Regression introduced by commit | ||||||||||||
| Triggers an Emergency Pack | No | |||||||||||
| Summary | 0051095: OB.App.State.TerminalLog.addLog does not check preferences to send log | |||||||||||
| Description | There are 2 client APIs to handle client logs: 1. OB.* (OB.error, OB.warn, OB.info...): it checks whether the log should be printed in console and/or sent to backend as terminal log 2. OB.App.State.TerminalLog.addLog: it sends the message to the backend as terminal log without further checks The second option is a lower level API that should not be directly used by business logic code, but there are already some parts where it is used. | |||||||||||
| Steps To Reproduce | N/A: this issue is technical related to code APIs. | |||||||||||
| Proposed Solution | Decide whether OB.App.State.TerminalLog.addLog should be usable from business logic code. Options: 1. Keep it as low level: * Review current usage from business logic code and change it to OB.* * Document in JSDoc it is a low level API so it shouldn't be used 2. Open it up to be usable from business logic code * As action preparation (?) check whether the message should be actually sent. Note this would double the checks that are already being executed in OB.*. The save parts might be moved to be executed only here. | |||||||||||
| Tags | No tags attached. | |||||||||||
| Attached Files | ||||||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
| There are no notes attached to this issue. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-12-12 10:20 | alostale | New Issue | |
| 2022-12-12 10:20 | alostale | Assigned To | => Triage Platform Base |
| 2022-12-12 10:20 | alostale | OBNetwork customer | => No |
| 2022-12-12 10:20 | alostale | Triggers an Emergency Pack | => No |
| 2022-12-12 10:20 | alostale | Relationship added | related to 0050505 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |