Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0049629
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2022-06-22 15:592022-07-26 15:22
ReporterXABIER_AGUADOView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049629: Performance Issue in Inventory Count when loading all Products in parameters

DescriptionIn the FE, in the parameters window of the Inventory Count, in the Product parameter, without filters it loads all the products creating a performance problem.

Video: https://watch.screencastify.com/v/SAlDovn7A9VCNLy371Y3 [^]
Steps To Reproduce1. Log in as Openbravo in AWO-QA Admin client
  (To do so, log in as Openbravo in the BackOffice first and change the Role to AWO-QA Admin and the Warehouse to US West Coast and set as default, then log in in the AWO Front End)
 
2. Click on Count menu entry
   Then click on Select Stock button

3. Open the Product parameter (by clicking on the magnifying glass) and filter by 'ale'
   Some products are shown
   
4. Remove the filter
   All the available products are shown
   This creates peformance problems in clients with lots of products
Proposed SolutionLimit the number of products that the system retrieves without filter or do not allow to show a list of products without filtering it first
TagsFASH
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0049559 closedTriage Omni WMS Openbravo ERP Performance for product selection filter is KO with high volume of data in Inventory Count AWO 
related to design defect 0047336 newTriage Omni WMS Modules in an environment with a lot of data the search in AWO does not work 

-  Notes
(0139334)
mtaal (manager)
2022-07-14 15:14

 Hello,
Why is the 49559 a design defect and this one is not a design defect?

Other question, what is a meaningfull/usefull number of products to show when no filter is given? (can be zero, or a 100 or so). If we limit to 100 does it even make sense?

Other question, request to move the due date to second week of august. Due to holidays we are resource constrained. Let me know how critical it is.

grt. Martin
(0139382)
hgbot (developer)
2022-07-18 12:45

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/61 [^]
(0139383)
AtulOpenbravo (developer)
2022-07-18 12:48
edited on: 2022-07-18 12:56

 Test Plan

Make sure that Preference "Minimum search input length for Entity Selectors" is enabled with value for eg: 3

1. Log in as Openbravo in AWO-QA Admin client
  (To do so, log in as Openbravo in the BackOffice first and change the Role to AWO-QA Admin and the Warehouse to US West Coast and set as default, then log in in the AWO Front End)

2. Click on Count menu entry
   Then click on Select Stock button

3. Open the Product parameter (by clicking on the magnifying glass) and filter by 'ale'. Realize that Some products are shown
   
4. Remove the filter. Realize that products are not loaded or search button is not enabled unless 3 characters are entered for searching the product.
(0139397)
hgbot (developer)
2022-07-18 20:11

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/385 [^]
(0139483)
hgbot (developer)
2022-07-21 14:27

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 977198832b01bcbeb670cd51c23a397dc335475b
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 21-07-2022 12:27:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/977198832b01bcbeb670cd51c23a397dc335475b [^]

Related to BUG-0049629:Performance Issue in Inventory Count when
loading all Products in parameters

**When clearing the filters check whether minimum search character
preference is set or not, if yes then disable the search button
and clear the filtered item list.

---
M web/org.openbravo.mobile.core/source/component/ob-multientity-selector.js
---
(0139484)
hgbot (developer)
2022-07-21 14:27

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/385 [^]
(0139485)
hgbot (developer)
2022-07-21 14:28

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 892e37f2c47d10f6f7e4bd560cfc4c8d43ed9e60
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 18-07-2022 16:12:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/892e37f2c47d10f6f7e4bd560cfc4c8d43ed9e60 [^]

Fixes BUG-0049629:Performance Issue in Inventory Count when
loading all Products in parameters

**Minumum search characters preference is used for product
filter selector inorder to load products. By default it is
3 characters.

---
M web/org.openbravo.warehouse.advancedwarehouseoperations/source/components/obawo-productfilter-selector.js
---
(0139486)
hgbot (developer)
2022-07-21 14:28

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 1b52833c7dbb27298d02e5145e57653df3781734
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 19-07-2022 23:41:26
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/1b52833c7dbb27298d02e5145e57653df3781734 [^]

Related to ISSUE-0049629:Performance Issue in Inventory Count when
loading all Products in parameters

**Set default value of property searchMinCharsPreference as
OBMOBC_MinCharsForEntitySelector in OB.UI.MultipleEntitySelector
component
**Remove property searchMinCharsPreference with value '' from
all components that extends OB.UI.MultipleEntitySelector

---
M web/org.openbravo.warehouse.advancedwarehouseoperations/source/components/obawo-irafilter-selector.js
M web/org.openbravo.warehouse.advancedwarehouseoperations/source/components/obawo-locatorfilter-selector.js
M web/org.openbravo.warehouse.advancedwarehouseoperations/source/components/obawo-productcategfilter-selector.js
M web/org.openbravo.warehouse.advancedwarehouseoperations/source/components/obawo-productfilter-selector.js
M web/org.openbravo.warehouse.advancedwarehouseoperations/source/components/obawo-refinvfilter-selector.js
M web/org.openbravo.warehouse.advancedwarehouseoperations/source/components/obawo-sbgfilter-selector.js
M web/org.openbravo.warehouse.advancedwarehouseoperations/source/inventorycount/components/obawo-productselector.js
---
(0139487)
hgbot (developer)
2022-07-21 14:28

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/61 [^]
(0139614)
hgbot (developer)
2022-07-26 15:22

 Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: b6937949d1a40a8d57bf9ff48777118a1485411e
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 26-07-2022 18:49:50
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/b6937949d1a40a8d57bf9ff48777118a1485411e [^]

Related to BUG-0049629: Performance Issue in Inventory Count
when loading all Products in parameters

**Fix tests using search button that is disabled by default
as preference for min chars for entity selector is enabled
in System client with value 3, inorder to keep the search
button enable, add same preference with 0 value and remove
it after the test is executed. After entering search text,
data loading does not takes place in the tests so search
button click is important.

---
M src-test/org/openbravo/test/mobile/awo/tests/Count/I48752_CountProductInDifferentBins.java
M src-test/org/openbravo/test/mobile/awo/tests/Count/ICI010_BasicCount.java
M src-test/org/openbravo/test/mobile/awo/tests/Count/ICI030_BlindCount.java
M src-test/org/openbravo/test/mobile/awo/tests/Count/ICI040_SharedCount.java
M src-test/org/openbravo/test/mobile/awo/tests/Count/ICI050_Shared_With_Recount.java
M src-test/org/openbravo/test/mobile/awo/tests/Count/ICI060_PlannedCount.java
---

- Issue History
Date Modified Username Field Change
2022-06-22 15:59 XABIER_AGUADO New Issue
2022-06-22 15:59 XABIER_AGUADO Assigned To => Retail
2022-06-22 15:59 XABIER_AGUADO Triggers an Emergency Pack => No
2022-06-22 16:12 rafaroda Tag Attached: FASH
2022-06-22 16:12 rafaroda Relationship added related to 0049559
2022-06-22 16:12 rafaroda Relationship added related to 0047336
2022-06-23 12:59 marvintm Assigned To Retail => Triage Omni WMS
2022-07-14 15:14 mtaal Note Added: 0139334
2022-07-14 15:14 mtaal Status new => feedback
2022-07-18 12:30 AtulOpenbravo Status feedback => scheduled
2022-07-18 12:30 AtulOpenbravo Assigned To Triage Omni WMS => AtulOpenbravo
2022-07-18 12:45 hgbot Note Added: 0139382
2022-07-18 12:48 AtulOpenbravo Note Added: 0139383
2022-07-18 12:54 AtulOpenbravo Note Edited: 0139383 View Revisions
2022-07-18 12:56 AtulOpenbravo Note Edited: 0139383 View Revisions
2022-07-18 20:11 hgbot Note Added: 0139397
2022-07-21 14:27 hgbot Note Added: 0139483
2022-07-21 14:27 hgbot Note Added: 0139484
2022-07-21 14:28 hgbot Resolution open => fixed
2022-07-21 14:28 hgbot Status scheduled => closed
2022-07-21 14:28 hgbot Note Added: 0139485
2022-07-21 14:28 hgbot Note Added: 0139486
2022-07-21 14:28 hgbot Note Added: 0139487
2022-07-26 15:22 hgbot Note Added: 0139614

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker