Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049265 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | minor | have not tried | 2022-04-08 11:19 | 2022-05-31 10:31 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | meriem_azaf | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR22Q1.3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | PR22Q1.3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049265: remove obsolete Translation Required field from Module window | |||||||
| Description | Translation required field is present in Module window, it is never used so it could be removed. Together with it there is a validation to ensure modules with "UI artifacts" mark this flag. This validation should also be removed as it provides no value. | |||||||
| Steps To Reproduce | 1. Create a module with the Translation Required flag unchecked 2. Create a new window for that module 3. Run validations -> It complains about that module not being marked as translation required | |||||||
| Proposed Solution | 1. Remove the field from Module window 2. Remove checkUIArtifacts from ModuleValidator [1] 3. Deprecate the column in AD We'll keep the column to prevent a formal change when exporting every module [1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/service/system/ModuleValidator.java#L186 [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0137854) hgbot (developer) 2022-05-30 13:23 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/607 [^] |
|
(0137871) hgbot (developer) 2022-05-31 10:30 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 3660ce61d374a9be7fb9d1da281a4c72364dfdbf Author: Meriem Azaf <meriem.azaf@openbravo.com> Date: 30-05-2022 13:21:07 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/3660ce61d374a9be7fb9d1da281a4c72364dfdbf [^] Fixes ISSUE-49265: Remove obsolete Translation Required field from Module window The problem that creating a new module with the translation required flag unchecked and create also a new window for that module after running the validatio it complains about that module not being marked as translation required. To fix this, we removed the field translation required from Module window and also the function checkUIArtifacts from ModuleValidator. we deprecated the column in AD. --- M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_FIELD.xml M src/org/openbravo/erpCommon/ad_process/CreateCustomModule.java M src/org/openbravo/service/system/ModuleValidator.java --- |
|
(0137872) hgbot (developer) 2022-05-31 10:30 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/607 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-05-09 13:04 | AugustoMauch | Type | defect => backport |
| 2022-05-09 13:04 | AugustoMauch | Target Version | PR22Q3 => PR22Q1.3 |
| 2022-05-30 13:23 | hgbot | Note Added: 0137854 | |
| 2022-05-31 10:30 | hgbot | Resolution | open => fixed |
| 2022-05-31 10:30 | hgbot | Status | scheduled => closed |
| 2022-05-31 10:30 | hgbot | Fixed in Version | => PR22Q1.3 |
| 2022-05-31 10:30 | hgbot | Note Added: 0137871 | |
| 2022-05-31 10:30 | hgbot | Note Added: 0137872 | |
| 2022-05-31 10:31 | cberner | Fixed in SCM revision | asdf => |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |