Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0049011
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2022-04-08 11:192022-05-31 10:31
ReporteralostaleView Statuspublic 
Assigned Tomeriem_azaf 
PrioritynormalResolutionfixedFixed in VersionPR22Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionPR22Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049011: remove obsolete Translation Required field from Module window

DescriptionTranslation required field is present in Module window, it is never used so it could be removed.

Together with it there is a validation to ensure modules with "UI artifacts" mark this flag. This validation should also be removed as it provides no value.
Steps To Reproduce1. Create a module with the Translation Required flag unchecked
2. Create a new window for that module
3. Run validations
  -> It complains about that module not being marked as translation required
Proposed Solution1. Remove the field from Module window
2. Remove checkUIArtifacts from ModuleValidator [1]
3. Deprecate the column in AD
   We'll keep the column to prevent a formal change when exporting every module


[1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/service/system/ModuleValidator.java#L186 [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0049264PR22Q2.1 closedmeriem_azaf remove obsolete Translation Required field from Module window 
depends on backport 0049265PR22Q1.3 closedmeriem_azaf remove obsolete Translation Required field from Module window 
blocks design defect 0032688 acknowledgedTriage Platform Base remove unused resources 
causes defect 0049413 closedmeriem_azaf API Change: Removed Translation Required field from Module window 

-  Notes
(0137268)
hgbot (developer)
2022-05-13 14:08

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/597 [^]
(0137752)
hgbot (developer)
2022-05-26 11:04

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 6932031f8f077c3eef28cc6fdafccc8f7b6744a1
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 26-05-2022 10:53:38
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6932031f8f077c3eef28cc6fdafccc8f7b6744a1 [^]

Fixes ISSUE-49011: Remove obsolete Translation Required field from Module window

The problem that creating a new module with the translation required flag unchecked and create also a new window for that module after running the validatio it complains about that module not being marked as translation required.

To fix this, we removed the field translation required from Module window and also the function checkUIArtifacts from ModuleValidator. we deprecated the column in AD.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/erpCommon/ad_process/CreateCustomModule.java
M src/org/openbravo/service/system/ModuleValidator.java
---
(0137753)
hgbot (developer)
2022-05-26 11:04

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/597 [^]

- Issue History
Date Modified Username Field Change
2022-04-08 11:19 alostale New Issue
2022-04-08 11:19 alostale Assigned To => Triage Platform Base
2022-04-08 11:19 alostale Modules => Core
2022-04-08 11:19 alostale Triggers an Emergency Pack => No
2022-04-08 11:20 alostale Target Version => PR22Q3
2022-04-08 11:29 alostale Relationship added blocks 0032688
2022-04-11 12:48 AugustoMauch Assigned To Triage Platform Base => meriem_azaf
2022-04-11 12:48 AugustoMauch Status new => scheduled
2022-05-09 13:03 AugustoMauch Status scheduled => resolved
2022-05-09 13:03 AugustoMauch Fixed in SCM revision => asdf
2022-05-09 13:03 AugustoMauch Resolution open => fixed
2022-05-09 13:03 AugustoMauch Status resolved => new
2022-05-09 13:03 AugustoMauch Resolution fixed => open
2022-05-09 13:04 AugustoMauch Status new => scheduled
2022-05-13 14:08 hgbot Note Added: 0137268
2022-05-25 14:07 meriem_azaf Relationship added causes 0049413
2022-05-26 11:04 hgbot Resolution open => fixed
2022-05-26 11:04 hgbot Status scheduled => closed
2022-05-26 11:04 hgbot Fixed in Version => PR22Q3
2022-05-26 11:04 hgbot Note Added: 0137752
2022-05-26 11:04 hgbot Note Added: 0137753
2022-05-31 10:31 cberner Fixed in SCM revision asdf =>


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker