Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0047044 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
design defect | [POS2] Core | minor | have not tried | 2021-06-09 14:57 | 2022-05-13 02:09 | |||
Reporter | timothee_catteeuw | View Status | public | |||||
Assigned To | AtulOpenbravo | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0047044: JIRA 1981 - avoir - popup after cancelling a ticket not needed | |||||||
Description | A pop-up is not needed when paying use case : - do a ticket and then go to payment screen - select as payment method credit note - Close the without tipping anything, a message error id displayed and requires an additional validation → this message is useless → I think the better approach is to put a message at the bottom left so that the process is not blocked like in my screenshot. | |||||||
Steps To Reproduce | - do a ticket and then go to payment screen - select as payment method credit note - Close the without tipping anything, a message error id displayed | |||||||
Tags | No tags attached. | |||||||
Attached Files | image-2021-05-28-12-42-28-808.png [^] (53,620 bytes) 2021-06-09 14:57
image-2021-05-28-12-42-01-588.png [^] (40,482 bytes) 2021-06-09 14:57 | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0130990) hernan-dp (reporter) 2021-08-05 15:15 |
Debugged the issue. PaymentProvider dialog is always rendered behind gift card dialog, catches the error in processPayment.js, Couldn't find a way to close the payment provider dialog without it closing for every instance of error there was not only when close button is applied. |
(0131008) dmiguelez (developer) 2021-08-06 10:57 |
Seems that it is necessary to change the API behind to add another option to show or not the error message. This issue has been updated as a Design defect |
(0137236) AtulOpenbravo (developer) 2022-05-12 19:29 |
Test Plan - Create a ticket, add one or more products, then go to payment screen - select as payment method credit note - Close the without typing anything - Realize that Dialog is closed successfully without any other confirmation popup. |
(0137237) hgbot (developer) 2022-05-12 19:40 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/116 [^] |
(0137246) hgbot (developer) 2022-05-13 02:09 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: 4b0f55c87a71ebae4cb48a3d1833a20fac513adc Author: Atul Gaware <atul.gaware@openbravo.com> Date: 13-05-2022 00:08:24 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/4b0f55c87a71ebae4cb48a3d1833a20fac513adc [^] Fixed BUG-0047044: JIRA 1981 - avoir - popup after cancelling a ticket not needed When throwing a eror when gift card is not selected add property showPopMessage as false to the error object along with message. --- M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GiftCardPaymentProvider.jsx --- |
(0137247) hgbot (developer) 2022-05-13 02:09 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/116 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2021-06-09 14:57 | timothee_catteeuw | New Issue | |
2021-06-09 14:57 | timothee_catteeuw | Assigned To | => Retail |
2021-06-09 14:57 | timothee_catteeuw | File Added: image-2021-05-28-12-42-28-808.png | |
2021-06-09 14:57 | timothee_catteeuw | Triggers an Emergency Pack | => No |
2021-06-09 14:57 | timothee_catteeuw | File Added: image-2021-05-28-12-42-01-588.png | |
2021-06-10 11:47 | dmiguelez | Status | new => acknowledged |
2021-06-10 11:47 | dmiguelez | Resolution time | => 1625695200 |
2021-06-10 11:47 | dmiguelez | Type | design defect => defect |
2021-06-14 11:34 | guilleaer | Target Version | TAP => |
2021-07-14 17:17 | dmiguelez | Resolution time | 1625695200 => 1628892000 |
2021-07-27 15:55 | dmiguelez | Assigned To | Retail => hernan-dp |
2021-08-05 15:15 | hernan-dp | Note Added: 0130990 | |
2021-08-06 10:57 | dmiguelez | Note Added: 0131008 | |
2021-08-06 10:57 | dmiguelez | Type | defect => design defect |
2021-08-06 10:58 | dmiguelez | Assigned To | hernan-dp => Retail |
2022-04-25 22:34 | mtaal | Assigned To | Retail => mtaal |
2022-05-12 19:29 | AtulOpenbravo | Status | acknowledged => scheduled |
2022-05-12 19:29 | AtulOpenbravo | Note Added: 0137236 | |
2022-05-12 19:29 | AtulOpenbravo | Assigned To | mtaal => AtulOpenbravo |
2022-05-12 19:40 | hgbot | Note Added: 0137237 | |
2022-05-13 02:09 | hgbot | Resolution | open => fixed |
2022-05-13 02:09 | hgbot | Status | scheduled => closed |
2022-05-13 02:09 | hgbot | Note Added: 0137246 | |
2022-05-13 02:09 | hgbot | Note Added: 0137247 |
Copyright © 2000 - 2009 MantisBT Group |