Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0046579 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | minor | have not tried | 2021-05-07 11:30 | 2021-05-17 10:15 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR21Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | PR21Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0046579: junit DataSourceSecurity.fetchShouldBeAllowedOnlyIfRoleIsGranted fails on Tomcat9 (only for Datasource: AccountTreeMovement) | |||||||
| Description | This junit test fails when application is deployed on tomcat 9.x but only for the specific datasource AccountTreeMovement. It shows 4 failures as four RoleTypes are tested for each dataSource. Problem is the test triggering the following error on tomcat 9.x: May 05 12:27:36 ip-172-31-9-130 tomcat9[2709]: Error parsing HTTP request header May 05 12:27:36 ip-172-31-9-130 tomcat9[2709]: Note: further occurrences of HTTP request parsing errors will be logged at DEBUG level. May 05 12:27:36 ip-172-31-9-130 tomcat9[2709]: java.lang.IllegalArgumentException: Invalid character found in the request target. The valid characters are defined in RFC 7230 and RFC 3986 | |||||||
| Steps To Reproduce | Deploy application with tomcat 9.x ant run.test -Dtest=org.openbravo.test.datasource.DataSourceSecurity Check result*.xml file in src/ folder for the result of the test run | |||||||
| Proposed Solution | Fix the invalid request target (values in url) to be valid. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0128170) hgbot (developer) 2021-05-17 08:10 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/364 [^] |
|
(0128200) hgbot (developer) 2021-05-17 10:15 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/364 [^] |
|
(0128201) hgbot (developer) 2021-05-17 10:15 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 7383d37dc6b338cc677c5a59fd790363bab2d442 Author: Asier Lostalé <asier.lostale@openbravo.com> Date: 2021-05-17T08:09:13+02:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/7383d37dc6b338cc677c5a59fd790363bab2d442 [^] fixes BUG-46579: DataSourceSecurity fails on Tomcat9 fetchShouldBeAllowedOnlyIfRoleIsGranted test was creating an invalid request by adding some parameters with special characters and not ecoding them. Tomcat 9 is stricter parsing URLs than previous version, not allowing this case. Fixed by removing those parameters that were causing problems as they were not ncessary. --- M src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-05-07 11:30 | alostale | New Issue | |
| 2021-05-07 11:30 | alostale | Assigned To | => alostale |
| 2021-05-07 11:30 | alostale | Modules | => Core |
| 2021-05-07 11:30 | alostale | Triggers an Emergency Pack | => No |
| 2021-05-07 11:30 | alostale | Issue generated from | 0046567 |
| 2021-05-07 11:30 | alostale | Relationship added | blocks 0046520 |
| 2021-05-07 11:31 | alostale | Status | new => scheduled |
| 2021-05-07 11:32 | alostale | Target Version | => PR21Q2 |
| 2021-05-17 08:10 | hgbot | Note Added: 0128170 | |
| 2021-05-17 10:15 | hgbot | Note Added: 0128200 | |
| 2021-05-17 10:15 | hgbot | Resolution | open => fixed |
| 2021-05-17 10:15 | hgbot | Status | scheduled => closed |
| 2021-05-17 10:15 | hgbot | Fixed in Version | => PR21Q2 |
| 2021-05-17 10:15 | hgbot | Note Added: 0128201 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |