Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043458
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-03-09 13:472020-03-11 18:51
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision18f65bdd0309
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043458: Apply new HQL Style in ResetValuedStockAggregated.java

DescriptionResetValuedStockAggregated.java has five HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0118456)
inigo_lerga (reporter)
2020-03-10 09:53

 --Test Plan Mantis HQL queries--
As the System Administrator role:
  - Go to the Menu window and search for "Reset Valued Stock Aggregate"
    window record. Open it and set the record as Active (You will need
    to set its Module as in Development).
Log out and Log in again.

As the F&B International Group Admin role:
  - Go to the Reset Valued Stock Aggregate window, select any organization
    in the Invoice Organization field and press the Done button.

  #In this moment the modified HQLs are executed#
(0118536)
hgbot (developer)
2020-03-11 18:50

 Repository: erp/devel/pi
Changeset: 18f65bdd0309754e7f94f4dc1dd5537bbb5b6bc9
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 10 10:00:05 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/18f65bdd0309754e7f94f4dc1dd5537bbb5b6bc9 [^]

fixes BUG-43458:Applied new HQL Style

---
M src/org/openbravo/materialmgmt/ResetValuedStockAggregated.java
---
(0118537)
hgbot (developer)
2020-03-11 18:50

 Repository: erp/devel/pi
Changeset: d4ce843d6f00d6db75ccd9f5f85a6e18e6dfa16b
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Mar 10 10:13:32 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d4ce843d6f00d6db75ccd9f5f85a6e18e6dfa16b [^]

related to ISSUE-43458: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied
-Small refactor in code

---
M src/org/openbravo/materialmgmt/ResetValuedStockAggregated.java
---
(0118538)
dmiguelez (developer)
2020-03-11 18:51

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-03-09 13:47 inigo_lerga New Issue
2020-03-09 13:47 inigo_lerga Assigned To => inigo_lerga
2020-03-09 13:47 inigo_lerga Modules => Core
2020-03-09 13:47 inigo_lerga Triggers an Emergency Pack => No
2020-03-09 13:52 inigo_lerga Relationship added related to 0041287
2020-03-09 13:52 inigo_lerga Status new => scheduled
2020-03-10 09:53 inigo_lerga Note Added: 0118456
2020-03-11 18:50 hgbot Checkin
2020-03-11 18:50 hgbot Note Added: 0118536
2020-03-11 18:50 hgbot Status scheduled => resolved
2020-03-11 18:50 hgbot Resolution open => fixed
2020-03-11 18:50 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/18f65bdd0309754e7f94f4dc1dd5537bbb5b6bc9 [^]
2020-03-11 18:50 hgbot Checkin
2020-03-11 18:50 hgbot Note Added: 0118537
2020-03-11 18:51 dmiguelez Review Assigned To => dmiguelez
2020-03-11 18:51 dmiguelez Note Added: 0118538
2020-03-11 18:51 dmiguelez Status resolved => closed
2020-03-11 18:51 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker