Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043453
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-03-09 11:272020-03-11 18:09
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision5220437cfead
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043453: Apply new HQL Style in ReservationUtils.java

DescriptionReservationUtils.java has two HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0118428)
inigo_lerga (viewer)
2020-03-09 16:23

 --Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Execute the ReferencedInventoryTestSuite.java file.

  #In this moment one of the modified HQLs is executed#

  - Go to the Warehouse and Storage Bins window and enter the
    "F&B España - Región Norte" record.
  - Select the "Rn-0-0-0" Storage Bin. Press the Change Status
    button and choose the "Bloqued" option in the Inventory Status
    selector.
(0118530)
hgbot (developer)
2020-03-11 18:08

 Repository: erp/devel/pi
Changeset: 5220437cfeadfb842c02644d49f7812ac94fe4c3
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Mar 09 16:42:28 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5220437cfeadfb842c02644d49f7812ac94fe4c3 [^]

fixes BUG-43453:Applied new HQL Style

---
M src/org/openbravo/materialmgmt/ReservationUtils.java
---
(0118531)
hgbot (developer)
2020-03-11 18:08

 Repository: erp/devel/pi
Changeset: 2c0e4eb6a5df289e642480cd2e710e1c77d76a93
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon Mar 09 16:44:05 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2c0e4eb6a5df289e642480cd2e710e1c77d76a93 [^]

related to ISSUE-43453: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

---
M src/org/openbravo/materialmgmt/ReservationUtils.java
---
(0118532)
hgbot (developer)
2020-03-11 18:08

 Repository: erp/devel/pi
Changeset: dfdffb7bcad7075c3b6e7bd3a4106e2a258e7e36
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Mar 11 18:08:40 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dfdffb7bcad7075c3b6e7bd3a4106e2a258e7e36 [^]

Related to ISSUE-43453. Code Review changes
* Adds removed throw exception to avoid possible API change

---
M src/org/openbravo/materialmgmt/ReservationUtils.java
---
(0118533)
dmiguelez (viewer)
2020-03-11 18:09

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-03-09 11:27 inigo_lerga New Issue
2020-03-09 11:27 inigo_lerga Assigned To => inigo_lerga
2020-03-09 11:27 inigo_lerga OBNetwork customer => No
2020-03-09 11:27 inigo_lerga Modules => Core
2020-03-09 11:27 inigo_lerga Triggers an Emergency Pack => No
2020-03-09 11:27 inigo_lerga Relationship added related to 0041287
2020-03-09 11:27 inigo_lerga Status new => scheduled
2020-03-09 16:23 inigo_lerga Note Added: 0118428
2020-03-11 18:08 hgbot Checkin
2020-03-11 18:08 hgbot Note Added: 0118530
2020-03-11 18:08 hgbot Status scheduled => resolved
2020-03-11 18:08 hgbot Resolution open => fixed
2020-03-11 18:08 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5220437cfeadfb842c02644d49f7812ac94fe4c3 [^]
2020-03-11 18:08 hgbot Checkin
2020-03-11 18:08 hgbot Note Added: 0118531
2020-03-11 18:08 hgbot Checkin
2020-03-11 18:08 hgbot Note Added: 0118532
2020-03-11 18:09 dmiguelez Review Assigned To => dmiguelez
2020-03-11 18:09 dmiguelez Note Added: 0118533
2020-03-11 18:09 dmiguelez Status resolved => closed
2020-03-11 18:09 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker