Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0043397 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2020-03-03 11:23 | 2020-03-06 14:42 | |||
| Reporter | inigo_lerga | View Status | public | |||||
| Assigned To | inigo_lerga | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR20Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 0c47875d6942 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | dmiguelez | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0043397: Apply new HQL Style in OrderEventHandler.java | |||||||
| Description | OrderEventHandler.java has one HQL query with: - the HQL is hard to read because of formatting - and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0118294) inigo_lerga (viewer) 2020-03-03 12:29 |
--Test Plan Mantis HQL queries-- As the F&B International Group Admin role: - Go to the Purchase Order window and create a new record. Select any Business Partner desired. Save the record. Now change the Business Partner to a different one ans save again. #In this moment the modified HQL is executed# |
|
(0118395) dmiguelez (viewer) 2020-03-06 14:41 |
Test Plan II Log in as F&B International Group Admin Go to Sales Order Window and create a new record with: * Organization: F&B España - Región Norte * Business Partner: Alimentos y Supermercados Navigate to Basic Discounts Tab and realize that there is one record with Descuento 10% Change the Business Partner of the Header to Restaurantes Luna Llena and save Navigate to Basic Discounts Tab and realize that there is only one record with Descuento 5% |
|
(0118396) hgbot (developer) 2020-03-06 14:41 |
Repository: erp/devel/pi Changeset: 0c47875d6942d77157a49ab8aac8390cdfb84a2c Author: Iñigo Lerga <inigo.lerga <at> openbravo.com> Date: Tue Mar 03 12:30:08 2020 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/0c47875d6942d77157a49ab8aac8390cdfb84a2c [^] fixes BUG-43397:Applied new HQL Style --- M src/org/openbravo/event/OrderEventHandler.java --- |
|
(0118397) hgbot (developer) 2020-03-06 14:41 |
Repository: erp/devel/pi Changeset: 8ace6f1061cc3bceea4611ffb706de2249e88006 Author: Iñigo Lerga <inigo.lerga <at> openbravo.com> Date: Tue Mar 03 12:43:14 2020 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/8ace6f1061cc3bceea4611ffb706de2249e88006 [^] related to ISSUE-43397: Finals added and code refactored -Finals added -Code refactored inside getOrderLines function. --- M src/org/openbravo/event/OrderEventHandler.java --- |
|
(0118398) dmiguelez (viewer) 2020-03-06 14:42 |
Code Review + Testing Ok |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-03-03 11:23 | inigo_lerga | New Issue | |
| 2020-03-03 11:23 | inigo_lerga | Assigned To | => inigo_lerga |
| 2020-03-03 11:23 | inigo_lerga | OBNetwork customer | => No |
| 2020-03-03 11:23 | inigo_lerga | Modules | => Core |
| 2020-03-03 11:23 | inigo_lerga | Triggers an Emergency Pack | => No |
| 2020-03-03 11:23 | inigo_lerga | Relationship added | related to 0041287 |
| 2020-03-03 11:23 | inigo_lerga | Status | new => scheduled |
| 2020-03-03 12:29 | inigo_lerga | Note Added: 0118294 | |
| 2020-03-06 14:41 | dmiguelez | Note Added: 0118395 | |
| 2020-03-06 14:41 | hgbot | Checkin | |
| 2020-03-06 14:41 | hgbot | Note Added: 0118396 | |
| 2020-03-06 14:41 | hgbot | Status | scheduled => resolved |
| 2020-03-06 14:41 | hgbot | Resolution | open => fixed |
| 2020-03-06 14:41 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/0c47875d6942d77157a49ab8aac8390cdfb84a2c [^] |
| 2020-03-06 14:41 | hgbot | Checkin | |
| 2020-03-06 14:41 | hgbot | Note Added: 0118397 | |
| 2020-03-06 14:42 | dmiguelez | Review Assigned To | => dmiguelez |
| 2020-03-06 14:42 | dmiguelez | Note Added: 0118398 | |
| 2020-03-06 14:42 | dmiguelez | Status | resolved => closed |
| 2020-03-06 14:42 | dmiguelez | Fixed in Version | => 3.0PR20Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |