Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043336
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-26 11:452020-03-06 12:29
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision6dd3ae016011
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043336: Apply new HQL Style in CancelAndReplaceUtils.java

DescriptionCancelAndReplaceUtils.java has two HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0118118)
inigo_lerga (viewer)
2020-02-26 12:43

 --Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
  - Go to the Preference window and create a new record with
    "Enable Cancel and Replace" as Property and Value "Y".
    Save, Log out and Log in again.
  - Go to the Sales Order window and create a new record with
    any Business Partner desired.
  - Go to the Lines Tab and create a new Line with any desired
    product and quantity.
  - Save the Sales Order record and Book it.
    Press now the Cancel and Replace Button and Done button in
    the popup window.
    Now Press the Confirm Cancel and Replace Button and Done
    button in the popup window.
    
    #In this moment the modified HQLs are executed#
(0118367)
hgbot (developer)
2020-03-06 12:28

 Repository: erp/devel/pi
Changeset: 6dd3ae016011882cf62c99d7bb5dee8386afa6e1
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 26 12:56:37 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6dd3ae016011882cf62c99d7bb5dee8386afa6e1 [^]

fixes BUG-43336:Applied new HQL Style

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
---
(0118368)
hgbot (developer)
2020-03-06 12:28

 Repository: erp/devel/pi
Changeset: 09285ef380dfdf2743c74f81fbe2ec0a6768baa5
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 26 13:46:14 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/09285ef380dfdf2743c74f81fbe2ec0a6768baa5 [^]

related to ISSUE-43336: Applied Sonarlint suggestions and more

-Finals added
-Sonarlint suggestions applied

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
---
(0118369)
dmiguelez (viewer)
2020-03-06 12:29

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-02-26 11:45 inigo_lerga New Issue
2020-02-26 11:45 inigo_lerga Assigned To => inigo_lerga
2020-02-26 11:45 inigo_lerga OBNetwork customer => No
2020-02-26 11:45 inigo_lerga Modules => Core
2020-02-26 11:45 inigo_lerga Triggers an Emergency Pack => No
2020-02-26 11:45 inigo_lerga Relationship added related to 0041287
2020-02-26 11:45 inigo_lerga Status new => scheduled
2020-02-26 12:43 inigo_lerga Note Added: 0118118
2020-02-26 13:51 inigo_lerga Description Updated View Revisions
2020-03-06 12:28 hgbot Checkin
2020-03-06 12:28 hgbot Note Added: 0118367
2020-03-06 12:28 hgbot Status scheduled => resolved
2020-03-06 12:28 hgbot Resolution open => fixed
2020-03-06 12:28 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6dd3ae016011882cf62c99d7bb5dee8386afa6e1 [^]
2020-03-06 12:28 hgbot Checkin
2020-03-06 12:28 hgbot Note Added: 0118368
2020-03-06 12:29 dmiguelez Review Assigned To => dmiguelez
2020-03-06 12:29 dmiguelez Note Added: 0118369
2020-03-06 12:29 dmiguelez Status resolved => closed
2020-03-06 12:29 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker