Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043267
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-19 14:472020-03-02 12:58
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revisionc90d48fda937
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043267: Apply new HQL Style in DocDoubtfulDebt.java

DescriptionDocDoubtfulDebt.java has two HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0117953)
inigo_lerga (viewer)
2020-02-19 17:02
edited on: 2020-03-02 12:56

 --Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
    - Go to the Process Request window and select the
      "Acct Server Process" record and Unschedule it.
    - Create a new record in this same window with the Process
      "Acct Server Process" and "Run Inmediately" as Timing.
    - Go to Business Partner Category window and select: Customer - Tier 1
      - Go to Accouting Tab and fill the information for Doubtful Debt, Bad Debt Expense, Bad Debt Revenue and Allowance for Doubtful Debt Accounts for both General Ledgers.
    - Go to Sales Invoice window and create a new record
      with "Alimentos y Supermercados, S.A" as Business Partner.
      Make sure that the Invoice Date of the record is at least
      3 months before today.
      Go to the Lines Tab and create a new Line with "Agua sin Gas 1L"
      as Product and 70 as Invoice Quantity.
      Save the record and Complete it.
    - Go to the Doubtful Debt Run and create a new record. Select the
      Doubtful Debt that appears in the popup window after pressing
      the Select Doubtful Debt button. Press Done.
      Process the record.
    - Go back to the Process Request window and Schedule the previously
      created record.
      
    #In this moment the modified HQL is executed#
(0118245)
hgbot (developer)
2020-03-02 12:57

 Repository: erp/devel/pi
Changeset: c90d48fda937def6b279408dc81b3747dcff58bb
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 19 15:58:54 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c90d48fda937def6b279408dc81b3747dcff58bb [^]

fixes BUG-43267:Applied new HQL Style

---
M src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebt.java
---
(0118246)
hgbot (developer)
2020-03-02 12:57

 Repository: erp/devel/pi
Changeset: 5a674509b3ac5ca03ae2d86f5e434599366be70b
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Feb 19 16:48:03 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5a674509b3ac5ca03ae2d86f5e434599366be70b [^]

related to ISSUE-43267: Applied Sonarlint suggestions and more

Sonarlint suggestions applied.
Finals added.

---
M src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebt.java
---
(0118247)
dmiguelez (viewer)
2020-03-02 12:58

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-02-19 14:47 inigo_lerga New Issue
2020-02-19 14:47 inigo_lerga Assigned To => inigo_lerga
2020-02-19 14:47 inigo_lerga OBNetwork customer => No
2020-02-19 14:47 inigo_lerga Modules => Core
2020-02-19 14:47 inigo_lerga Triggers an Emergency Pack => No
2020-02-19 14:47 inigo_lerga Relationship added related to 0041287
2020-02-19 15:19 inigo_lerga Description Updated View Revisions
2020-02-19 15:19 inigo_lerga Status new => scheduled
2020-02-19 17:02 inigo_lerga Note Added: 0117953
2020-03-02 12:56 dmiguelez Note Edited: 0117953 View Revisions
2020-03-02 12:57 hgbot Checkin
2020-03-02 12:57 hgbot Note Added: 0118245
2020-03-02 12:57 hgbot Status scheduled => resolved
2020-03-02 12:57 hgbot Resolution open => fixed
2020-03-02 12:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c90d48fda937def6b279408dc81b3747dcff58bb [^]
2020-03-02 12:57 hgbot Checkin
2020-03-02 12:57 hgbot Note Added: 0118246
2020-03-02 12:58 dmiguelez Review Assigned To => dmiguelez
2020-03-02 12:58 dmiguelez Note Added: 0118247
2020-03-02 12:58 dmiguelez Status resolved => closed
2020-03-02 12:58 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker