Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038320
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminorhave not tried2018-04-10 21:002018-04-11 17:17
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q3
StatusclosedFix in branchFixed in SCM revision9dbfcefcae0b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038320: API-Change for removal of 4 obsolete fop-related reports (RptM_Inout, RptM_Movement, RptC_Settlement, PromissoryNote)

DescriptionAll those 4 reports are still using the old obsolete FOP rendering technology and not jasperreports.

- RptM_Inout has an ad_process entry but it is not referenced anywhere in pi
- Rpt_Movement has an ad_process entry but it is not referenced anywhere in pi
- RptC_Settlement
  - is referenced in a window deactivated by default related to the old pre-aprm flow
  - Apart this fop report is broken since 2016 and nobody noticed/reported it since then
- PromissoryNote report is also used only in 2 tabs deactivated by default and related to the old pre-aprm flow.

Checking all modules did not find any users in any module referencing them.

So in short risk for this api change should be very low.
Steps To Reproduce-
TagsApproved
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0038321 closedshuehner Retail Modules Retail issue to update all 3 retail sampledata's in relation to 4 ad_process deletions in pi. 
related to feature request 0037875 closedshuehner Openbravo ERP Delete report RptM_Inout (based on old fop, not used) 
related to feature request 0037876 closedshuehner Openbravo ERP Delete report RptM_Movement (based on old fop, no ad_menu, not used for printing) 
related to feature request 0037880 closedshuehner Openbravo ERP Remove broken report "Settlement", used in print button of old-flow window "Settlement" (pre-aprm), as uses obsolete fop 
related to feature request 0037881 closedshuehner Openbravo ERP Remove report "Promissory Note" based on old fop technology and only use for old pre-aprm flow in deactivated window. 

-  Notes
(0103789)
shuehner (administrator)
2018-04-10 21:02

 Note: This API change has been discussed by mail with DME & VMA and got OK to go ahead from both in the mail thread -> Adding Approved marker here accordingly.

For checking modules the following search have been done in download of all publishes modules to ensure no 'relevant references'. While (see below) a few text-matches are present none really relates to the deletes topics from this issue:
Notes: 37875 -> RptM_inout
grep -Ir RptM_Inout
-> find many text-revs but all for jrxml (not touched here) + custom stuff
grep -Ir '\[117\]' | grep AD_PROCESS_ID
grep -Ir 800794

Notes: 37876 -> RptM_Movement
-> find several text-revs but all for jrxml (not touched here) + custom stuff
grep -Ir 80050
-> none for process_id
grep -Ir 800882

Notes: 37880 -> RptC_Settlement
grep -Ir RptC_Settlement
grep -Ir 800070 | grep AD_PROCESS_ID
grep -Ir 800830

Notes: 37881 -> RptPromissoryNote
grep -Ir RptPromissoryNote
grep -Ir 800101 | grep AD_PROCESS_ID
grep -Ir 800874
(0103790)
hgbot (developer)
2018-04-10 21:13

 Repository: erp/devel/api-checks
Changeset: 95f5cb00d058ffe77344232ac76c5baa5498b8de
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Apr 10 21:06:18 2018 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/95f5cb00d058ffe77344232ac76c5baa5498b8de [^]

Fixed 38320. Api-check commit for removal 4 obsolete reports.

---
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M model/src-db/database/sourcedata/AD_PROCESS.xml
---
(0103800)
hgbot (developer)
2018-04-10 21:51

 Repository: erp/devel/api-checks
Changeset: 9dbfcefcae0b140a1aed57e81e1beab679887091
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Apr 10 21:51:11 2018 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/9dbfcefcae0b140a1aed57e81e1beab679887091 [^]

Fixed 38320. 2nd part of ack removed java files.

Previous commit forgot to acknowledge the planned removal of 4 classes in api,
but had only touched the model part.

---
M java/reference/java.japi.gz
---
(0103810)
hgbot (developer)
2018-04-11 14:11

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.sampledata
Changeset: c80b01a2ccdbd0d54366722aa86171f060a0ede3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Apr 11 14:11:41 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.sampledata/rev/c80b01a2ccdbd0d54366722aa86171f060a0ede3 [^]

Related to issue 38320: removed process access after API change in 18Q3

---
M referencedata/sampledata/AWO_QA/AD_PROCESS_ACCESS.xml
---
(0103829)
vmromanos (viewer)
2018-04-11 17:17

 API-check job successfully passed.
AWO sampledata adapted too and mod-awo successfully passed.

- Issue History
Date Modified Username Field Change
2018-04-10 21:00 shuehner New Issue
2018-04-10 21:00 shuehner Assigned To => shuehner
2018-04-10 21:00 shuehner OBNetwork customer => No
2018-04-10 21:00 shuehner Modules => Core
2018-04-10 21:00 shuehner Triggers an Emergency Pack => No
2018-04-10 21:00 shuehner Relationship added related to 0037875
2018-04-10 21:00 shuehner Relationship added related to 0037876
2018-04-10 21:00 shuehner Relationship added related to 0037880
2018-04-10 21:00 shuehner Relationship added related to 0037881
2018-04-10 21:02 shuehner Note Added: 0103789
2018-04-10 21:05 shuehner Tag Attached: Approved
2018-04-10 21:13 hgbot Checkin
2018-04-10 21:13 hgbot Note Added: 0103790
2018-04-10 21:13 hgbot Status new => resolved
2018-04-10 21:13 hgbot Resolution open => fixed
2018-04-10 21:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/95f5cb00d058ffe77344232ac76c5baa5498b8de [^]
2018-04-10 21:18 shuehner Review Assigned To => vmromanos
2018-04-10 21:51 hgbot Checkin
2018-04-10 21:51 hgbot Note Added: 0103800
2018-04-10 21:51 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/api-checks/rev/95f5cb00d058ffe77344232ac76c5baa5498b8de [^] => http://code.openbravo.com/erp/devel/api-checks/rev/9dbfcefcae0b140a1aed57e81e1beab679887091 [^]
2018-04-11 14:11 hgbot Checkin
2018-04-11 14:11 hgbot Note Added: 0103810
2018-04-11 17:15 vmromanos Relationship added related to 0038321
2018-04-11 17:17 vmromanos Note Added: 0103829
2018-04-11 17:17 vmromanos Status resolved => closed
2018-04-11 17:17 vmromanos Fixed in Version => 3.0PR18Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker