Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0038141 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 07. Sales management | minor | have not tried | 2018-03-14 15:09 | 2018-03-19 16:19 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | Sandrahuguet | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR18Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 6033a86144f7 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | aferraz | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0038141: FIN_Utility.getDocumentType is not using bind-variables | |||||||
| Description | The following code is not using bind-variables: see tracking issue for list of reasons why that is bad. whereOrderByClause.append(" as dt where dt.organization.id in ("); whereOrderByClause.append(Utility.getInStrSet(new OrganizationStructureProvider() .getParentTree(org.getId(), true))); whereOrderByClause.append(") and dt.client.id = '" + client.getId() + "' and dt.documentCategory = '" + docCategory + "' order by ad_isorgincluded('" + org.getId() + "', dt.organization.id, '" + client.getId() + "') , dt.default desc, dt.id desc"); OBQuery<DocumentType> dt = OBDal.getInstance().createQuery(DocumentType.class, whereOrderByClause.toString()); | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0103300) hgbot (developer) 2018-03-16 08:21 |
Repository: erp/devel/pi Changeset: 6033a86144f7ea740edff36bd207aeb060be1426 Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Thu Mar 15 16:21:15 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/6033a86144f7ea740edff36bd207aeb060be1426 [^] Fixed issue 38141 use bind-variables in FIN_Utility.getDocumentType --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java --- |
|
(0103312) hgbot (developer) 2018-03-16 12:00 |
Repository: erp/devel/pi Changeset: 57d94fae1907b4c2371488fbafd6f0f45bd3dc60 Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri Mar 16 11:59:46 2018 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/57d94fae1907b4c2371488fbafd6f0f45bd3dc60 [^] Related to issue 38141: Code review improvements Make query more readable. Update license year. --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java --- |
|
(0103313) aferraz (manager) 2018-03-16 12:06 |
Code review + Testing OK |
|
(0103328) hudsonbot (developer) 2018-03-16 17:29 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5323533018b6 [^] Maturity status: Test |
|
(0103350) hudsonbot (developer) 2018-03-19 16:19 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/07f42b4b2051 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-03-14 15:09 | shuehner | New Issue | |
| 2018-03-14 15:09 | shuehner | Assigned To | => Triage Finance |
| 2018-03-14 15:09 | shuehner | Modules | => Core |
| 2018-03-14 15:09 | shuehner | Triggers an Emergency Pack | => No |
| 2018-03-14 15:09 | shuehner | Relationship added | blocks 0038136 |
| 2018-03-14 16:34 | shuehner | Assigned To | Triage Finance => Sandrahuguet |
| 2018-03-15 11:29 | Sandrahuguet | Status | new => scheduled |
| 2018-03-16 08:21 | hgbot | Checkin | |
| 2018-03-16 08:21 | hgbot | Note Added: 0103300 | |
| 2018-03-16 08:22 | hgbot | Status | scheduled => resolved |
| 2018-03-16 08:22 | hgbot | Resolution | open => fixed |
| 2018-03-16 08:22 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/6033a86144f7ea740edff36bd207aeb060be1426 [^] |
| 2018-03-16 08:32 | Sandrahuguet | Review Assigned To | => aferraz |
| 2018-03-16 12:00 | hgbot | Checkin | |
| 2018-03-16 12:00 | hgbot | Note Added: 0103312 | |
| 2018-03-16 12:06 | aferraz | Note Added: 0103313 | |
| 2018-03-16 12:06 | aferraz | Status | resolved => closed |
| 2018-03-16 12:06 | aferraz | Fixed in Version | => 3.0PR18Q2 |
| 2018-03-16 17:29 | hudsonbot | Checkin | |
| 2018-03-16 17:29 | hudsonbot | Note Added: 0103328 | |
| 2018-03-19 16:19 | hudsonbot | Checkin | |
| 2018-03-19 16:19 | hudsonbot | Note Added: 0103350 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |