Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0033042

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

design defect

[Openbravo ERP] 07. Sales management

minor

always

2016-05-25 08:59

2017-09-28 15:32

Reporter

AtulOpenbravo

View Status

public

Assigned To

Triage Omni OMS

Priority

normal

Resolution

open

Fixed in Version

Status

new

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0033042: Partially shipped Goods Shipment Line is linked to completely invoiced Sales Invoice Line

Description

Create Shipment from Order links partially shipped Goods Shipment Line to completely invoiced Sales Invoice Line

Steps To Reproduce

- Login as F&B Internaltional Group Admin.
- Create a Sales Order with F&B US inc Organization for Business Partner "Moon Light Restaurants" with Invoice Terms Immediate.
- In Lines select product "Plain Water" quantity 10.
- Book the Order.
- Navigate to Goods Shipment and create header for same business partner as above.
- Using Create Line from order select above line for Plain Water, Storage Locator as Ec-0-0-0.
- Check the line inserted in Goods Shipment Lines Tab. Edit the Quantity as set it as 5.
- Process the Shipment.
- Navigate to Create Invoices from Order, select above Order, Invoice Date = Today's Date, Process it.
- Check that Sales Invoice is created with 1 line, Quantity = 10.
- Navigate to Create Shipment from Order, select above Order and process it.
- Check that Shipment is created for remaining quantity = 5.
- Navigate to Sales Invoice Line, check in More Information Tab recently created shipment line (by Create shipment from Orders process) is linked.
As this is partially shipped line this behavior cannot be treated as correct. Check that as Order Line as two shipment lines associated and only one invoice line associated.

Proposed Solution

A check should be provided before linking Goods Shipment Line with Sales Invoice Line whether the quantities are matched or not.

Attached possible solution.

Tags

No tags attached.

33042.diff [^] (1,182 bytes) 2016-05-25 10:02 [Show Content] [Hide Content]

# HG changeset patch
# User Atul Gaware <atul.gaware@openbravo.com>
# Date 1462471333 -19800
#      Thu May 05 23:32:13 2016 +0530
# Node ID 811d817dfdab54eddc9e784269ca6a35b93ac4e2
# Parent  a6cbad47ab80b521388ac1d3a211fe5213fe72bd
Fixes issue 33042: Wrong link between SalesInvoice Line and GoodsShipment Line

Partially shipped, when invoice created with Create Invoice from Order having Immediate = Invoice Term, Process Shipment From Order updates
Invoice Line with partial shipment line reference (this is wrong).
M_INOUT_CREATE avoids this update.

diff -r a6cbad47ab80 -r 811d817dfdab src-db/database/model/functions/M_INOUT_CREATE.xml
--- a/src-db/database/model/functions/M_INOUT_CREATE.xml	Wed May 04 16:40:02 2016 +0200
+++ b/src-db/database/model/functions/M_INOUT_CREATE.xml	Thu May 05 23:32:13 2016 +0530
@@ -706,7 +706,8 @@
                 Updated=now(),
                 UpdatedBy=v_User_ID
             WHERE C_ORDERLINE_ID=ol.C_OrderLine_ID
-            AND M_INOUTLINE_ID IS NULL;
+            AND M_INOUTLINE_ID IS NULL
+            AND v_Qty = QtyInvoiced;
             --<<Next_Line>>
             Next_Line:=false;
             FETCH Cur_OrderLine INTO ol;

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0032709		closed	AtulOpenbravo	Sales Invoice - Invoice Term=Immediate does not create link to Good Shipment in Sales Invoice
related to	defect	0032938		closed	AtulOpenbravo	It is necessary a script to add the 1-1 relation between sales invoice line and goods shipment line
related to	defect	0032560		closed	AtulOpenbravo	Allow to invoice an already invoiced goods receipt
related to	design defect	0022601		new	Triage Omni OMS	Design Defect in Sales Business Flow when an Invoice is created before a partial Goods Shipment
related to	defect	0040278		closed	AtulOpenbravo	Create Shipments From Orders is linking invoice lines with shipment lines that have different products if the order is invoiced

Notes
(0088327) vmromanos (manager) 2016-07-08 11:13	Currently there is no way to link an invoice line with several m_inoutlines. Moved to design defect.

Issue History
Date Modified	Username	Field	Change
2016-05-25 08:59	AtulOpenbravo	New Issue
2016-05-25 08:59	AtulOpenbravo	Assigned To	=> Triage Finance
2016-05-25 08:59	AtulOpenbravo	Modules	=> Core
2016-05-25 08:59	AtulOpenbravo	Triggers an Emergency Pack	=> No
2016-05-25 09:01	AtulOpenbravo	Relationship added	related to 0032709
2016-05-25 10:01	aferraz	Issue Monitored: aferraz
2016-05-25 10:02	aferraz	File Added: 33042.diff
2016-05-25 10:02	aferraz	Proposed Solution updated
2016-05-31 10:28	aferraz	Relationship added	related to 0032938
2016-07-08 11:11	vmromanos	Type	defect => design defect
2016-07-08 11:12	vmromanos	Relationship added	related to 0032560
2016-07-08 11:13	vmromanos	Note Added: 0088327
2017-04-19 13:31	ngarcia	Relationship added	related to 0022601
2017-04-19 13:32	ngarcia	Issue Monitored: ngarcia
2017-09-28 15:32	ngarcia	Note Added: 0099656
2017-09-28 15:43	ngarcia	Note Edited: 0099656	View Revisions
2017-09-28 15:44	ngarcia	Note Deleted: 0099656
2019-02-28 07:42	AtulOpenbravo	Relationship added	related to 0040278

Copyright © 2000 - 2009 MantisBT Group